Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10452942
  
    --- Diff: autotest/tests/contacts.tests.js ---
    @@ -363,39 +375,93 @@ describe("Contacts (navigator.contacts)", function () 
{
              });
             // HACK: there is a reliance between the previous and next test. 
This is bad form.
             it("contacts.spec.21 update a contact", function() {
    -
                 // this api requires manual user confirmation on WP7/8 so skip 
it
                 if (isWindowsPhone) return;
     
    -            expect(gContactObj).toBeDefined();
    +            var bDay = new Date(1976, 6,4);
    --- End diff --
    
    Sure, don't worry about this. Just fix the space :)
    
    Also, I'm assuming that 'bDay' is birthday, I'd suggest using two distinct 
variables for the two dates with names that are sufficiently descriptive for 
people to understand what you're doing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to