[VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Niklas Merz
|Please review and vote on this 6.2.0 cordova-ios release by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ The package was published from its corresponding git tag: cor

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Niklas Merz
Sending again and hopefully now the line breaks work. Please review and vote on this 6.2.0 cordova-ios release by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ The p

Re: [VOTE] cordova-ios 6.2.0 Release

2021-02-01 Thread Chris Brody
Approved with the following nit: I noticed that for some reason, the 6.2.0 tag is *not* on the master branch. I recall this happening in the past and am definitely aware that this happens due to the way that cordova-coho works. I sincerely hope that steps will be taken to keep major and minor re

Re: [DISCUSS] cordova-ios minor release 6.2.0

2021-02-01 Thread Niklas Merz
Commenting on Chris Brodys vote: >Approved with the following nit: > I noticed that for some reason, the 6.2.0 tag is *not* on the master branch. > I recall this happening in the past and am definitely aware that this happens due to the way that cordova-coho works. > I sincerely hope that steps

[Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Norman Breau
Hi team, I'm planning on making a release for cordova-plugin-wkwebview-engine version 1.2.2. The goal of this release is to ensure that the plugin does not install on iOS 6.x Does anyone have any reason to delay a cordova-plugin-wkwebview-engine release? If not, I will start the release tom

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Chris Brody
Shouldn't the goal "not to install on cordova-ios 6.x or above" be considered a breaking change? Or am I being too pedantic about this? On Mon, Feb 1, 2021 at 10:09 PM Norman Breau wrote: > Hi team, > > I'm planning on making a release for cordova-plugin-wkwebview-engine > version 1.2.2. > The

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Norman Breau
No you're right, it should have a major version bump. I can prepare a PR to do this. On 2021-02-01 11:14 p.m., Chris Brody wrote: Shouldn't the goal "not to install on cordova-ios 6.x or above" be considered a breaking change? Or am I being too pedantic about this? On Mon, Feb 1, 2021 at 10:0

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Norman Breau
Actually, I'm having second thoughts... The wkwebview plugin never supported iOS 6.x to begin with. We aren't restricting any previous usage (such as dropping support for iOS 5 for example). We are simply declaring that this plugin won't work on >= 6.x. Additionally, if we make this a major ve

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Bryan Ellis
+1 for the patch On Tue, Feb 2, 2021 at 12:24 PM Norman Breau wrote: > Actually, I'm having second thoughts... > > The wkwebview plugin never supported iOS 6.x to begin with. We aren't > restricting any previous usage (such as dropping support for iOS 5 for > example). We are simply declaring th

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Chris Brody
Just to be pedantic: do we know what would have happened if someone tried installing this plugin with cordova-ios 6? On Mon, Feb 1, 2021 at 10:28 PM Bryan Ellis wrote: > +1 for the patch > > On Tue, Feb 2, 2021 at 12:24 PM Norman Breau > wrote: > > > Actually, I'm having second thoughts... > >

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Norman Breau
It causes building to fail. We've had a few bug reports such as this one: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/177 On 2021-02-01 11:40 p.m., Chris Brody wrote: Just to be pedantic: do we know what would have happened if someone tried installing this plugin with cordo

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Chris Brody
+1 for the patch release, then. I think the rationale is perfect. Thanks! On Mon, Feb 1, 2021 at 10:47 PM Norman Breau wrote: > It causes building to fail. We've had a few bug reports such as this > one: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/177 > > On 2021-02-01 11:4

Re: [Discuss] cordova-plugin-wkwebview-engine Release 1.2.2

2021-02-01 Thread Niklas Merz
+1 from me for a patch release, too February 2, 2021 5:07 AM, "Chris Brody" wrote: > +1 for the patch release, then. I think the rationale is perfect. Thanks! > > On Mon, Feb 1, 2021 at 10:47 PM Norman Breau wrote: > >> It causes building to fail. We've had a few bug reports such as this >> o