Approved with the following nit: I noticed that for some reason, the 6.2.0 tag is *not* on the master branch.
I recall this happening in the past and am definitely aware that this happens due to the way that cordova-coho works. I sincerely hope that steps will be taken to keep major and minor release tags on the master branch in the future. And thanks for making the release! On Mon, Feb 1, 2021 at 1:24 PM Niklas Merz <niklasm...@apache.org> wrote: > Sending again and hopefully now the line breaks work. > > Please review and vote on this 6.2.0 cordova-ios release > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ > > The package was published from its corresponding git tag: > cordova-ios: 6.2.0 (87c6d53a39) > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-ios#6.2.0 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Please also review the blog post for this release: > https://github.com/apache/cordova-docs/pull/1151 > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * Ran ios and lib unit tests successfully > * Ran builds with new project and bin scripts > > Am 01.02.21 um 19:21 schrieb Niklas Merz: > > |Please review and vote on this 6.2.0 cordova-ios release by replying to > > this email (and keep discussion on the DISCUSS thread) The archive has > > been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/cordova-ios-6.2.0/ The > > package was published from its corresponding git tag: cordova-ios: 6.2.0 > > (87c6d53a39) Note that you can test it out via: cordova platform add > > https://github.com/apache/cordova-ios#6.2.0 Upon a successful vote I > > will upload the archive to dist/, publish it to npm, and post the blog > > post. Voting guidelines: > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Please also review the blog post for this release: > > https://github.com/apache/cordova-docs/pull/1151 Voting will go on for a > > minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over > > the relevant repos * Ran coho check-license to ensure all dependencies > > and subdependencies have Apache-compatible licenses * Ensured continuous > > build was green when repo was tagged * Ran ios and lib unit tests > > successfully * Ran builds with new project and bin scripts| > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
