+1 for the patch release, then. I think the rationale is perfect. Thanks!
On Mon, Feb 1, 2021 at 10:47 PM Norman Breau <nor...@normanbreau.com> wrote: > It causes building to fail. We've had a few bug reports such as this > one: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/177 > > On 2021-02-01 11:40 p.m., Chris Brody wrote: > > Just to be pedantic: do we know what would have happened if someone tried > > installing this plugin with cordova-ios 6? > > > > > > On Mon, Feb 1, 2021 at 10:28 PM Bryan Ellis <er...@apache.org> wrote: > > > >> +1 for the patch > >> > >> On Tue, Feb 2, 2021 at 12:24 PM Norman Breau <nor...@nbsolutions.ca> > >> wrote: > >> > >>> Actually, I'm having second thoughts... > >>> > >>> The wkwebview plugin never supported iOS 6.x to begin with. We aren't > >>> restricting any previous usage (such as dropping support for iOS 5 for > >>> example). We are simply declaring that this plugin won't work on >= > 6.x. > >>> Additionally, if we make this a major version bump, then users won't > >>> receive this update unless if it was a conscious update choice. > >>> > >>> I feel like this update should actually be a patch, not a major. > >>> > >>> On 2021-02-01 11:15 p.m., Norman Breau wrote: > >>>> No you're right, it should have a major version bump. I can prepare a > >>>> PR to do this. > >>>> > >>>> On 2021-02-01 11:14 p.m., Chris Brody wrote: > >>>>> Shouldn't the goal "not to install on cordova-ios 6.x or above" be > >>>>> considered a breaking change? Or am I being too pedantic about this? > >>>>> > >>>>> > >>>>> On Mon, Feb 1, 2021 at 10:09 PM Norman Breau <nor...@nbsolutions.ca> > >>>>> wrote: > >>>>> > >>>>>> Hi team, > >>>>>> > >>>>>> I'm planning on making a release for cordova-plugin-wkwebview-engine > >>>>>> version 1.2.2. > >>>>>> The goal of this release is to ensure that the plugin does not > >> install > >>>>>> on iOS 6.x > >>>>>> > >>>>>> Does anyone have any reason to delay a > >> cordova-plugin-wkwebview-engine > >>>>>> release? > >>>>>> If not, I will start the release tomorrow. > >>>>>> > >>>>>> Related: > >>>>>> > >>>>>> > >> > https://lists.apache.org/thread.html/r0c604267ded0c7316a8a828f11d4f34a43b3da28197bb2b288a0e197%40%3Cdev.cordova.apache.org%3E > >>>>>> > >>>>>> > >>>>>> > --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>>>>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>>>>> > >>>>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >>> For additional commands, e-mail: dev-h...@cordova.apache.org > >>> > >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
