[VOTE] Cordova-Lib 9.0.0 Release

2019-03-15 Thread Bryan Ellis
Please review and vote on this Cordova Lib Release v9.0.0 by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://github.com/apache/cordova/issues/10 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/GH-10 The package

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Oliver Salzburg
I really think we should get #680[1] merged before the release. It should be good in a moment. [1]: https://github.com/apache/cordova-lib/pull/680 On 14/03/2019 07:31, Bryan Ellis wrote: Does anyone have any reason to delay the Cordova Lib release? Any outstanding patches to land? If not, I w

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Jan Piotrowski
The PR is marked as Work in Progress. If you want it to get reviewed and merged you should remove that. Am Fr., 15. März 2019 um 13:18 Uhr schrieb Oliver Salzburg : > > I really think we should get #680[1] merged before the release. > > It should be good in a moment. > > [1]: https://github.com/ap

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Oliver Salzburg
I never marked it as such and the tests only passed a couple moments ago. Excuse the unreasonable delays! On 15/03/2019 14:24, Jan Piotrowski wrote: The PR is marked as Work in Progress. If you want it to get reviewed and merged you should remove that. Am Fr., 15. März 2019 um 13:18 Uhr schrie

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Bryan Ellis
>From the discussion in the PR, I believe the work is not actually completed. As read in the PR comments, the temporary commits should be removed and placed into common, which appears to not have been completed. Since the vote had already been submitted hours before this PR was passing, and this

Nightly build #1031 for cordova has succeeded!

2019-03-15 Thread Apache Jenkins Server
Nightly build #1031 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/1031/consoleFull - Jenkins for Apache Cordova ---

Re: [DISCUSS] Cordova Lib 9.0.0 Release

2019-03-15 Thread Jesse
The pr appears to be a minor change, correct me if I am wrong. If it means we do a 9.0.1 or even a 9.1 in a week or 2, that is fine. I would only wait if it was to avoid another sudden major bump. If everything here is correct, I say we keep moving forward. Also, thank you Erisan for your work to

Re: [VOTE] Cordova-Lib 9.0.0 Release

2019-03-15 Thread Jesse
+1 - coho verify-archive on dist/dev release - npm audit + npm test - ci green @purplecabbage risingj.com On Fri, Mar 15, 2019 at 2:09 AM Bryan Ellis wrote: > Please review and vote on this Cordova Lib Release v9.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > >

Re: [VOTE] Cordova-Electron 1.0.2 Release

2019-03-15 Thread Jesse
+1 - coho verify-archive - ci green - npm audi + npm test @purplecabbage risingj.com On Thu, Mar 14, 2019 at 10:40 PM Bryan Ellis wrote: > Please review and vote on this Electron Release v1.0.2 > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https:/