+1 - coho verify-archive - ci green - npm audi + npm test
@purplecabbage risingj.com On Thu, Mar 14, 2019 at 10:40 PM Bryan Ellis <er...@apache.org> wrote: > Please review and vote on this Electron Release v1.0.2 > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://github.com/apache/cordova/issues/10 > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/GH-10 > > The package was published from its corresponding git tag: > cordova-electron: 1.0.2 (354831709b) > > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-electron#1.0.2 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test
