The pr appears to be a minor change, correct me if I am wrong. If it means we do a 9.0.1 or even a 9.1 in a week or 2, that is fine. I would only wait if it was to avoid another sudden major bump. If everything here is correct, I say we keep moving forward.
Also, thank you Erisan for your work to keep the release train rolling. > On Mar 15, 2019, at 7:00 PM, Bryan Ellis <ellis.br...@gmail.com> wrote: > > From the discussion in the PR, I believe the work is not actually > completed. > > As read in the PR comments, the temporary commits should be removed and > placed into common, which appears to not have been completed. > > Since the vote had already been submitted hours before this PR was passing, > and this PR still have some pre-requirements before merging, for example, > the new common release, I would like to continue with the current vote. > > > > From: Salzburg Oliver <oliver.salzb...@gmail.com> > <oliver.salzb...@gmail.com> > Reply: dev@cordova.apache.org <dev@cordova.apache.org> > <dev@cordova.apache.org> > Date: March 15, 2019 at 22:31:22 > To: dev@cordova.apache.org <dev@cordova.apache.org> <dev@cordova.apache.org>, > Piotrowski Jan <piotrow...@gmail.com> <piotrow...@gmail.com> > Subject: Re: [DISCUSS] Cordova Lib 9.0.0 Release > > I never marked it as such and the tests only passed a couple moments ago. > > Excuse the unreasonable delays! > >> On 15/03/2019 14:24, Jan Piotrowski wrote: >> The PR is marked as Work in Progress. If you want it to get reviewed >> and merged you should remove that. >> >> Am Fr., 15. März 2019 um 13:18 Uhr schrieb Oliver Salzburg >> <oliver.salzb...@gmail.com>: >>> I really think we should get #680[1] merged before the release. >>> >>> It should be good in a moment. >>> >>> [1]: https://github.com/apache/cordova-lib/pull/680 >>> >>>> On 14/03/2019 07:31, Bryan Ellis wrote: >>>> Does anyone have any reason to delay the Cordova Lib release? >>>> Any outstanding patches to land? >>>> >>>> If not, I will start the release tomorrow. >>>> >>>> The versions to be released are: >>>> cordova-lib@9.0.0 >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >>> For additional commands, e-mail: dev-h...@cordova.apache.org >>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
