Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-compress/commit/1e592b52c54ff3186b5d11fe64021ab758db7234#commitcomment-14393072
In src/changes/changes.xml:
In src/changes/changes.xml on line 50:
"fpr" should be "for
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/74
Thanks! ð
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/75
Thanks! ð
It would be nice if you could fix the check-style violations, see:
https://travis-ci.org/apache/commons-text/jobs/297158450
Run `mvn checkstyle:check
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/73
patch has some check-style violations, see:
https://travis-ci.org/apache/commons-text/jobs/294087452
---
-
To
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/76
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/73
+1
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/44
I'm closing this as `StrLookup` will deprecated and replaced with
`StringLookup` in the next release.
---
---
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/78
Require Java 8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text java_8
Alternatively you can review
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/79
Upgrade to JUnit 5.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text junit_5
Alternatively you can
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
The only problem I encountered was that I had to delete the existing JUnit
run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not
seem to be able to upd
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
JUnit 5 should work with any Eclipse Version released during the last year
(as long as you delete existing run configurations for the project).
@garydgregory Can you give
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
Great!
@kinow Thanks in-depth check!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/80
travis: add Java 10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text travis_jdk10
Alternatively you
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-text/pull/80
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/80
Not yet available on travis: `Sorry, but JDK 'oraclejdk10' is not known.`
---
-
To unsubscribe, e
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/81
Travis: Add Java 10 "Oracle JDK", Java 10 "OpenJDK", Java 11 "Oracle â¦
â¦JDK"
You can merge this pull request into a Git repository by running:
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/81
Currently javadoc fails on java 11 with:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:javadoc (default-cli) on
project commons
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/82
Replace FindBugs with SpotBugs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text spotbugs
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-io/pull/63
Travis: Add oraclejdk10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-io travis_java_10
Alternatively
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/84
Thanks! ð
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/86
Travis: Use Java 11 supplied by travis (simplifies .travis.yml)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/90
Travis: Also build with openjdk-ea
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-io/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-compress/commit/7c93eb18bad8612fe7cd4e6d27bd413b1fafc978#commitcomment-19842390
In README.md:
In README.md on line 104:
Looks like some replacing did not work and now the link is dead
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-compress/commit/7c93eb18bad8612fe7cd4e6d27bd413b1fafc978#commitcomment-19849282
In README.md:
In README.md on line 104:
done:
https://github.com/apache/commons-compress/commit
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-io/pull/34
IO-367: Add convenience methods for copyToDirectory (closes #18)
patch supplied by James Sawle
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/41
Let's merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/50
TEXT-90: Add CharacterPredicates for ASCII letters (uppercase/lowercaâ¦
â¦se) and Arabic numerals
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/51
TEXT-91: RandomStringGenerator should be able to generate a String wiâ¦
â¦th a random length
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/45
This does not seem to really work. It looks like ibm jdk build is run after
each (oracle8, openjdk(7|8)) build and actually fails, but the build is still
marked successful, e.g
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/45
I guess this failure is also the reason that the coveralls integration is
broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/45
The build failure I quoted occurs after the findbugs exceptions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/50#discussion_r122292528
--- Diff:
src/test/java/org/apache/commons/text/CharacterPredicatesTest.java ---
@@ -44,4 +44,77 @@ public void testDigits
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/50#discussion_r122294037
--- Diff: src/main/java/org/apache/commons/text/CharacterPredicates.java ---
@@ -48,5 +48,73 @@ public boolean test(int codePoint
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/52
Thanks!
Please separate the formatting fixes and the test additions into different
commits.
Please stick to the existing code style for the new tests (no new line at
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/53
revert "Added IBM Jdk8 build support to travis-ci configuration"
The build fails, but this failure is not reflected in the travis build
status. Code-coverage is broken.
You
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/52
Thanks for splitting the changes. :+1:
But please also address the second part:
>Please stick to the existing code style for the new tests (no new line at
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/52
Thanks. I was not as easy as I expected (I had to merge).
I followed these steps:
`git rebase -i head~5`
Edit the rebase-todo-to to contain:
```
drop
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/56
@jbduncan Check-style for commons-text does is currently not applied to
tests. I think we should look into enabling it.
@TheRealHaui Please fix the things @jbduncan suggested
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/56
@ameyjadiye Try adding the same suppression as commons-lang:
```
```
That should reduce the errors. Maybe their are other checks which can be
reasonably
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595088
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128595517
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r128594766
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -416,6 +416,81 @@ public void
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/57
@arunvinudss While I agree that `isDelimiter` should have been private, it
is public and was released with commons-text `1.1`. Due to the strict binary
compatibilities promise of
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/56
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/58#discussion_r129910754
--- Diff:
src/test/java/org/apache/commons/text/similarity/CosineSimilarityTest.java ---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/59
add oraclejdk9 to travis configuration
add maven java9 profile:
- use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0
do not work on java 9
- skip maven
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/59
Looks like a very complex setup.
But the actual travis report looks good:
https://travis-ci.org/jacoco/jacoco/builds/255021437?utm_source=github_status&utm_medium=notifica
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/58
Thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130549181
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/60#discussion_r130633380
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/60
Thanks! :+1:
By the way: Feel free to raise a jira issue for anything you think that
maybe be a bug (e.g. NullPointerExceptions).
---
If your project is set up for it, you
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/61
In my opinion this is overkill. I don't think commons-text needs to be
tested against the eclipse java compiler and early access version of java 8 and
9. The script looks difficu
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/61
+1 for moving this discussion to the mailing list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
The findbugs version used is not java 6 compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
The findbugs version used is not java 6 compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/61
Also note that currently this script only compiles and runs test. Rat,
clirr, findbugs and javadoc are not executed.
---
If your project is set up for it, you can reply to this email
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23482473
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java:
In src/test/java/org/apache
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23494230
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java:
In src/test/java/org/apache
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-cli/pull/18
.travis.yml: install open-jdk6, as it was removed from the default image
(see https://github.com/travis-ci/travis-ci/issues/8199)
You can merge this pull request into a Git repository
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/63#discussion_r140526804
--- Diff: src/main/java/org/apache/commons/text/FormattableUtils.java ---
@@ -46,6 +46,7 @@
* This constructor is public to permit
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/63
Merged in :
https://github.com/apache/commons-text/commit/5598109efb2365384b9a9110323ed9a7004cc905
Thanks
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
As I said before this can not be merged as it is, because it fails on java
6.
The simple fix of just downgrading the findbugs version can not be applied,
because 2.x versions
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
As I said before this can not be merged as it is, because it fails on java
6.
The simple fix of just downgrading the findbugs version can not be applied,
because 2.x versions
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/65
Thanks for the suggestion, but I'm against merging this, as this makes the
order different from other commons projects.
Replacing `/>` with `>` makes no sense imh
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/64
Thanks for the pull request.
Imho we should make it absolutely clear that users should not use this
method. Therefore I'm against making the formulation &q
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/67
travis: remove travis profile from pom and use travis-jacoco profile â¦
â¦commons-parent
You can merge this pull request into a Git repository by running:
$ git pull https
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/67
Seems to break coverall somehow. (By now there should have been an comment
from the coveralls bot concerning code coverage
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/67
The reason for the coveralls failure:
```
Failed to execute goal
[32morg.eluder.coveralls:coveralls-maven-plugin:4.3.0:report[m
[1m(default-cli)[m on project
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-collections/pull/27
travis: add java 9 to build
pom.xml: add java 9 profile to make build pass
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/27
test failure on java 9: `ListIteratorWrapperTest.testRemove:116 »
ServiceConfiguration sun.util.locale
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/66
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-fileupload/pull/10
@maxxedev Thanks for the pull request! It would be nice if you could close
it, now that @jochenw has merged it. Thanks
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-cli/pull/20
Findbug checkstyle support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-cli
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
Thanks!
I solved the findbugs version problem with:
https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-cli/pull/16
Thanks!
I solved the findbugs version problem with:
https://github.com/apache/commons-cli/commit/2392ae8afc08b496a3eb49908aa421ea86a9679e
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/68
Thanks for the pull request!
It would be nice if you could fix the checkstyle violations. See
https://travis-ci.org/apache/commons-text/jobs/284821493 for details or run
&quo
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-fileupload/pull/11
travis: fix buffer overflow in Java_java_net_Inet4AddressImpl_getLocaâ¦
â¦lHostName of OpenJDK6 and OpenJDK7 when using precise distribution
To fix this use the
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-fileupload/pull/10
@maxxedev Thanks!
The jdk6/7 build failures are unrelated.
https://github.com/apache/commons-fileupload/pull/11 contains the fix for these
failures
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/68
Thanks!
Imho this pull request is good to merge. Only thing that is missing are
`@since 1.2` tags in the javadoc of the new methods.
@chtompki What do you think
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/30
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
`assertEquals(MapUtils.getDouble(in,"key", 0.0), 2.0, 0);` etc. should be
`assertEquals(2.0, MapUtils.getDouble(in,"key", 0.0), 0);` because it is
`assertEq
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/69
Thanks! ð
Concerning the typo in
`org.apache.commons.text.similarity.LongestCommonSubsequence#logestCommonSubsequence`.
If you like, you can submit a new pull
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Thanks! Looking forward to the pull request!
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/29
Sorry about that. :(
But the correct parameter order part of you pull request is still relevant.
It would be nice if you could create a new rebased pull request for that
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-dbutils/pull/4
Thanks for the pull request.
DBUtils currently still requires only java 6, but you are using classes
which were introduced in java 8. Therefore the builds on java 6/7 fail
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-dbutils/pull/4
A possible solution for this problem would be to use reflection instead.
---
-
To unsubscribe, e-mail: dev
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-dbutils/pull/4
I'm sure we will, but as far as I know there is no concrete plan when that
will happen.
---
-
To unsubscri
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-collections/pull/32
Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/70
partial automated migration to assertj
Migrated using a modified version of
https://github.com/joel-costigliola/assertj-core/blob/master/src/main/scripts/convert-junit-assertions-to
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/70
>Cool! Have missed the discussion about introducing this for Text. I like
it.
These was no discussion yet. I just thought I do a quick prototype with a
component after
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/71
Apply (relaxed) checkstyle rules to test and fix existing violations â¦
â¦(incomplete)
Similar to lang.
Not yet finished, there are still around 70 violations left
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/71
Now complete. If I knew before how much work this would be, I would not
have started.
---
-
To unsubscribe, e-mail
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/69
created https://issues.apache.org/jira/browse/TEXT-105 for the typo in
`LongestCommonSubsequence#logestCommonSubsequence
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/69
typo issue fixed in:
https://github.com/apache/commons-text/commit/804e4599bd63e4bb14c905613711eac8829e54fb
Thanks again for reporting
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/70
Sure. AssertJ 2.x for java 7 and 3.x for java 8 have been developed in
parallel for a few years (and currently still are). Java 7 compatible changes
are done in 2.x and then merged
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-codec/pull/10
pom.xml: add java 9 profile
.travis.yml: also build on java 9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher
Github user PascalSchumacher closed the pull request at:
https://github.com/apache/commons-codec/pull/10
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/70
@chtompki What do you think?
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional
1 - 100 of 103 matches
Mail list logo
