Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/52
Thanks for splitting the changes. :+1:
But please also address the second part:
>Please stick to the existing code style for the new tests (no new line at
the beginning and at the end of a test method; single new line between test
methods).
Furthermore it would be very nice if you would clean up the history of the
pull request by using `git rebase` once it is ready to merge.
After you commit the style fixes for the new tests you should be able to
clean-up the history like this:
Use `git rebase -i head~5`. Choose to drop the first two commits
(06e8b3dd06ee2f86490b2e94359d29d2fe04786c and
27e110b37f8f1e1cceee18ab614424f8a807a747). Squash
d23bd1db8c0f21f62006b8cf0f41eb0588997a1e and the last commit. Afterwards use
`push -f` to update the pull request.
After this there will be only two commits (one with the style changes and
one with the new tests) and the commit history of commons-text will be
pristine. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
