Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/50#discussion_r122292528
--- Diff:
src/test/java/org/apache/commons/text/CharacterPredicatesTest.java ---
@@ -44,4 +44,77 @@ public void testDigits() {
assertFalse(CharacterPredicates.DIGITS.test('.'));
assertFalse(CharacterPredicates.DIGITS.test('L'));
}
+
+ @Test
+ public void testArabicNumerals() {
--- End diff --
I personally do not like junit parametrized tests because every test method
has to be in its own class and you have to a lot of boiler plate. For
parametrized test I use https://github.com/TNG/junit-dataprovider
Theories can be nice for testing methods with multiple parameters, although
in my opinion well chosen parameter combinations are often enough. I think
theories are a bit lacking compared to "real" property based testing like
quick-check (no test data generation, no failure shrinking). For java
https://github.com/pholser/junit-quickcheck is the best option I'm aware of,
but it has been requiring java 8 for years.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
