[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-15 Thread stain
Github user stain commented on the issue: https://github.com/apache/commons-rdf/pull/43 Agree with @afs that only the builder-factory bit should be serialized - obviously the actual parser which may be in progress of parsing is tricky to serialize. So we would need to perhaps clean up

[CANCELLED][VOTE] Release Apache Commons Daemon 1.1.0 based on RC2

2017-11-15 Thread Mark Thomas
I'm cancelling this vote and will roll RC3 to pick up the following changes: - packages distributed via Maven Central - binary test artefacts won't be distributed - fix for DAEMON-377 (need to review and apply patch first) I hope to be able to tag and roll the RC later today. Mark On 09/11/17 2

[dbcp] Problem with the downloads of DBCP 2.2

2017-11-15 Thread aquaglow
On the download page (http://commons.apache.org/proper/commons-dbcp/download_dbcp.cgi) the links for the binaries/source of DBCP version 2.2 seem to be broken. This applies to all the mirrors including the backups. Thanks. - To un

Re: commons-io git commit: [IO-553] Add org.apache.commons.io.FilenameUtils.WINDOWS_ILLEGAL_FILE_NAME_CHARS.

2017-11-15 Thread sebb
On 15 November 2017 at 04:13, wrote: > Repository: commons-io > Updated Branches: > refs/heads/master fdcc71dcd -> d8e8908db > > > [IO-553] Add > org.apache.commons.io.FilenameUtils.WINDOWS_ILLEGAL_FILE_NAME_CHARS. > > Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo > Commit: ht

Re: [CANCELLED][VOTE] Release Apache Commons Daemon 1.1.0 based on RC2

2017-11-15 Thread sebb
On 15 November 2017 at 09:59, Mark Thomas wrote: > I'm cancelling this vote and will roll RC3 to pick up the following changes: > > - packages distributed via Maven Central > - binary test artefacts won't be distributed > - fix for DAEMON-377 (need to review and apply patch first) Does DAEMON-378

Re: [CANCELLED][VOTE] Release Apache Commons Daemon 1.1.0 based on RC2

2017-11-15 Thread Mark Thomas
On 15/11/17 10:57, sebb wrote: > On 15 November 2017 at 09:59, Mark Thomas wrote: >> I'm cancelling this vote and will roll RC3 to pick up the following changes: >> >> - packages distributed via Maven Central >> - binary test artefacts won't be distributed >> - fix for DAEMON-377 (need to review a

Re: [dbcp] Problem with the downloads of DBCP 2.2

2017-11-15 Thread sebb
The latest DBCP release is 2.1.1 AIUI 2.2 is in progress. Looks like someone regenerated the site having already changed the download page. I'll fix the live site On 15 November 2017 at 10:30, wrote: > On the download page > (http://commons.apache.org/proper/commons-dbcp/download_dbcp.cgi) th

[VOTE] Release Apache Commons Daemon 1.1.0 based on RC3

2017-11-15 Thread Mark Thomas
It has been 4.5 years since the 1.0.15 release. Since then, there has been a large number of bug fixes and - most notably - changes to enable support for Java 9. Therefore, I am calling the following vote to release RC3 as Apache Commons Daemon 1.1.0 RC3 can be obtained from: https://dist.apache.o

Re: commons-io git commit: [IO-553] Add org.apache.commons.io.FilenameUtils.WINDOWS_ILLEGAL_FILE_NAME_CHARS.

2017-11-15 Thread Gary Gregory
On Nov 15, 2017 03:44, "sebb" wrote: On 15 November 2017 at 04:13, wrote: > Repository: commons-io > Updated Branches: > refs/heads/master fdcc71dcd -> d8e8908db > > > [IO-553] Add > org.apache.commons.io.FilenameUtils.WINDOWS_ILLEGAL_FILE_NAME_CHARS. > > Project: http://git-wip-us.apache.org

Re: commons-io git commit: [IO-553] Add org.apache.commons.io.FilenameUtils.WINDOWS_ILLEGAL_FILE_NAME_CHARS.

2017-11-15 Thread sebb
On 15 November 2017 at 13:34, Gary Gregory wrote: > On Nov 15, 2017 03:44, "sebb" wrote: > > On 15 November 2017 at 04:13, wrote: >> Repository: commons-io >> Updated Branches: >> refs/heads/master fdcc71dcd -> d8e8908db >> >> >> [IO-553] Add >> org.apache.commons.io.FilenameUtils.WINDOWS_ILL

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-15 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/commons-rdf/pull/43 I'd like to get @wikier an answer to his question. It sounds like we are _not_ comfortable merging this for `RC2` and he should go ahead without it, correct? If the consensus is that seri

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-15 Thread wikier
Github user wikier commented on the issue: https://github.com/apache/commons-rdf/pull/43 Having a little understanding on the concrete use case behind this PR, generally speaking I normally prefer having the factories/builders implementing `Serializable`. So in this concrete case I pr

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-15 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/commons-rdf/pull/43 👍 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[lang] StringUtils left and truncate

2017-11-15 Thread Gary Gregory
Hi All, We have both StringUtils.left(String,int) and StringUtils.truncate(String,int) Can we deprecate truncate in favor of left (and add StringUtils.left(String,int, int)) ? I like left() better due to the symmetry with right(). Gary

Fwd: commons-io git commit: Typos and clarifications

2017-11-15 Thread Gary Gregory
Thanks Sebb! Gary -- Forwarded message -- From: Date: Wed, Nov 15, 2017 at 9:53 AM Subject: commons-io git commit: Typos and clarifications To: comm...@commons.apache.org Repository: commons-io Updated Branches: refs/heads/master 2196ff68d -> aafa3dca4 Typos and clarificati

Re: [lang] StringUtils left and truncate

2017-11-15 Thread sebb
On 15 November 2017 at 16:55, Gary Gregory wrote: > Hi All, > > We have both StringUtils.left(String,int) and > StringUtils.truncate(String,int) > > Can we deprecate truncate in favor of left (and add > StringUtils.left(String,int, int)) ? No, because truncate() does not behave the same as left()

[io] New enum for file system info?

2017-11-15 Thread Gary Gregory
I find myself writing and using non-OO code around things like: private final int MAX_FILE_NAME_LENGTH_WINDOWS = 255; private final int MAX_FILE_NAME_LENGTH_LINUX = 255; private final int MAX_FILE_NAME_LENGTH_MAC = 255; private final int MAX_FILE_NAME_LENGTH_MAC_OS9 = 31; priv

Re: [io] New enum for file system info?

2017-11-15 Thread Gary Gregory
On Wed, Nov 15, 2017 at 10:30 AM, Gary Gregory wrote: > I find myself writing and using non-OO code around things like: > > private final int MAX_FILE_NAME_LENGTH_WINDOWS = 255; > private final int MAX_FILE_NAME_LENGTH_LINUX = 255; > private final int MAX_FILE_NAME_LENGTH_MAC = 255; >

AW: [io] New enum for file system info?

2017-11-15 Thread jhm
s/MAC_OSX_9/MAC_OS_9/ What about older versions of MacOS? UNKNOWN(31,1024) // smallest values for safety Are there differences between FAT,FAT32,NTFS,reiserfs,... ? Jan > -Ursprüngliche Nachricht- > Von: Gary Gregory [mailto:garydgreg...@gmail.com] > Gesendet: Mittwoch, 15. November 2017

Re: [apache/commons-io] [IO-553] Add (0603303)

2017-11-15 Thread Gary Gregory
Fixed, thank you! Gary On Wed, Nov 15, 2017 at 12:47 PM, Pascal Schumacher < notificati...@github.com> wrote: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:javadoc (default-cli) on > project commons-io: An error has occurred in JavaDocs report generati

Re: [io] New enum for file system info?

2017-11-15 Thread Gary Gregory
On Wed, Nov 15, 2017 at 12:53 PM, Jan Matèrne (jhm) wrote: > s/MAC_OSX_9/MAC_OS_9/ > What about older versions of MacOS? > UNKNOWN(31,1024) // smallest values for safety > Are there differences between FAT,FAT32,NTFS,reiserfs,... ? > Here you go: https://en.wikipedia.org/wiki/Comparison_of_file_

Re: [io] New enum for file system info?

2017-11-15 Thread Matt Sicker
Oh definitely not OS-specific. Windows has FAT32, FATX/XFAT (forget the name; they use it on Xbox), NTFS, possibly more. macOS has HFS, HFS+, and APFS. Linux has at least a dozen or more. BSD has its own (possibly different between FreeBSD and OpenBSD), then Solaris, AIX, etc. On 15 November 2017

Re: [io] New enum for file system info?

2017-11-15 Thread Gary Gregory
Please see the current code evolving in comments in https://issues.apache.org/jira/browse/IO-555 even though it might be time to commit and let others have at it. Gary On Wed, Nov 15, 2017 at 1:16 PM, Matt Sicker wrote: > Oh definitely not OS-specific. Windows has FAT32, FATX/XFAT (forget the >

[GitHub] commons-rdf issue #43: COMMONSRDF-49: Make AbstractRDFParser serializable

2017-11-15 Thread ansell
Github user ansell commented on the issue: https://github.com/apache/commons-rdf/pull/43 Having ``Optional`` fields isn't impossible to serialise (as I said erroneously in the referenced comment), as you could always write custom serialise/deserialise code to support it, but it isn't

[GitHub] commons-rdf pull request #43: COMMONSRDF-49: Make AbstractRDFParser serializ...

2017-11-15 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/43#discussion_r151267617 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -200,19 +200,19 @@ *