Re: [VOTE] Release Apache Commons-FIleUpload 1.3 based on RC2

2013-03-26 Thread Benedikt Ritter
Good morning Simo, 2013/3/25 Simone Tripodi > Hallo! > > > > > build works fine with my environment, which is: > > > > Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100) > > Maven home: D:\Entwicklung\maven\3.0.3 > > Java version: 1.7.0_13, vendor: Oracle Corporation > > Java home: D:\Entw

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
I'm not sure what API should be removed/renamed/etc as almost everything is public static ;-) Anyway, I'm trying to remove two deprecated classes right now. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2013/3/8 Christian Grobmeier : > On Wed, Mar 6, 2013 at 10:11 AM, sebb wrot

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
Ok, done. Should I just commit the changes? Or do I have to register an issue first in JIRA? Maybe it will be better... Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2013/3/26 Lukasz Lenart : > I'm not sure what API should be removed/renamed/etc as almost > everything is public s

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
https://issues.apache.org/jira/browse/OGNL-232 2013/3/26 Lukasz Lenart : > Ok, done. Should I just commit the changes? Or do I have to register > an issue first in JIRA? Maybe it will be better... > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > > 2013/3/26 Lukasz Lenart

Re: [OGNL] A new release

2013-03-26 Thread Christian Grobmeier
+1, go for it. Now its time to see if our testcases are good. I also think we should test it in conjunction with struts. On Tue, Mar 26, 2013 at 9:31 AM, Lukasz Lenart wrote: > Ok, done. Should I just commit the changes? Or do I have to register > an issue first in JIRA? Maybe it will be better.

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
2013/3/26 Christian Grobmeier : > +1, go for it. > Now its time to see if our testcases are good. They are, I made a slight mistake and tests showed that :-) > I also think we should test it in conjunction with struts. Not so easy, OGNL 4 is a different beast, but I'll try ;-) Regards -- Łuka

Re: [OGNL] A new release

2013-03-26 Thread Christian Grobmeier
On Tue, Mar 26, 2013 at 9:53 AM, Lukasz Lenart wrote: > 2013/3/26 Christian Grobmeier : >> +1, go for it. >> Now its time to see if our testcases are good. > > They are, I made a slight mistake and tests showed that :-) > >> I also think we should test it in conjunction with struts. > > Not so eas

Re: [OGNL] A new release

2013-03-26 Thread Maurizio Cucchiara
I thought that it won't be a piece of cake, but we might make it easier, for example what about to start a new branch on struts to integrate the new version of OGNL? (perhaps this is not the right place, or at least the only place, where this discussion should happen) Twitter :http://www.twitt

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
2013/3/26 Maurizio Cucchiara : > I thought that it won't be a piece of cake, but we might make it > easier, for example what about to start a new branch on struts to > integrate the new version of OGNL? (perhaps this is not the right > place, or at least the only place, where this discussion should

Re: [OGNL] A new release

2013-03-26 Thread Christian Grobmeier
On Tue, Mar 26, 2013 at 10:05 AM, Maurizio Cucchiara wrote: > I thought that it won't be a piece of cake, but we might make it > easier, for example what about to start a new branch on struts to > integrate the new version of OGNL? (perhaps this is not the right > place, or at least the only place

Re: [OGNL] A new release

2013-03-26 Thread Maurizio Cucchiara
Do you mean this [1] isEvalChain method? [1] https://svn.apache.org/repos/asf/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java On 26 March 2013 10:12, Lukasz Lenart wrote: > isEvalChain() method isn't available in OGNL 4 Twitter :http://www.twitter.com/m_cuc

Re: [OGNL] A new release

2013-03-26 Thread Lukasz Lenart
2013/3/26 Maurizio Cucchiara : > Do you mean this [1] isEvalChain method? > > [1] > https://svn.apache.org/repos/asf/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java IDEA cheats me ;-) It used wrong version ;-) Regards -- Łukasz + 48 606 323 122 http://www.lenart

Re: [OGNL] A new release

2013-03-26 Thread Maurizio Cucchiara
FYI I've just started a new thread (http://goo.gl/cx1E5) on Struts dev list Twitter :http://www.twitter.com/m_cucchiara G+ :https://plus.google.com/107903711540963855921 Linkedin:http://www.linkedin.com/in/mauriziocucchiara VisualizeMe: http://vizualize.me/maurizio.cucchiara?r=mau

[Math] MATH-917 (Was: [math] releasing 3.2?)

2013-03-26 Thread Gilles
[...] There is at least one contribution requiring some feedback (MATH-917). I have added a first patch and would love to get some feedback. It seems we are really close to releasing now. I guess MATH-817 will be resolved soon. What seems to be achievable in a short time frame would be:

[CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
Hi All: This is a discussion to see if we should remove the requirement to use the builder pattern. Right now, the CSVParser Javadoc has this simple example: Reader in = new StringReader("a\tb\nc\td"); CSVFormat format = new CSVFormat('\t', '"', '#'); List records = new CSVParser(in, format).get

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 14:58, ggreg...@apache.org a écrit : > -public static final CSVFormat DEFAULT = // TODO rename to something more > meaningful > +public static final CSVFormat RFC4180_EMPTY_LINES = My opinion, from the "Ease of Use Department", when I read the Javadoc and see DEFAULT I unde

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 10:06 AM, Emmanuel Bourg wrote: > Le 26/03/2013 14:58, ggreg...@apache.org a écrit : > > > -public static final CSVFormat DEFAULT = // TODO rename to something > more meaningful > > +public static final CSVFormat RFC4180_EMPTY_LINES = > > My opinion, from the "Ease

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 15:14, Gary Gregory a écrit : > Then we need to make the Javadoc better. "DEFAULT" means nothing because it > is arbitrary as exemplified by the Javadoc: it's the RFC with empty lines, > but it could be anything we decide, which is unhelpful and could change. If > you read RFC4180_EM

Re: CSVFormat newBuilder() value

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 15:24, Gary Gregory a écrit : > Why is a CSVFormat newBuilder() NOT the RFC? Since the RFC is the only > 'public standard', why not use that? If not, or why not use a well known > format like Excel. I am just wondering why we are picking what looks like > an arbitrary set of values w

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread sebb
On 26 March 2013 14:05, Gary Gregory wrote: > Hi All: > > This is a discussion to see if we should remove the requirement to use the > builder pattern. > > Right now, the CSVParser Javadoc has this simple example: > > Reader in = new StringReader("a\tb\nc\td"); > CSVFormat format = new CSVFormat('

Re: svn commit: r1461159 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/FastMath.java

2013-03-26 Thread sebb
On 26 March 2013 14:56, wrote: > Author: luc > Date: Tue Mar 26 14:56:01 2013 > New Revision: 1461159 > > URL: http://svn.apache.org/r1461159 > Log: > FastMath.abs() without branching for float and double primitive types. > > JIRA: MATH-954 > > Modified: > > commons/proper/math/trunk/src/mai

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 15:05, Gary Gregory a écrit : > So I have two questions: > > Should the CSVFormat be made public? Would that make Emmanuel happy? I am > guessing not due to the 9 params. > > If the ctor is made public, should we add a bunch of ctors for simpler or > all cases? Well guessed. The w

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 11:18 AM, Emmanuel Bourg wrote: > Le 26/03/2013 15:05, Gary Gregory a écrit : > > > So I have two questions: > > > > Should the CSVFormat be made public? Would that make Emmanuel happy? I am > > guessing not due to the 9 params. > > > > If the ctor is made public, should w

Re: svn commit: r1461185 - /commons/proper/fileupload/trunk/src/main/assembly/bin.xml

2013-03-26 Thread sebb
On 26 March 2013 15:25, wrote: > Author: simonetripodi > Date: Tue Mar 26 15:25:20 2013 > New Revision: 1461185 > > URL: http://svn.apache.org/r1461185 > Log: > releng: as pointed by Manu and Bene, just include the main artifact in the > -bin archive Surely it's often useful to have at least th

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Adrian Crum
I like the idea of improving the JavaDoc. The DEFAULT field was very intuitive. -Adrian On 3/26/2013 2:14 PM, Gary Gregory wrote: On Tue, Mar 26, 2013 at 10:06 AM, Emmanuel Bourg wrote: Le 26/03/2013 14:58, ggreg...@apache.org a écrit : -public static final CSVFormat DEFAULT = // TODO

Re: svn commit: r1461185 - /commons/proper/fileupload/trunk/src/main/assembly/bin.xml

2013-03-26 Thread Simone Tripodi
> > Surely it's often useful to have at least the main Javadocs in the bin > archive? > yup we already include uncompressed javadoc, that is why we can be strict to the main artifact only http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetrip

Re: svn commit: r1461134 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 11:39 AM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: > I like the idea of improving the JavaDoc. The DEFAULT field was very > intuitive. > I've changed it back to DEFAULT in SVN. Gary > > -Adrian > > > On 3/26/2013 2:14 PM, Gary Gregory wrote: > >> On Tue,

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 16:31, Gary Gregory a écrit : > Right, so here we are now with the fluent builder API. You've expressed > discontent. So now what can we do? How do you think the API can be made > better? Would you prefer to see many ctors on CVSFormat in addition to the > fluent API so you can choos

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 10:05 AM, Gary Gregory wrote: > Hi All: > > This is a discussion to see if we should remove the requirement to use the > builder pattern. > > Right now, the CSVParser Javadoc has this simple example: > > Reader in = new StringReader("a\tb\nc\td"); > CSVFormat format = new C

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Simone Tripodi
> > Well I understand not everybody is comfortable with a fluent API, that's > probably not what we are used to see in the Java sphere, but we see more > and more successful projects following this pattern. > > > There are already several CSV APIs built around the traditional > constructors/accesso

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 16:58, Gary Gregory a écrit : > Is it worth providing this shortcut: > > Iterable parse = CSVFormat.newBuilder(). > withCommentStart('#').withDelimiter('\t').withQuoteChar('"').parse(in); > > the builder would implement parse() I still think the builder is useless. My initial impl

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 12:01 PM, Simone Tripodi wrote: > > > > Well I understand not everybody is comfortable with a fluent API, that's > > probably not what we are used to see in the Java sphere, but we see more > > and more successful projects following this pattern. > > > > > > There are alrea

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 10:05 AM, Gary Gregory wrote: > Hi All: > > This is a discussion to see if we should remove the requirement to use the > builder pattern. > > Right now, the CSVParser Javadoc has this simple example: > > Reader in = new StringReader("a\tb\nc\td"); > CSVFormat format = new C

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Benedikt Ritter
2013/3/26 Gary Gregory > On Tue, Mar 26, 2013 at 12:03 PM, Emmanuel Bourg > wrote: > > > Le 26/03/2013 16:58, Gary Gregory a écrit : > > > > > Is it worth providing this shortcut: > > > > > > Iterable parse = CSVFormat.newBuilder(). > > > withCommentStart('#').withDelimiter('\t').withQuoteChar('

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Emmanuel Bourg
Le 26/03/2013 17:18, Benedikt Ritter a écrit : > This was my attention when I initially created the patch for the builder. > the newBuilder() method was called newFormat() back then. We changed it to > not confuse users with what objects they are dealing with. With > newBuilder() changed back to n

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread sebb
On 26 March 2013 16:18, Benedikt Ritter wrote: > 2013/3/26 Gary Gregory > >> On Tue, Mar 26, 2013 at 12:03 PM, Emmanuel Bourg >> wrote: >> >> > Le 26/03/2013 16:58, Gary Gregory a écrit : >> > >> > > Is it worth providing this shortcut: >> > > >> > > Iterable parse = CSVFormat.newBuilder(). >> >

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 12:35 PM, sebb wrote: > On 26 March 2013 16:18, Benedikt Ritter wrote: > > 2013/3/26 Gary Gregory > > > >> On Tue, Mar 26, 2013 at 12:03 PM, Emmanuel Bourg > >> wrote: > >> > >> > Le 26/03/2013 16:58, Gary Gregory a écrit : > >> > > >> > > Is it worth providing this sho

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread Benedikt Ritter
2013/3/26 Gary Gregory > On Tue, Mar 26, 2013 at 12:35 PM, sebb wrote: > > > On 26 March 2013 16:18, Benedikt Ritter wrote: > > > 2013/3/26 Gary Gregory > > > > > >> On Tue, Mar 26, 2013 at 12:03 PM, Emmanuel Bourg > > >> wrote: > > >> > > >> > Le 26/03/2013 16:58, Gary Gregory a écrit : > >

Re: [CSV] Should the Builder API be optional?

2013-03-26 Thread sebb
On 26 March 2013 16:53, Benedikt Ritter wrote: > 2013/3/26 Gary Gregory > >> On Tue, Mar 26, 2013 at 12:35 PM, sebb wrote: >> >> > On 26 March 2013 16:18, Benedikt Ritter wrote: >> > > 2013/3/26 Gary Gregory >> > > >> > >> On Tue, Mar 26, 2013 at 12:03 PM, Emmanuel Bourg >> > >> wrote: >> > >

Re: [Math] MATH-917 (Was: [math] releasing 3.2?)

2013-03-26 Thread Thomas Neidhart
On 03/26/2013 01:38 PM, Gilles wrote: >>> [...] > There is at least one contribution requiring some feedback (MATH-917). I have added a first patch and would love to get some feedback. >>> >>> It seems we are really close to releasing now. I guess MATH-817 will be >>> resolved so

Re: svn commit: r1461159 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/FastMath.java

2013-03-26 Thread Luc Maisonobe
Le 26/03/2013 16:08, sebb a écrit : > On 26 March 2013 14:56, wrote: >> Author: luc >> Date: Tue Mar 26 14:56:01 2013 >> New Revision: 1461159 >> >> URL: http://svn.apache.org/r1461159 >> Log: >> FastMath.abs() without branching for float and double primitive types. >> >> JIRA: MATH-954 >> >> Mod

Re: svn commit: r1461159 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/FastMath.java

2013-03-26 Thread sebb
On 26 March 2013 19:49, Luc Maisonobe wrote: > Le 26/03/2013 16:08, sebb a écrit : >> On 26 March 2013 14:56, wrote: >>> Author: luc >>> Date: Tue Mar 26 14:56:01 2013 >>> New Revision: 1461159 >>> >>> URL: http://svn.apache.org/r1461159 >>> Log: >>> FastMath.abs() without branching for float an

Re: svn commit: r1461237 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java

2013-03-26 Thread Benedikt Ritter
Hi Gary, 2013/3/26 > Author: ggregory > Date: Tue Mar 26 17:42:55 2013 > New Revision: 1461237 > > URL: http://svn.apache.org/r1461237 > Log: > Make internal API package private. > > Modified: > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java > > Modified: > common

Re: svn commit: r1461237 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java

2013-03-26 Thread Gary Gregory
On Tue, Mar 26, 2013 at 4:23 PM, Benedikt Ritter wrote: > Hi Gary, > > > 2013/3/26 > > > Author: ggregory > > Date: Tue Mar 26 17:42:55 2013 > > New Revision: 1461237 > > > > URL: http://svn.apache.org/r1461237 > > Log: > > Make internal API package private. > > > > Modified: > > > > > commons/p

Re: [Math] MATH-917 (Was: [math] releasing 3.2?)

2013-03-26 Thread Thomas Neidhart
On 03/26/2013 08:07 PM, Thomas Neidhart wrote: > On 03/26/2013 01:38 PM, Gilles wrote: [...] > >> There is at least one contribution requiring some feedback (MATH-917). > > I have added a first patch and would love to get some feedback. It seems we are really close to

Re: [math] releasing 3.2?

2013-03-26 Thread Phil Steitz
On 3/25/13 8:52 AM, Luc Maisonobe wrote: > Hi all, > > Le 23/03/2013 16:30, Thomas Neidhart a écrit : >> On 03/04/2013 01:57 PM, Gilles wrote: >>> Hello. >>> I would like to release version 3.2 of [math] soon. Any thoughts about it? >>> How soon? >>> There are many unresolved issues targe