Le 21/04/2011 08:12, Simone Tripodi a écrit :
Bonjour Emmanuel!
don't worry, since I need to better understand CLI internal code, I
just would like to fix minor-minor warnings such Generics, missing
@Override/@Deprecated annotations, final fields where possible, etc
I don't intend modify the CLI
Hi Folks,
Any thoughts on this issue?
Thanks,
Hiranya
On Tue, Apr 19, 2011 at 4:46 PM, Hiranya Jayathilaka
wrote:
> Hi Sebb,
>
> On Mon, Apr 18, 2011 at 7:10 PM, sebb wrote:
>
>> On 18 April 2011 13:48, Hiranya Jayathilaka wrote:
>> > On Sat, Jan 29, 2011 at 9:10 PM, Ralph Goers <
>> ralph.go
Bonjour Emmanuel,
recently we had the same discussion about this kind of warnings on
[pool] and [discovery] and at the end of them I tend to agree that
that should be fixed because:
- @deprecated in the javadoc is for human readability, @Deprecated is
for the compiler;
- @Override: I suggest you
Le 21/04/2011 10:21, Simone Tripodi a écrit :
- @deprecated in the javadoc is for human readability, @Deprecated is
for the compiler;
The compiler is fine with the javadoc tag, and the annotation doesn't
provide a useful comment to the user explaining why it's deprecated and
what to use in
Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
@@ -117,15 +117,15 @@ public class DefaultParser implements Co
handleToken(argument);
}
}
-
+
// check the arguments of the last option
checkRequiredArgs();
-
+
// add
also on empty lines?
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Thu, Apr 21, 2011 at 1:22 PM, Emmanuel Bourg wrote:
> Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
>
>> @@ -117,15 +117,15 @@ public class DefaultParser implements Co
>> handleTo
ok, looks like I cannot be very useful here :)
have a nice day, good job!
Simo
http://people.apache.org/~simonetripodi/
http://www.99soft.org/
On Thu, Apr 21, 2011 at 12:59 PM, Emmanuel Bourg wrote:
> Le 21/04/2011 10:21, Simone Tripodi a écrit :
>
>> - @deprecated in the javadoc is for human
Le 21/04/2011 13:25, Simone Tripodi a écrit :
also on empty lines?
In method bodies, yes.
Emmanuel Bourg
smime.p7s
Description: S/MIME Cryptographic Signature
Emmanuel Bourg wrote:
> Le 21/04/2011 13:25, Simone Tripodi a écrit :
>> also on empty lines?
>
> In method bodies, yes.
This means I'll never touch CLI sources!
Sorry, but most editors will simply strip them.
- Jörg
-
To un
Le 21/04/2011 13:24, Simone Tripodi a écrit :
ok, looks like I cannot be very useful here :)
have a nice day, good job!
Actually you can ! I certainly didn't want to frustrate your
enthousiasm, but you have to understand that these kinds of changes
(along with javadoc tags, indentation, brace
This space formatting requirement seems impossible to configure in a code
formatter (like Eclipse's.)
I am -1 if I cannot set up an Eclipse formatter for the project and not
think about it. Formatting by hand is a waste of my time.
Gary
On Thu, Apr 21, 2011 at 7:47 AM, Jörg Schaible
wrote:
> Em
On 21 April 2011 11:59, Emmanuel Bourg wrote:
> Le 21/04/2011 10:21, Simone Tripodi a écrit :
>
>> - @deprecated in the javadoc is for human readability, @Deprecated is
>> for the compiler;
>
> The compiler is fine with the javadoc tag, and the annotation doesn't
> provide a useful comment to the
On 21 April 2011 12:22, Emmanuel Bourg wrote:
> Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
>
>> @@ -117,15 +117,15 @@ public class DefaultParser implements Co
>> handleToken(argument);
>> }
>> }
>> -
>> +
>> // check the arguments of the
Le 21/04/2011 14:03, sebb a écrit :
Depends on the compiler target. If you target 1.5 or later, then
@Deprecated and @Override should be used.
That's your choice, there is no Java police that make these annotations
mandatory. The lack of comment associated with the @Deprecated
annotation mak
On Thu, Apr 21, 2011 at 8:03 AM, sebb wrote:
> On 21 April 2011 11:59, Emmanuel Bourg wrote:
> > Le 21/04/2011 10:21, Simone Tripodi a écrit :
> >
> >> - @deprecated in the javadoc is for human readability, @Deprecated is
> >> for the compiler;
> >
> > The compiler is fine with the javadoc tag,
On Thu, Apr 21, 2011 at 8:08 AM, sebb wrote:
> On 21 April 2011 12:22, Emmanuel Bourg wrote:
> > Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
> >
> >> @@ -117,15 +117,15 @@ public class DefaultParser implements Co
> >> handleToken(argument);
> >> }
> >>
On Thu, Apr 21, 2011 at 7:56 AM, Gary Gregory wrote:
> On Thu, Apr 21, 2011 at 8:08 AM, sebb wrote:
>
>> On 21 April 2011 12:22, Emmanuel Bourg wrote:
>> > Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
>> >
>> >> @@ -117,15 +117,15 @@ public class DefaultParser implements Co
>> >>
On 21 April 2011 15:21, Matt Benson wrote:
> On Thu, Apr 21, 2011 at 7:56 AM, Gary Gregory wrote:
>> On Thu, Apr 21, 2011 at 8:08 AM, sebb wrote:
>>
>>> On 21 April 2011 12:22, Emmanuel Bourg wrote:
>>> > Le 21/04/2011 13:13, simonetrip...@apache.org a écrit :
>>> >
>>> >> @@ -117,15 +117,15 @@
Perhaps a lot of these formatting messages would go away if we stored
Eclipse (or IDEs) settings in projects.
The ugly is that every IDE has different way of specifying this.
I wonder if we should have a project dir called "ide" with sub-dirs for
"eclipse", "netbeans", and so on, as desired. Deve
On Mon, Apr 11, 2011 at 7:19 PM, Henri Yandell wrote:
> On Mon, Apr 11, 2011 at 3:43 PM, Gary Gregory
> wrote:
> > On Mon, Apr 11, 2011 at 4:26 PM, Henri Yandell
> wrote:
> >>
> >> +1 to rename getShortClassName to getSimpleName; sitting on top of the
> >> JDK getSimpleName and providing null s
On Wed, Apr 20, 2011 at 9:42 AM, Jörg Schaible wrote:
> Henri Yandell wrote:
>
>> I think we're ready for another release candidate.
>>
>> Does anyone know of any remaining items? JIRA is clean, and I don't
>> see anything in the email threads that implies more work needs to be
>> done.
>
> It's a
On Thu, Apr 21, 2011 at 8:31 AM, Gary Gregory wrote:
> On Mon, Apr 11, 2011 at 7:19 PM, Henri Yandell wrote:
>>
>> On Mon, Apr 11, 2011 at 3:43 PM, Gary Gregory
>> wrote:
>> > On Mon, Apr 11, 2011 at 4:26 PM, Henri Yandell
>> > wrote:
>> >>
>> >> +1 to rename getShortClassName to getSimpleName;
On Thu, Apr 21, 2011 at 2:38 PM, Henri Yandell wrote:
> On Thu, Apr 21, 2011 at 8:31 AM, Gary Gregory
> wrote:
> > On Mon, Apr 11, 2011 at 7:19 PM, Henri Yandell
> wrote:
> >>
> >> On Mon, Apr 11, 2011 at 3:43 PM, Gary Gregory
> >> wrote:
> >> > On Mon, Apr 11, 2011 at 4:26 PM, Henri Yandell
Am 21.04.2011 08:24, schrieb Jörg Schaible:
Hi Hen,
Henri Yandell wrote:
On Wed, Apr 20, 2011 at 3:25 PM, Gary Gregory
wrote:
[snip]
PairFormat class needed rather than relying on toString functionality :)
Could we implement Formattable?
+1
Something new learned today :)
- Jörg
Yes
The VOTE to release commons-parent 21 based on version 21-RC3 has passed
with 5 +1 binding votes from the following PMC Members:
Gary Gregory
Henri Yandell
Jörg Schaible
Sebastian Bazley
Luc Maisonobe
Thank you,
Gary
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-scxml-test has an issue affecting its community integration.
This
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-proxy-test has an issue affecting its community integration.
This
On Thu, Apr 21, 2011 at 12:01 PM, Gary Gregory wrote:
> On Thu, Apr 21, 2011 at 2:38 PM, Henri Yandell wrote:
>>
>> On Thu, Apr 21, 2011 at 8:31 AM, Gary Gregory
>> wrote:
>> > On Mon, Apr 11, 2011 at 7:19 PM, Henri Yandell
>> > wrote:
>> >>
>> >> On Mon, Apr 11, 2011 at 3:43 PM, Gary Gregory
28 matches
Mail list logo
