On Thu, Apr 21, 2011 at 7:56 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Thu, Apr 21, 2011 at 8:08 AM, sebb <seb...@gmail.com> wrote: > >> On 21 April 2011 12:22, Emmanuel Bourg <ebo...@apache.org> wrote: >> > Le 21/04/2011 13:13, simonetrip...@apache.org a écrit : >> > >> >> @@ -117,15 +117,15 @@ public class DefaultParser implements Co >> >> handleToken(argument); >> >> } >> >> } >> >> - >> >> + >> >> // check the arguments of the last option >> >> checkRequiredArgs(); >> >> - >> >> + >> >> // add the default options >> >> handleProperties(properties); >> >> - >> >> + >> >> checkRequiredOptions(); >> >> - >> >> + >> >> return cmd; >> >> } >> > >> > >> > For the record, I'd like to preserve this kind of trailing spaces in >> order >> > to keep the cursor on the indentation level when editing the code. >> >> Most editors will automatically indent correctly; Eclipse certainly >> does (though it tends to leave trailing spaces on blank lines). >> > > You can configure Eclipse's "Clean Up" operation to remove trailing spaces.
There are other plugins that will do this as well; however this leads to many unrelated changes degrading the signal-to-noise ratio of a given commit. I know because of the flak I have taken from other committers over this. Simo's approach of a commit specifically targeting formatting, etc., issues seems better tolerated, as an onlooker can read the commit message and see that the change is not one of substance. Conversely, he need not hunt through a maze of changes looking for the meaningful one. Matt > > Gary > >> >> But so long as the code does not have any TABs, I'm not personally >> worried about a few trailing spaces. >> >> > >> > Emmanuel Bourg >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > Thank you, > Gary > > http://garygregory.wordpress.com/ > http://garygregory.com/ > http://people.apache.org/~ggregory/ > http://twitter.com/GaryGregory > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
