Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Gary Gregory
Thank you for cutting the RC Benedikt. While the Clirr breakage for FastDateFormat is documented as intentional and 'safe' in the release notes, the first place I looked for information is the Javadoc, IMO the same information from the release notes could be duplicated in the Javadoc. The Javadoc

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Benedikt Ritter
2013/12/23 Oliver Heger > Am 23.12.2013 10:26, schrieb Benedikt Ritter: > > Hello Oilver, > > > > thanks for your review and the suggestions. > > > > > > 2013/12/22 Oliver Heger > > > >> Hi Benedikt, > >> > >> the release notes mention that Lang 3.0 and onwards requires Java 5, > >> while the 3.

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Oliver Heger
Am 23.12.2013 10:26, schrieb Benedikt Ritter: > Hello Oilver, > > thanks for your review and the suggestions. > > > 2013/12/22 Oliver Heger > >> Hi Benedikt, >> >> the release notes mention that Lang 3.0 and onwards requires Java 5, >> while the 3.2 release actually needs Java 6. I think this

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Matt Benson
For my $0.02 I'd say that if the Javadocs are usable it doesn't really matter. :| Matt On Mon, Dec 23, 2013 at 12:41 PM, Duncan Jones wrote: > On 23 Dec 2013 18:32, "Matt Benson" wrote: > > > > Bene pointed out to me that he did build w/ Java 7; of course the target > > setting in the POM is

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Duncan Jones
On 23 Dec 2013 18:32, "Matt Benson" wrote: > > Bene pointed out to me that he did build w/ Java 7; of course the target > setting in the POM is the reason the classfiles are Java 6 compatible, > which is the important thing in any case. Presumably that means the Javadocs have a Java 7 style? Is t

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Matt Benson
Bene pointed out to me that he did build w/ Java 7; of course the target setting in the POM is the reason the classfiles are Java 6 compatible, which is the important thing in any case. Matt On Mon, Dec 23, 2013 at 11:00 AM, Matt Benson wrote: > - RAT report looks okay. > - I successfully buil

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Matt Benson
- RAT report looks okay. - I successfully build the contents of the source artifacts with both Java 6 and Java 7 - I successfully build the contents of the tag - britter code signing key is in https://dist.apache.org/repos/dist/release/commons/KEYS - All sigs and hashes check out - Binary jars appe

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Benedikt Ritter
Hi Jörg, 2013/12/23 Jörg Schaible > > Hi, > > I don't know what it is, but for me the download of > > https://dist.apache.org/repos/dist/dev/commons/lang/source/commons-lang3-3.2-src.tar.gzalways > stops at 71% ... anyone else ?!? > Don't know, works on my machine. I'm using Safari on Mac OS

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Jörg Schaible
Hi, I don't know what it is, but for me the download of https://dist.apache.org/repos/dist/dev/commons/lang/source/commons-lang3-3.2-src.tar.gz always stops at 71% ... anyone else ?!? - Jörg Benedikt Ritter wrote: > Hello All, > > We have fixed quite a few bugs and added some significant en

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-23 Thread Benedikt Ritter
Hello Oilver, thanks for your review and the suggestions. 2013/12/22 Oliver Heger > Hi Benedikt, > > the release notes mention that Lang 3.0 and onwards requires Java 5, > while the 3.2 release actually needs Java 6. I think this has to be > explicitly stated. > Oh, yes! Would probably be bet

Re: [VOTE] Release Commons Lang 3.2 based on RC1

2013-12-22 Thread Oliver Heger
Hi Benedikt, the release notes mention that Lang 3.0 and onwards requires Java 5, while the 3.2 release actually needs Java 6. I think this has to be explicitly stated. Otherwise, everything looks good. Build runs successful with Java 1.7 on Windows 8.1. Artifacts and site look good; the release