You can veto a code modification.
On Dec 23, 2011 11:02 AM, "Phil Steitz" wrote:
> On 12/23/11 7:36 AM, Christian Grobmeier wrote:
> > On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
> >> On 23/12/2011 11:33, Christian Grobmeier wrote:
> >>
> >>> So far i have see the reason: Tomcat 5.5 runs
-Original Message-
From: Konstantin Kolinko
Sent: Sunday, December 25, 2011 1:15 AM
To: Commons Developers List
Subject: Re: [pool] [POOL-208] Support Java 1.5 Generics in version 1.x.
2011/12/23 Christian Grobmeier :
On Wed, Dec 21, 2011 at 7:31 PM, Phil Steitz
wrote:
On 12/21/11
2011/12/23 Christian Grobmeier :
> On Wed, Dec 21, 2011 at 7:31 PM, Phil Steitz wrote:
>> On 12/21/11 11:09 AM, Gary Gregory wrote:
>>> On Wed, Dec 21, 2011 at 1:03 PM, Mark Thomas wrote:
>>>
On 21/12/2011 16:57, Phil Steitz wrote:
> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
>>
On Fri, Dec 23, 2011 at 8:44 AM, Gary Gregory wrote:
> On Fri, Dec 23, 2011 at 8:07 AM, Simone Tripodi
> wrote:
>
>> Hi again!!!
>>
>> >
>> > My plan is simply to finish cleaning up the warnings that generics
>> > introduced, like the one you just fixed in javadocs.
>> >
>> > Still no runtime beh
On 12/23/11 9:38 AM, Christian Grobmeier wrote:
> On Fri, Dec 23, 2011 at 5:01 PM, Phil Steitz wrote:
>> On 12/23/11 7:36 AM, Christian Grobmeier wrote:
>>> On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
On 23/12/2011 11:33, Christian Grobmeier wrote:
Releases would be more work bu
On Fri, Dec 23, 2011 at 11:01 AM, Phil Steitz wrote:
> On 12/23/11 7:36 AM, Christian Grobmeier wrote:
> > On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
> >> On 23/12/2011 11:33, Christian Grobmeier wrote:
> >>
> >>> So far i have see the reason: Tomcat 5.5 runs with jdk1.4.2. Is this
> >>
On Fri, Dec 23, 2011 at 5:01 PM, Phil Steitz wrote:
> On 12/23/11 7:36 AM, Christian Grobmeier wrote:
>> On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
>>> On 23/12/2011 11:33, Christian Grobmeier wrote:
>>> Releases would be more work but there are folks that look to be willing
>>> to rele
On 12/23/11 7:36 AM, Christian Grobmeier wrote:
> On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
>> On 23/12/2011 11:33, Christian Grobmeier wrote:
>>
>>> So far i have see the reason: Tomcat 5.5 runs with jdk1.4.2. Is this
>>> actually the reason we don't go forward? Because another project
On Fri, Dec 23, 2011 at 2:29 PM, Mark Thomas wrote:
> On 23/12/2011 11:33, Christian Grobmeier wrote:
>
>> So far i have see the reason: Tomcat 5.5 runs with jdk1.4.2. Is this
>> actually the reason we don't go forward? Because another project needs
>> the 1.5 series?
>> If this is the case, then
On Fri, Dec 23, 2011 at 8:07 AM, Simone Tripodi wrote:
> Hi again!!!
>
> >
> > My plan is simply to finish cleaning up the warnings that generics
> > introduced, like the one you just fixed in javadocs.
> >
> > Still no runtime behavior changes. I did not even change to enhanced for
> loops.
> >
>
On 23/12/2011 11:33, Christian Grobmeier wrote:
> So far i have see the reason: Tomcat 5.5 runs with jdk1.4.2. Is this
> actually the reason we don't go forward? Because another project needs
> the 1.5 series?
> If this is the case, then the EOL of Tomcat 5.5 is the earliest EOL of Pool
> 1.5.
>
Hi again!!!
>
> My plan is simply to finish cleaning up the warnings that generics
> introduced, like the one you just fixed in javadocs.
>
> Still no runtime behavior changes. I did not even change to enhanced for
> loops.
>
I agree, let's not break (potentially) the pool behavior, what we
want
On Fri, Dec 23, 2011 at 1:41 PM, Gary Gregory wrote:
>>
>> OK, sorry if I ask the same question in the same dumb way all the
>> time... but we have figured out 1.5 will be binary compatible with
>> 1.6.
>> We can't we then simply drop 1.5 and go forward with 1.6?
>>
>> So far i have see the reason
On Dec 23, 2011, at 6:34, Christian Grobmeier wrote:
> On Wed, Dec 21, 2011 at 7:31 PM, Phil Steitz wrote:
>> On 12/21/11 11:09 AM, Gary Gregory wrote:
>>> On Wed, Dec 21, 2011 at 1:03 PM, Mark Thomas wrote:
>>>
On 21/12/2011 16:57, Phil Steitz wrote:
> On 12/21/11 9:41 AM, Christian G
Hi all!
> If 1.6 is coming and this project does not support it, how can we> handle it?
> After all we are not working for the Tomcat project, we are
> working for ourselves,
indeed. From the commons HP: "The Commons is an Apache project focused
on all aspects of reusable Java components."
I am
On Dec 23, 2011, at 6:00, Simone Tripodi wrote:
> Hi again Gary!
>
> I had another review after your latest commits, I just fixed 1 missing
> @param comment, and IMHO in therms of having generics-only, this
> release should be ready...
>
> Do you have any plan? Thanks for driving this!
> -Simo
M
On Wed, Dec 21, 2011 at 7:31 PM, Phil Steitz wrote:
> On 12/21/11 11:09 AM, Gary Gregory wrote:
>> On Wed, Dec 21, 2011 at 1:03 PM, Mark Thomas wrote:
>>
>>> On 21/12/2011 16:57, Phil Steitz wrote:
On 12/21/11 9:41 AM, Christian Grobmeier wrote:
> On Wed, Dec 21, 2011 at 5:19 PM, Phil St
On Wed, Dec 21, 2011 at 7:32 PM, Rainer Jung wrote:
> On 21.12.2011 17:41, Christian Grobmeier wrote:
>>
>> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
>> wrote:
>>>
>>> 1.5.x ships with tomcat and is used by lots of other production
>>> applications. We need to maintain the ability to patch it
Hi again Gary!
I had another review after your latest commits, I just fixed 1 missing
@param comment, and IMHO in therms of having generics-only, this
release should be ready...
Do you have any plan? Thanks for driving this!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.liv
On 21.12.2011 17:41, Christian Grobmeier wrote:
On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
1.5.x ships with tomcat and is used by lots of other production
applications. We need to maintain the ability to patch it.
Tomcat 5.5 (the oldest stable version i can find) uses Java 5:
http:/
On 12/21/11 11:09 AM, Gary Gregory wrote:
> On Wed, Dec 21, 2011 at 1:03 PM, Mark Thomas wrote:
>
>> On 21/12/2011 16:57, Phil Steitz wrote:
>>> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
>> wrote:
> 1.5.x ships with tomcat and is used by
On Wed, Dec 21, 2011 at 1:03 PM, Mark Thomas wrote:
> On 21/12/2011 16:57, Phil Steitz wrote:
> > On 12/21/11 9:41 AM, Christian Grobmeier wrote:
> >> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
> wrote:
> >>> 1.5.x ships with tomcat and is used by lots of other production
> >>> applications.
On 21/12/2011 16:57, Phil Steitz wrote:
> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
>> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
>>> 1.5.x ships with tomcat and is used by lots of other production
>>> applications. We need to maintain the ability to patch it.
>> Tomcat 5.5 (the ol
On 21/12/2011 16:41, Christian Grobmeier wrote:
> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
>> 1.5.x ships with tomcat and is used by lots of other production
>> applications. We need to maintain the ability to patch it.
>
> Tomcat 5.5 (the oldest stable version i can find) uses Java 5
On 12/21/11 10:37 AM, Phil Steitz wrote:
> On 12/21/11 10:24 AM, Jörg Schaible wrote:
>> Hi Phil,
>>
>> Phil Steitz wrote:
>>
>>> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
wrote:
> 1.5.x ships with tomcat and is used by lots of other
On 12/21/11 10:24 AM, Jörg Schaible wrote:
> Hi Phil,
>
> Phil Steitz wrote:
>
>> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
>>> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
>>> wrote:
1.5.x ships with tomcat and is used by lots of other production
applications. We need to maintain
Hi Phil,
Phil Steitz wrote:
> On 12/21/11 9:41 AM, Christian Grobmeier wrote:
>> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz
>> wrote:
>>> 1.5.x ships with tomcat and is used by lots of other production
>>> applications. We need to maintain the ability to patch it.
>> Tomcat 5.5 (the oldest st
On 12/21/11 9:41 AM, Christian Grobmeier wrote:
> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
>> 1.5.x ships with tomcat and is used by lots of other production
>> applications. We need to maintain the ability to patch it.
> Tomcat 5.5 (the oldest stable version i can find) uses Java 5:
>
On 12/21/11 9:41 AM, Christian Grobmeier wrote:
> On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
>> 1.5.x ships with tomcat and is used by lots of other production
>> applications. We need to maintain the ability to patch it.
> Tomcat 5.5 (the oldest stable version i can find) uses Java 5:
>
On Wed, Dec 21, 2011 at 5:19 PM, Phil Steitz wrote:
> 1.5.x ships with tomcat and is used by lots of other production
> applications. We need to maintain the ability to patch it.
Tomcat 5.5 (the oldest stable version i can find) uses Java 5:
http://tomcat.apache.org/tomcat-5.5-doc/setup.html
Th
On Wed, Dec 21, 2011 at 11:22 AM, Phil Steitz wrote:
> On 12/21/11 9:14 AM, Gary Gregory wrote:
> > I created branches/1_5_RELEASE from trunk before the POOL-208 commits.
> > I expect 1.5.x fixes to be ported there from POOL_1_X.
>
> Please have a look at the actual code bases here. Trunk is
> g
On Wed, Dec 21, 2011 at 11:19 AM, Phil Steitz wrote:
> On 12/21/11 9:10 AM, Gary Gregory wrote:
> > My plan is to port any fixes from 1.5.x releases to 1.6.0 if any or
> > encourage others to do so. I do not plan on touching 1.5.x once 1.6 is
> > out. Because of the binary compatibility of 1.6, I
On Wed, Dec 21, 2011 at 11:15 AM, Simone Tripodi
wrote:
> Hi Gary,
> I had a look and looks good to me, I'll give another review once get home.
> Thanks for driving this!
> -Simo
>
Thank you for pitching in Simo :)
Gary
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejou
On 12/21/11 9:14 AM, Gary Gregory wrote:
> I created branches/1_5_RELEASE from trunk before the POOL-208 commits.
> I expect 1.5.x fixes to be ported there from POOL_1_X.
Please have a look at the actual code bases here. Trunk is
generified, 2.0 code. What I need restored is the old 1_5_X branch
On 12/21/11 9:10 AM, Gary Gregory wrote:
> My plan is to port any fixes from 1.5.x releases to 1.6.0 if any or
> encourage others to do so. I do not plan on touching 1.5.x once 1.6 is
> out. Because of the binary compatibility of 1.6, I would hope that
> folks would patch 1.6 first and then port to
Hi Gary,
I had a look and looks good to me, I'll give another review once get home.
Thanks for driving this!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Wed, Dec 21, 2011 at 2:13 PM, Gary Gregory
I created branches/1_5_RELEASE from trunk before the POOL-208 commits.
I expect 1.5.x fixes to be ported there from POOL_1_X. If not I'll
watch for 1.5.x releases and port to 1.6.
Gary
On Dec 21, 2011, at 11:03, Phil Steitz wrote:
> On 12/21/11 6:13 AM, Gary Gregory wrote:
>> Hello Generics fan
My plan is to port any fixes from 1.5.x releases to 1.6.0 if any or
encourage others to do so. I do not plan on touching 1.5.x once 1.6 is
out. Because of the binary compatibility of 1.6, I would hope that
folks would patch 1.6 first and then port to 1.5.x if asked by users,
but that's just me. I s
On 12/21/11 6:13 AM, Gary Gregory wrote:
> Hello Generics fan,
>
> Please review and continue on [POOL-208] Support Java 1.5 Generics in
> version 1.x.
>
> The code is in the POOL_1_X branch, cooking up for a 1.6 release very soon.
We need to sort out the branch structure here. I had prepared the
nope, I don't have all that energies :)
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Wed, Dec 21, 2011 at 4:51 PM, Phil Steitz wrote:
> As stated above, I am -1 for releasing this. I don't think
As stated above, I am -1 for releasing this. I don't think we have
resources to support three release trains in [pool]. Are you
prepared to take on bug fixing / porting, user and dev list support
for this code? Is anyone else?
Phil
On 12/21/11 6:13 AM, Gary Gregory wrote:
> Hello Generics fan,
Hi Gary,
I'm checking it out right now, I agree with your path: just add
generics and don't break what is already working ;)
I'll let you know ASAP!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On We
Hello Generics fan,
Please review and continue on [POOL-208] Support Java 1.5 Generics in
version 1.x.
The code is in the POOL_1_X branch, cooking up for a 1.6 release very soon.
There are NO code changes in the main code that should affect behavior.
I've only touched code for adding generics.
43 matches
Mail list logo
