Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Hank Grabowski
OK. If you want to put the "trivial modifications" that are required so the code is "on par with what we had usually committed as new contributions" in the JIRA incident, I can try to address them this week as well. On Mon, Oct 20, 2014 at 5:51 PM, Gilles wrote: > On Mon, 20 Oct 2014 19:33:25 +

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Gilles
On Mon, 20 Oct 2014 19:33:25 +0200, Luc Maisonobe wrote: Le 20/10/2014 16:00, Hank Grabowski a écrit : I have some time this week to try to get these changes made to the interpolators. I don't want to do anything without consensus however. So to try to incorporate the discussion above plus a

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Luc Maisonobe
Le 20/10/2014 16:00, Hank Grabowski a écrit : > I have some time this week to try to get these changes made to the > interpolators. I don't want to do anything without consensus however. So > to try to incorporate the discussion above plus a concerned raised over the > weekend on the JIRA thread

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Hank Grabowski
I have some time this week to try to get these changes made to the interpolators. I don't want to do anything without consensus however. So to try to incorporate the discussion above plus a concerned raised over the weekend on the JIRA thread I propose: 1. Adding the original functionality back

Re: [Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread Ole Ersoy
On 10/17/2014 03:12 PM, sebb wrote: On 17 October 2014 19:49, Ole Ersoy wrote: Hi, I'm following the discussion of how MATH-1138 was handled (Which I enjoy reading because I'm very impressed with how eloquently everyone communicates their points of view). Just a warning that I might be ignor

Re: [Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread Hank Grabowski
Ah, that is a more complicated question. Those discussions definitely aren't part of the repository. As someone now recently bitten by the confusion in where discussions should be taking place, I agree there should be a good documentation of those swim lanes. I'm new to contributing to open sour

Re: [Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread sebb
On 17 October 2014 21:16, Hank Grabowski wrote: > The nice thing about Github, from my perspective as a person with only > read-only access to the ASF repositories, is that it provides me with the > ability to work in my own fork and then initiate pull requests that can be > incorporated into the

Re: [Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread Hank Grabowski
The nice thing about Github, from my perspective as a person with only read-only access to the ASF repositories, is that it provides me with the ability to work in my own fork and then initiate pull requests that can be incorporated into the root repository. I think it is still ideal that the GitH

Re: [Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread sebb
On 17 October 2014 19:49, Ole Ersoy wrote: > Hi, > > I'm following the discussion of how MATH-1138 was handled (Which I enjoy > reading because I'm very impressed with how eloquently everyone communicates > their points of view). > > Just a warning that I might be ignoring [2] (Stolen from Gilles)

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Hank Grabowski
I didn't want to address the situation in my original response since I was on a smart phone, a bit torqued up by the original e-mail and I didn't want to further agitate the situation by addressing the original implementation. Since it seems that's all happened anyway, if you still want my newbie

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Luc Maisonobe
Hi all, Le 17/10/2014 16:23, Gilles a écrit : > Hi. > > On Fri, 17 Oct 2014 10:46:53 +0200, Luc Maisonobe wrote: >> Hi Hank, >> >> Le 16/10/2014 20:20, Hank Grabowski a écrit : >>> OK. I submitted the pull request yesterday. I'm going to now remove >>> the >>> diff from JIRA. >>> >>> https://gi

[Math] Github vs. ASF Repo vs. Rest of World (Non Apache Github Users)

2014-10-17 Thread Ole Ersoy
Hi, I'm following the discussion of how MATH-1138 was handled (Which I enjoy reading because I'm very impressed with how eloquently everyone communicates their points of view). Just a warning that I might be ignoring [2] (Stolen from Gilles), because I have suggested this before:

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Phil Steitz
Lets calm down, guys. As Luc said, we are experimenting here, getting the git workflow established. No one is trying to exclude or discourage anyone. Hank or Luc, can you respond to Gilles' questions about the commit? If not, it should be reverted, but hopefully you can all three agree on a way

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Hank Grabowski
Gilles, This is the original changes to get the bicubic spline working. These were originally committed as a diff that was attached to the JIRA incident. The suggestions in your email were in response to my questions about work carrying forward from that point. I have been very explicit and verb

[Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Gilles
Hi. On Fri, 17 Oct 2014 10:46:53 +0200, Luc Maisonobe wrote: Hi Hank, Le 16/10/2014 20:20, Hank Grabowski a écrit : OK. I submitted the pull request yesterday. I'm going to now remove the diff from JIRA. https://github.com/apache/commons-math/pull/2 Thank you. I have merged this request

Re: [math] GitHub vs ASF Repo

2014-10-17 Thread Hank Grabowski
Thanks for the heads up. I had core.autocrlf set to true in my git global settings but maybe GitHub's software wasn't honoring it without the explicit gitattributes file, that I've now configured. We will see when I do a pull request for some of those other features in the near future. On Fri, O

Re: [math] GitHub vs ASF Repo

2014-10-17 Thread Luc Maisonobe
Hi Hank, Le 16/10/2014 20:20, Hank Grabowski a écrit : > OK. I submitted the pull request yesterday. I'm going to now remove the > diff from JIRA. > > https://github.com/apache/commons-math/pull/2 Thank you. I have merged this request and pushed the result to our main repository. The only chan

Re: [math] GitHub vs ASF Repo

2014-10-16 Thread Hank Grabowski
OK. I submitted the pull request yesterday. I'm going to now remove the diff from JIRA. https://github.com/apache/commons-math/pull/2 On Tue, Oct 14, 2014 at 9:36 AM, luc wrote: > Le 2014-10-14 15:16, Hank Grabowski a écrit : > >> Should I try an experiment with that with those interpolator

Re: [math] GitHub vs ASF Repo

2014-10-14 Thread luc
Le 2014-10-14 15:16, Hank Grabowski a écrit : Should I try an experiment with that with those interpolator changes I put the diff into JIRA for and remove that flle from the JIRA issue or is the process of using that diff already underway so it would create more brain daamge than it was worth?

Re: [math] GitHub vs ASF Repo

2014-10-14 Thread Hank Grabowski
Should I try an experiment with that with those interpolator changes I put the diff into JIRA for and remove that flle from the JIRA issue or is the process of using that diff already underway so it would create more brain daamge than it was worth? On Tue, Oct 14, 2014 at 9:12 AM, luc wrote: > H

Re: [math] GitHub vs ASF Repo

2014-10-14 Thread luc
Hi Hank, Le 2014-10-14 15:01, Gilles a écrit : On Tue, 14 Oct 2014 08:36:07 -0400, Hank Grabowski wrote: It seems that the GitHub repository is now staying in sync with the ASF repository. Is the preferred workflow going to be (or already is) forking inside of GitHub and then doing pull reque

Re: [math] GitHub vs ASF Repo

2014-10-14 Thread Gilles
On Tue, 14 Oct 2014 08:36:07 -0400, Hank Grabowski wrote: It seems that the GitHub repository is now staying in sync with the ASF repository. Is the preferred workflow going to be (or already is) forking inside of GitHub and then doing pull requests or will the workflow be to work directly wit

[math] GitHub vs ASF Repo

2014-10-14 Thread Hank Grabowski
It seems that the GitHub repository is now staying in sync with the ASF repository. Is the preferred workflow going to be (or already is) forking inside of GitHub and then doing pull requests or will the workflow be to work directly with ASF? For someone like me with only read only access to the