Hi Hank, Le 16/10/2014 20:20, Hank Grabowski a écrit : > OK. I submitted the pull request yesterday. I'm going to now remove the > diff from JIRA. > > https://github.com/apache/commons-math/pull/2
Thank you. I have merged this request and pushed the result to our main repository. The only changes I introduced were fixing end of lines in the new Akima spline files (main and test). Perhaps you should check the git setting core.autocrlf on your side. It seems to me this pull request did not make it to our dev list. Did I simply miss it or is there a problem in the GitHub setting since we updated our repo? Did someone else see the request? If nobody saw it, I think we should ask infra to fix the settings. best regards, Luc > > > On Tue, Oct 14, 2014 at 9:36 AM, luc <l...@spaceroots.org> wrote: > >> Le 2014-10-14 15:16, Hank Grabowski a écrit : >> >>> Should I try an experiment with that with those interpolator changes I put >>> the diff into JIRA for and remove that flle from the JIRA issue or is the >>> process of using that diff already underway so it would create more brain >>> daamge than it was worth? >>> >> >> I think you can try your experiment. Just add a notice to JIRA that you >> are working >> on further improvements and they will soon becomre outdated rather than >> removing them. >> >> Luc >> >> >> >>> On Tue, Oct 14, 2014 at 9:12 AM, luc <l...@spaceroots.org> wrote: >>> >>> Hi Hank, >>>> >>>> Le 2014-10-14 15:01, Gilles a écrit : >>>> >>>> On Tue, 14 Oct 2014 08:36:07 -0400, Hank Grabowski wrote: >>>>> >>>>> It seems that the GitHub repository is now staying in sync with the ASF >>>>>> repository. Is the preferred workflow going to be (or already is) >>>>>> forking >>>>>> inside of GitHub and then doing pull requests or will the workflow be >>>>>> to >>>>>> work directly with ASF? For someone like me with only read only access >>>>>> to >>>>>> the ASF it seems that the fork method is better than submitting diff >>>>>> files >>>>>> attached to JIRA incidents. >>>>>> >>>>>> >>>>> [Non authoritative answer; I'm still far from up to speed with git...] >>>>> >>>>> I think that all three ways are fine; it's your choice. >>>>> >>>>> >>>> Yes, you can do as you want. >>>> As [math] is expereimenting here, the processe is not fully defined. >>>> >>>> What *is* fully defined however is that the mailing list is the place of >>>> choice for discussing changes. >>>> Once discussion has settled, I think we can grab patches from almost >>>> anyware. >>>> >>>> best regards, >>>> Luc >>>> >>>> >>>> >>>> Gilles >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>> >>>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
