Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-20 Thread Mark Thomas
On 20/06/2019 13:34, Gary Gregory wrote: > I do not understand the lack of reply to my requests to follow our release > process: > > - Hashes to files on dist/dev Not necessary. The revision number for the dist repo is sufficient for traceability. > - Link to site Not part of the release. > -

[CANCEL][VOTE] Release Apache Commons Daemon 1.1.1

2019-06-20 Thread Mark Thomas
Given the discussions around 1.1.1 vs 1.2.0 I'm cancelling this release vote. I'll start preparing for a 1.2.0 RC now (I think things are pretty much there but a final check won't hurt) with a view to tagging sometime between late tomorrow and early next week. If anyone has any objections to this

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-20 Thread Gary Gregory
I do not understand the lack of reply to my requests to follow our release process: - Hashes to files on dist/dev - Link to site - Link to KEYS file - Link to apache.org instead of github.com for the tag Gary On Wed, Jun 19, 2019 at 6:30 AM Mark Thomas wrote: > On 19/06/2019 10:44, Jonathan Ga

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Mark Thomas
On 19/06/2019 10:44, Jonathan Gallimore wrote: > This works well in my tests, many thanks for the release. Thanks for the confirmation. Mark > > (non-binding) +1. > > Jon > > On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas wrote: > >> It has been ~18 months since the last Commons Daemon release

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Jonathan Gallimore
This works well in my tests, many thanks for the release. (non-binding) +1. Jon On Mon, Jun 17, 2019 at 1:13 PM Mark Thomas wrote: > It has been ~18 months since the last Commons Daemon release. After the > recent flurry of activity, I think we are ready for a release. > > Notable changes incl

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-19 Thread Mark Thomas
On 19/06/2019 02:04, Rob Tompkins wrote: > Build works on java8 with “mvn clean test install site.” On java7 and java11 > “mvn clean test” works. Great. Thanks for looking. > One curiousity, “mvn apache-rat:check” fails with 4 license violations, > namely: > > src/native/unix/native/.ind

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Rob Tompkins
Build works on java8 with “mvn clean test install site.” On java7 and java11 “mvn clean test” works. One curiousity, “mvn apache-rat:check” fails with 4 license violations, namely: src/native/unix/native/.indent.pro src/native/unix/configure src/native/unix/support/config

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Rob Tompkins
Will give this a look tonight (US Eastern, 9p). -Rob > On Jun 17, 2019, at 8:13 AM, Mark Thomas wrote: > > It has been ~18 months since the last Commons Daemon release. After the > recent flurry of activity, I think we are ready for a release. > > Notable changes include: > - Improved JRE/JDK d

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Mark Thomas
On 18/06/2019 17:15, Gary Gregory wrote: > On Tue, Jun 18, 2019 at 11:43 AM Mark Thomas wrote: > >> On 18/06/2019 14:20, Gary Gregory wrote: >>> Also, while we even discussed PR >>> https://github.com/apache/commons-daemon/pull/11, it was not merged fir >>> this RC. I'd like to see an RC2 with it

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Gary Gregory
On Tue, Jun 18, 2019 at 11:43 AM Mark Thomas wrote: > On 18/06/2019 14:20, Gary Gregory wrote: > > Also, while we even discussed PR > > https://github.com/apache/commons-daemon/pull/11, it was not merged fir > > this RC. I'd like to see an RC2 with it included. > > Looking at this now. > > Thinki

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Mark Thomas
On 18/06/2019 14:20, Gary Gregory wrote: > Also, while we even discussed PR > https://github.com/apache/commons-daemon/pull/11, it was not merged fir > this RC. I'd like to see an RC2 with it included. Looking at this now. Thinking about version numbers as a result of one of your other posts ther

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-18 Thread Gary Gregory
Also, while we even discussed PR https://github.com/apache/commons-daemon/pull/11, it was not merged fir this RC. I'd like to see an RC2 with it included. Gary On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas wrote: > It has been ~18 months since the last Commons Daemon release. After the > recent f

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-17 Thread Mark Thomas
On 17/06/2019 15:58, Gary Gregory wrote: > The version in the release notes at the top still says "1.1" instead of > "1.1.1". My understanding was they referred to 1.1.x (i.e. all of the 1.1 releases) so the version number was appropriate. > It seems to me that 1.2 would be more appropriate since

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-17 Thread Gary Gregory
The version in the release notes at the top still says "1.1" instead of "1.1.1". It seems to me that 1.2 would be more appropriate since we upgraded both the Java and OS requirements. Gary On Mon, Jun 17, 2019, 08:13 Mark Thomas wrote: > It has been ~18 months since the last Commons Daemon rel

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-17 Thread Gary Gregory
I am also getting a 404 for the link https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810 which might be a cut and paste issue or the way Gmail renders this URL. Gary On Mon, Jun 17, 2019 at 8:45 AM Gary Gregory wrote: > This email is mis

Re: [VOTE] Release Apache Commons Daemon 1.1.1

2019-06-17 Thread Gary Gregory
This email is missing a few elements based on our release procedures at https://commons.apache.org/releases/prepare.html - Hashes to files on dist/dev - Link to site - Link to KEYS file - Link to apache.org instead of github.com for the tag Gary On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas wrote

[VOTE] Release Apache Commons Daemon 1.1.1

2019-06-17 Thread Mark Thomas
It has been ~18 months since the last Commons Daemon release. After the recent flurry of activity, I think we are ready for a release. Notable changes include: - Improved JRE/JDK detection to support increased range of both JVM versions and vendors. - Procrun. Change the default service from Loc