On 19/06/2019 02:04, Rob Tompkins wrote:
> Build works on java8 with “mvn clean test install site.” On java7 and java11
> “mvn clean test” works.
Great. Thanks for looking.
> One curiousity, “mvn apache-rat:check” fails with 4 license violations,
> namely:
>
> src/native/unix/native/.indent.pro
> src/native/unix/configure
> src/native/unix/support/config.guess
> src/native/unix/support/config.sub
>
> I think aside from these I would likely be a +1.
Excellent. Things look to be in pretty good shape.
> The “.indent.pro” looks to be excludable,
It looks similar to checkstyle. It might be possible to add a header as
a comment. I'll take a look. I'll also see what happens if we run indent
against the current code.
> the others, being GPL licensed,
Not exactly.
configure is licensed as:
<quote>
# This configure script is free software; the Free Software Foundation
# gives unlimited permission to copy, distribute and modify it.
</quote>
config.guess and config.sub are GPL v3 or later with an exception namely:
<quote>
# As a special exception to the GNU General Public License, if you
# distribute this file as part of a program that contains a
# configuration script generated by Autoconf, you may include it under
# the same distribution terms that you use for the rest of that
# program. This Exception is an additional permission under section 7
# of the GNU General Public License, version 3 ("GPLv3").
</quote>
That exception applies in this case so those files are distributed under
the terms of the ALv2.
> we may need to add to the NOTICE.txt
No. Only required notices go in NOTICE and there is no such requirement
for any of these three files.
> and then add the Apache 2.0 license header to them? IIRC, we should be able
> to do something like that
No. You can't re-license code if you don't own the copyright.
If code is licensed under something other than ALv2 that license needs
to be added to LICENSE. In this case the files are ALv2 licensed so I
don't think adding anything to LICENSE is necessary either.
Legally, I think 1.1.1 is fine.
ASF policy wise, we should try and put a header in .indent.pro but if
the file format doesn't support comments then it would be acceptable to
leave them out.
As an additional check, I looked at how httpd handles the same 3 files
and it includes them in the source as is and does not mention them in
either LICENSE or NOTICE so that reinforces my belief that Commons
Daemon is handling these 3 files correctly.
What we should do is ensure that those 3 files are excluded from RAT.
I'll add that to my TODO list but I won't complain if someone beats me
to it.
Mark
>
> Cheers,
> -Rob
>
>
>> On Jun 17, 2019, at 8:13 AM, Mark Thomas <ma...@apache.org> wrote:
>>
>> It has been ~18 months since the last Commons Daemon release. After the
>> recent flurry of activity, I think we are ready for a release.
>>
>> Notable changes include:
>> - Improved JRE/JDK detection to support increased range of both JVM
>> versions and vendors.
>> - Procrun. Change the default service from LocalSystem to
>> 'NT Authority\LocalService'
>>
>> The full set of changes is in the changelog
>>
>> 1.1.1 can be obtained from (r34537):
>> https://dist.apache.org/repos/dist/dev/commons/daemon/
>>
>> The git tag is:
>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1
>> 4319f482e1ff6ea7655e1377120750fd6ecc3810
>>
>> The Maven Staging repo is:
>> https://repository.apache.org/content/repositories/orgapachecommons-1441/
>>
>> The Windows binaries have been signed by the Symantec code signing service.
>>
>>
>>
>> [ ] Approved - go ahead and release Commons Daemon 1.1.1
>> [ ] Broken - do not release because...
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
