On 18/06/2019 17:15, Gary Gregory wrote: > On Tue, Jun 18, 2019 at 11:43 AM Mark Thomas <ma...@apache.org> wrote: > >> On 18/06/2019 14:20, Gary Gregory wrote: >>> Also, while we even discussed PR >>> https://github.com/apache/commons-daemon/pull/11, it was not merged fir >>> this RC. I'd like to see an RC2 with it included. >> >> Looking at this now. >> >> Thinking about version numbers as a result of one of your other posts >> there probably is a case for 1.2.0. >> >> Since the 1.1.0 release Windows XP, Vista and Server 2003 have all >> fallen out of support. Some of the Procrun changes assume Windows 7 / >> Server 2008 SP2 (i.e. only currently supported versions of Windows) as a >> minimum. >> >> I think you could make a case for 1.1.1 on the grounds the older OSes >> are unsupported but using 1.2.0 makes it cleaner. >> >> The changes from the 1.1.1 tag to 1.2.0 are essentially cosmetic so far >> so I'd urge folks to continue to test 1.1.1 and provide feedback. >> > > See my previous emails then.
Apart from switching 1.2.0 (addressed above) and your PR to modify log messages (mentioned above and already committed) I don't see any other feedback for 1.1.1 from you. What am I missing? Mark > > Gary > > >> >> Mark >> >> >>> >>> Gary >>> >>> On Mon, Jun 17, 2019 at 8:13 AM Mark Thomas <ma...@apache.org> wrote: >>> >>>> It has been ~18 months since the last Commons Daemon release. After the >>>> recent flurry of activity, I think we are ready for a release. >>>> >>>> Notable changes include: >>>> - Improved JRE/JDK detection to support increased range of both JVM >>>> versions and vendors. >>>> - Procrun. Change the default service from LocalSystem to >>>> 'NT Authority\LocalService' >>>> >>>> The full set of changes is in the changelog >>>> >>>> 1.1.1 can be obtained from (r34537): >>>> https://dist.apache.org/repos/dist/dev/commons/daemon/ >>>> >>>> The git tag is: >>>> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_1 >>>> 4319f482e1ff6ea7655e1377120750fd6ecc3810 >>>> < >> https://github.com/apache/commons-daemon/commits/COMMONS_DAEMON_1_1_14319f482e1ff6ea7655e1377120750fd6ecc3810 >>> >>>> >>>> The Maven Staging repo is: >>>> >> https://repository.apache.org/content/repositories/orgapachecommons-1441/ >>>> >>>> The Windows binaries have been signed by the Symantec code signing >> service. >>>> >>>> >>>> >>>> [ ] Approved - go ahead and release Commons Daemon 1.1.1 >>>> [ ] Broken - do not release because... >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
