RESULT: [VOTE] Release [pool] 2.1 based on RC2

2013-12-30 Thread Phil Steitz
This vote has passed, with +1 votes from Oliver Heger Phil Steitz Luc Maisonobe Mark Thomas Jörg Schaible and no other votes. Thanks to all who reviewed the RC. Phil On 12/26/13, 5:18 PM, Phil Steitz wrote: > I have updated the release notes and MBean interface class javadoc to address > feed

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Jörg Schaible
+1, build from source succeeds for all my JDKs (incl. Java 8) Phil Steitz wrote: > I have updated the release notes and MBean interface class javadoc to > address feedback from RC1. > > Pool 2.1 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ > > Mave

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Gary Gregory
Lost in my discussion on BC is my gratitude for Phil's return to Commons and my thanks for preparing an RC for a crucial component. Thank you Phil! Gary On Thu, Dec 26, 2013 at 8:18 PM, Phil Steitz wrote: > I have updated the release notes and MBean interface class javadoc to > address feedba

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Gary Gregory
On Sat, Dec 28, 2013 at 1:30 PM, Phil Steitz wrote: > On 12/28/13, 8:07 AM, Gary Gregory wrote: > > On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz > wrote: > > > >> On 12/27/13, 2:09 PM, Gary Gregory wrote: > >>> I have to say that the 'fix' for the Clirr issue is underwhelming, it > >> does > >>

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Phil Steitz
On 12/28/13, 10:39 AM, Luc Maisonobe wrote: > Le 28/12/2013 18:51, Phil Steitz a écrit : >> On 12/28/13, 2:23 AM, Luc Maisonobe wrote: >>> Le 27/12/2013 02:18, Phil Steitz a écrit : I have updated the release notes and MBean interface class javadoc to address feedback from RC1.

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Luc Maisonobe
Le 28/12/2013 18:51, Phil Steitz a écrit : > On 12/28/13, 2:23 AM, Luc Maisonobe wrote: >> Le 27/12/2013 02:18, Phil Steitz a écrit : >>> I have updated the release notes and MBean interface class javadoc to >>> address feedback from RC1. >>> >>> Pool 2.1 RC2 is available for review here: >>> ht

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Phil Steitz
On 12/28/13, 8:07 AM, Gary Gregory wrote: > On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz wrote: > >> On 12/27/13, 2:09 PM, Gary Gregory wrote: >>> I have to say that the 'fix' for the Clirr issue is underwhelming, it >> does >>> not exist IMO. >>> >>> - The new API does not have a @since 2.1 in t

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Phil Steitz
On 12/28/13, 2:23 AM, Luc Maisonobe wrote: > Le 27/12/2013 02:18, Phil Steitz a écrit : >> I have updated the release notes and MBean interface class javadoc to >> address feedback from RC1. >> >> Pool 2.1 RC2 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/pool/

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Phil Steitz
On 12/28/13, 2:38 AM, Benedikt Ritter wrote: > > Send from my mobile device > >> Am 28.12.2013 um 04:03 schrieb Phil Steitz : >> >>> On 12/27/13, 10:21 AM, Oliver Heger wrote: >>> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and >>> site look good. >>> >>> So +1 >>> >>> Mino

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Gary Gregory
On Fri, Dec 27, 2013 at 10:15 PM, Phil Steitz wrote: > On 12/27/13, 2:09 PM, Gary Gregory wrote: > > I have to say that the 'fix' for the Clirr issue is underwhelming, it > does > > not exist IMO. > > > > - The new API does not have a @since 2.1 in the Javadoc. > > Should be fixed, but not a bloc

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Mark Thomas
On 27/12/2013 01:18, Phil Steitz wrote: > [X] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... Mark - To unsubscribe, e-mail: dev-unsubscr...

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Benedikt Ritter
Send from my mobile device > Am 28.12.2013 um 04:03 schrieb Phil Steitz : > >> On 12/27/13, 10:21 AM, Oliver Heger wrote: >> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and >> site look good. >> >> So +1 >> >> Minor nit: The ant build did not work for me, obviously du

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-28 Thread Luc Maisonobe
Le 27/12/2013 02:18, Phil Steitz a écrit : > I have updated the release notes and MBean interface class javadoc to address > feedback from RC1. > > Pool 2.1 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ > > Maven artifacts are here: > https://reposi

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-27 Thread Phil Steitz
On 12/27/13, 2:09 PM, Gary Gregory wrote: > I have to say that the 'fix' for the Clirr issue is underwhelming, it does > not exist IMO. > > - The new API does not have a @since 2.1 in the Javadoc. Should be fixed, but not a blocker, IMO. > - There is nothing on the site that addresses the Clirr er

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-27 Thread Phil Steitz
On 12/27/13, 10:21 AM, Oliver Heger wrote: > Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and > site look good. > > So +1 > > Minor nit: The ant build did not work for me, obviously due to missing > cglib dependencies. I guess I have to define some properties, but this > is

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-27 Thread Phil Steitz
Here is my +1 Phil On 12/26/13, 5:18 PM, Phil Steitz wrote: > I have updated the release notes and MBean interface class javadoc to address > feedback from RC1. > > Pool 2.1 RC2 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/pool/ > > Maven artifacts are here: >

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-27 Thread Gary Gregory
I have to say that the 'fix' for the Clirr issue is underwhelming, it does not exist IMO. - The new API does not have a @since 2.1 in the Javadoc. - There is nothing on the site that addresses the Clirr error and why it is OK to have. - The release notes do not talk about the Clirr error as well.

Re: [VOTE] Release [pool] 2.1 based on RC2

2013-12-27 Thread Oliver Heger
Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and site look good. So +1 Minor nit: The ant build did not work for me, obviously due to missing cglib dependencies. I guess I have to define some properties, but this is not described nor is there a sample properties file. Oli

[VOTE] Release [pool] 2.1 based on RC2

2013-12-26 Thread Phil Steitz
I have updated the release notes and MBean interface class javadoc to address feedback from RC1. Pool 2.1 RC2 is available for review here: https://dist.apache.org/repos/dist/dev/commons/pool/ Maven artifacts are here: https://repository.apache.org/content/repositories/orgapachecommons-022/