On 12/28/13, 10:39 AM, Luc Maisonobe wrote: > Le 28/12/2013 18:51, Phil Steitz a écrit : >> On 12/28/13, 2:23 AM, Luc Maisonobe wrote: >>> Le 27/12/2013 02:18, Phil Steitz a écrit : >>>> I have updated the release notes and MBean interface class javadoc to >>>> address feedback from RC1. >>>> >>>> Pool 2.1 RC2 is available for review here: >>>> https://dist.apache.org/repos/dist/dev/commons/pool/ >>>> >>>> Maven artifacts are here: >>>> https://repository.apache.org/content/repositories/orgapachecommons-022/ >>>> >>>> Details of changes since 2.0 are in the release notes: >>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt >>>> >>>> The tag is here: >>>> >>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/ >>> The tag does include a doc top level directory with three java files: >>> ReaderUtilClient.java ReaderUtil.java StringBufferFactory.java >>> >>> These three files are not in the source distribution files in >>> <https://dist.apache.org/repos/dist/dev/commons/pool/source/>. >>> >>> Is this expected? >> I think it is OK, the files are just there to provide access to / >> validation of source in the examples in the web site - i.e., there >> is no real value in adding them to the source distro. But if you or >> others think it is essential that the tag matches the source distro >> exactly, this plus the build.properties.sample issue identified by >> Olivier could justify another RC. I am ambivalent at this point. > I don't have a clear cut opinion on this. If these sources are not > really needed, then they can be left out for this version. It would be > worth adding them to the list of archived source in the pom for next > release.
I want to keep them in svn because they match the examples on the site. They should just probably be excluded when making the tag. Phil > > Anyway, here is my +1. > > Luc > >> Phil >>> Luc >>> >>>> Site: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/ >>>> (Broken links to Javadoc versions expected) >>>> >>>> Clirr Report: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html >>>> >>>> RAT: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html >>>> >>>> Please review the release candidate and vote. >>>> This vote will close no sooner that 72 hours from now >>>> >>>> [ ] +1 Release these artifacts >>>> [ ] +0 OK, but... >>>> [ ] -0 OK, but really should fix... >>>> [ ] -1 I oppose this release because... >>>> >>>> Thanks! >>>> >>>> Phil >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> >>>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> . >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
