On 12/28/13, 2:38 AM, Benedikt Ritter wrote: > > Send from my mobile device > >> Am 28.12.2013 um 04:03 schrieb Phil Steitz <phil.ste...@gmail.com>: >> >>> On 12/27/13, 10:21 AM, Oliver Heger wrote: >>> Maven build was successful with Java 6 and 7 on Windows 7. Artifacts and >>> site look good. >>> >>> So +1 >>> >>> Minor nit: The ant build did not work for me, obviously due to missing >>> cglib dependencies. I guess I have to define some properties, but this >>> is not described nor is there a sample properties file. >> Ugh. Thanks for pointing this out. There is a >> build.properties.sample in trunk, but the src assembly does not pick >> it up. Not a blocker, IMO, but fixed now in trunk. > This is intentional. The file serves as a sample. One has to fill in the > parameters for the environment and than rename/copy the file to > build.properties. That file should be picked up by the build.
I know. I created the file ;) But I forgot to update the maven assembly descriptor to pick it up when creating the source distro. Fixed now in trunk, but I don't think this is a blocker. Phil > > Benedikt > >> Phil >>> Oliver >>> >>> Am 27.12.2013 02:18, schrieb Phil Steitz: >>>> I have updated the release notes and MBean interface class javadoc to >>>> address feedback from RC1. >>>> >>>> Pool 2.1 RC2 is available for review here: >>>> https://dist.apache.org/repos/dist/dev/commons/pool/ >>>> >>>> Maven artifacts are here: >>>> https://repository.apache.org/content/repositories/orgapachecommons-022/ >>>> >>>> Details of changes since 2.0 are in the release notes: >>>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt >>>> >>>> The tag is here: >>>> >>>> <http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/>http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC2/ >>>> >>>> Site: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/ >>>> (Broken links to Javadoc versions expected) >>>> >>>> Clirr Report: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/clirr-report.html >>>> >>>> RAT: >>>> http://people.apache.org/~psteitz/pool/pool-2.1-rc2/rat-report.html >>>> >>>> Please review the release candidate and vote. >>>> This vote will close no sooner that 72 hours from now >>>> >>>> [ ] +1 Release these artifacts >>>> [ ] +0 OK, but... >>>> [ ] -0 OK, but really should fix... >>>> [ ] -1 I oppose this release because... >>>> >>>> Thanks! >>>> >>>> Phil >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> . >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > . > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org