Re: [DBCP] Reduce boiler plate code using lambdas

2019-08-30 Thread Phil Steitz
On 8/29/19 9:47 PM, Romain Manni-Bucau wrote: Hi Think both points are valid actually. Concretely, such a change has perf impacts, indeed compared to a db init it will be very fast but compared to a driver operation it can be something. Therefore a microbench comparison does not hurt and wil

Re: [DBCP] Reduce boiler plate code using lambdas

2019-08-29 Thread Romain Manni-Bucau
Hi Think both points are valid actually. Concretely, such a change has perf impacts, indeed compared to a db init it will be very fast but compared to a driver operation it can be something. Therefore a microbench comparison does not hurt and will at least guarantee it is ok and make people calm

Re: [DBCP] Reduce boiler plate code using lambdas

2019-08-29 Thread Gary Gregory
On Thu, Aug 29, 2019 at 6:17 PM Phil Steitz wrote: > > > On 8/29/19 6:37 AM, Gary Gregory wrote: > > Hi All: > > > > In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of > > boilerplate code using lambdas. This also happens to fix a bunch of > places > > where we did not call

Re: [DBCP] Reduce boiler plate code using lambdas

2019-08-29 Thread Phil Steitz
On 8/29/19 6:37 AM, Gary Gregory wrote: Hi All: In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of boilerplate code using lambdas. This also happens to fix a bunch of places where we did not call checkOpen() when we should have. Interesting.  I have a couple of comment

[DBCP] Reduce boiler plate code using lambdas

2019-08-29 Thread Gary Gregory
Hi All: In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of boilerplate code using lambdas. This also happens to fix a bunch of places where we did not call checkOpen() when we should have. Gary