On 8/29/19 6:37 AM, Gary Gregory wrote:
Hi All:
In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of
boilerplate code using lambdas. This also happens to fix a bunch of places
where we did not call checkOpen() when we should have.
Interesting. I have a couple of comments.
First is a nit - it would make review much easier if you separate the
formatting changes from the actual code changes in commits. Please try
to do that.
Second is more important. I am not a jvm expert so this may be a
non-issue, but I wonder whether these changes will have performance /
resource utilization impact. If someone can confirm that this all gets
optimized to the same or equivalent bytecode, there is nothing to worry
about. If not, I would strongly recommend running benchmarks to
validate that there is no performance impact.
Phil
Gary
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
