Github user markt-asf commented on the issue:
https://github.com/apache/commons-pool/pull/4
Thanks for the PR. I've fixed this in a slightly different way after
reviewing the prior changes. The tst case I used largely as-is. T
Github user markt-asf closed the pull request at:
https://github.com/apache/commons-pool/pull/4
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
sebb wrote:
>The POOL download page
>http://commons.apache.org/pool/download_pool.cgi only has a link for
>1.6 (Java 1.5+) , although the dist/ area contains 1.6 and 1.5.7.
>
>Seems to me either the page should link to 1.5.7 (Java 1.3+) or the
>dist/ area should be tidied up.
>
>-
sebb wrote:
>On 16 June 2012 23:09, Mark Thomas wrote:
>> On 16/06/2012 23:05, sebb wrote:
>>> On 16 June 2012 22:35, Mark Thomas wrote:
On 16/06/2012 22:33, sebb wrote:
> On 16 June 2012 22:23, Gary Gregory
>wrote:
>> Did you update the changes.xml? Did I miss that?
>
> N
Mark Struberg wrote:
>Hi folks!
>
>What is the current status of dbcp in commons and in tomcat?
>
>My $$dayjob project likes to switch from c3p0 to dbcp, but which one to
>take?
>
>
>The winner will get a free beer at ApacheConEU :)
>
>LieGrue,
>strub
>
>
>
sebb wrote:
>I've brought the pom up to date with CP24.
>
>The code is still using a non-standard directory layout; source and
>test should be under
>
>src/main/java
>src/test/java
>
>OK if I fix this?
>Can then remove the override in the POM.
No objections here. Will gump need an update with th
sebb wrote:
>On 12 April 2012 20:46, Mark Thomas wrote:
>> 1. Fix all the open bugs. DONE - until someone opens another Jira ;)
>> 2. Clean up the docs. TODO
>> 3. Release 2.0.0.M1
>> 4. Work on DBCP2, updating POOL2 as required (e.g. moving the
>abandoned
>> object code to POOL2)
>> 5. React to
Gary Gregory wrote:
>I do not recall releasing M milestone versions in the past. I know
>Eclipse uses milestones but the concept here feels more like an alpha
>or beta. You could call a -snapshot past a certain date or an RC a
>milestone I suppose.
I'm happy will alpha at this point if that is w
Emmanuel Bourg wrote:
>Le 06/03/2012 10:26, ma...@apache.org a écrit :
>
>> The right way for solr to do this would be to package rename csv the
>same way Tomcat does for encode.
>
>Yes that's what I suggested. How do you do this in Tomcat? Did you copy
>
>and rename the packages manually, or do
ma...@apache.org wrote:
>Emmanuel Bourg wrote:
>
>>Le 06/03/2012 08:52, Jörg Schaible a écrit :
>>
>>> All that we can do now is to put a big red warning at commons-cvs
>>homepage:
>>>
>>> == %< ==
>>> CAUTION: If you use Apache Solr you run implicitly an incompatible
>>version
>
Emmanuel Bourg wrote:
>Le 06/03/2012 08:52, Jörg Schaible a écrit :
>
>> All that we can do now is to put a big red warning at commons-cvs
>homepage:
>>
>> == %< ==
>> CAUTION: If you use Apache Solr you run implicitly an incompatible
>version
>> of commons-csv that may affect yo
Emmanuel Bourg wrote:
>Hi,
>
>This is actually a bad joke for all of us binary compatibility lovers.
>I
>just noticed that Solr forked Commons CSV and released it as a separate
>
>artifact, but kept the org.apache.commons.csv package unchanged :(
>
>http://www.jarvana.com/jarvana/inspect/org/apa
Gary Gregory wrote:
>On Feb 10, 2012, at 5:39, Mark Thomas wrote:
>
>> On 10/02/2012 00:20, Simone Tripodi wrote:
>>> I have a preference fo juli.
>> I can work with that.
>
>Is a dependency on JULI better than on common-logging?
>
>Or is there some confusion talking about JUL vs JULI?
I was as
sebb wrote:
>On 4 January 2012 15:07, Gary Gregory wrote:
>> Sebb:
>>
>> How do you like this tag:
>>
>>
>https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_6_RC3
>>
>> ?
>
>It's the svn commit message that is important, and that is:
>
>
>URL: http://svn.apache.org/viewvc?rev=1
Phil Steitz wrote:
>Here is my +1
>
>Could use a couple of more so the bug fixes can go out and we can
>proceed to a patch release for [dbcp] 1.3/1.4.
>
>Phil
>
>On 12/10/11 5:29 PM, Phil Steitz wrote:
>> This is a patch release, including a couple of bug fixes.
>>
>> The release artifacts are h
sebb wrote:
>This is a parallel thread to the one about PoolFactory implementations.
>
>I'm trying to establish the mutability needs of the
>[Keyed]ObjectPool implementations, i.e.
>
>Generic[Keyed]ObjectPool
>
>I've looked at DBCP 1.4, which uses POOL 1.x.
>
>SharedPoolDataSource.registerPool()
Henri Yandell wrote:
>I think you just PGP with your release key. Later on we can strengthen
>the signing by adding you to the web-of-trust.
+1. Don't forget to add your public key to the KEYS file. That is a must. Being
in the web of trust is a (very) nice to have.
Mark
>Hen
>
>On Mon, Nov 28
Mladen Turk wrote:
>On 11/19/2011 05:18 PM, Gary Gregory wrote:
>> - Use @version $Id: $
>> - Use the active voice, say "Starts the operation of this
>> Daemoninstance.", not "Start the operation of this
>> Daemon instance."
>>
>> Done in SVN. Since we have a -1, these changes should be picked up
Phil Steitz wrote:
>When GKOP or GOP pools lack capacity, addObject does nothing. In
>some cases (I am dealing with one now internally to GKOP), it would
>be good to know if an instance was actually added or not. How about
>changing the interface (both OP and KOP versions) to return a
>boolean
Phil Steitz wrote:
>On 9/11/11 12:44 PM, Gary Gregory wrote:
>> Perhaps we want to keep the ivars in one place since they all have
>very
>> carefully been decorated with final and volatile just in the right
>places?
>
>There is only one field being maintained and I think it would
>actually be cle
sebb wrote:
>On 11 September 2011 16:08, Ralph Goers
>wrote:
>>
>> On Sep 11, 2011, at 7:41 AM, Phil Steitz wrote:
>>
>
How exactly? I am asking this because I don't know how to do it.
Won't whoever wants to retrieve it have to know the (now
non-existent) tag name? Or will i
Phil Steitz wrote:
>On 9/2/11 9:48 AM, ma...@apache.org wrote:
>> Author: markt
>> Date: Fri Sep 2 16:48:59 2011
>> New Revision: 1164625
>>
>> URL: http://svn.apache.org/viewvc?rev=1164625&view=rev
>> Log:
>> Fix typo
>
>I guess you mean
Gary Gregory wrote:
>Hi All:
>
>Where are we WRT [pool] and generics in a release?
>
>Thank you,
>Gary
>--
>http://garygregory.wordpress.com/
>http://garygregory.com/
>http://people.apache.org/~ggregory/
>http://twitter.com/GaryGregory
>
>--
Phil Steitz wrote:
>I see this now in GOP javadoc for numActive.
>
> * The combined count of the currently active objects and those in the
> * process of being created. Under load, it may exceed {@link
>#_maxActive}
> * but there will never be more than {@link #_maxActive} created
>at any
Phil Steitz wrote:
>I saw this
>Failed tests:
>
>testMaxTotalInvariant(org.apache.commons.pool2.impl.TestGenericKeyedObjectPool):
>Thread failed: 2
>java.lang.IllegalStateException: Returned object not currently part
>of this pool
>at
>org.apache.commons.pool2.impl.GenericKeyedObjectPool.ret
25 matches
Mail list logo