Hi all,
Two things from me, a relatively new member of the community.
I think much more effort needs to be on pushing things through code-review and
to completion. There are many issues in LANG that have been awaiting review for
well over a year or two. This means the commiters are no longer aro
for example it avoids
> unneeded initialisation). On the parameters I feel it makes the signatures
> unreadable long, and given that stylistic warnings about Ssigning
> parameters happen in Eclipse anyway I dont need them. (But I dont mind if
> used).
>
> Greetings
> Bernd
> Am
I have no view on the use of final modifiers on variables within methods;
however on the parameters I think it is very important so that the code self
documents to the caller the behaviour that they should expect. Recently I was
bitten by a library that I was using in a multithreaded application
17 Oct 2014, at 23:25, sebb wrote:
>
>> On 17 October 2014 22:56, James Sawle wrote:
>> Whilst the changes are the same as the Java 7 implementations, these in fact
>> came from OpenJDK implement ions and match the expected behaviour as defined
>> by the Javadoc. Any
I apologise for the spelling mistakes in the previous message. Need to remember
not to send messages after drinks on a Friday :p
Sent from my iPhone
> On 17 Oct 2014, at 22:56, James Sawle wrote:
>
> Whilst the changes are the same as the Java 7 implementations, these in fact
&g
nd apply these changes as the patch at:
>>
>>https://github.com/apache/commons-lang/pull/32.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>>This closes #3
If the library is going to be called version 2 then personally it should be
commons-jcs2. Otherwise the original version from Jakarta should be dropped
altogether, and the doc changed so this is treated as version 1.
Whilst the later makes sense from the perspective that this is the first Apache
I have created a patch for the above issue, which adds a new method signature
to simplify the conversion from Strings to Booleans based upon a single true
boolean String. This is therefore unlike the other methods, which either take
no parameters (use a prebuilt list of true and false values), o
