I apologise for the spelling mistakes in the previous message. Need to remember not to send messages after drinks on a Friday :p
Sent from my iPhone > On 17 Oct 2014, at 22:56, James Sawle <jamessa...@hotmail.com> wrote: > > Whilst the changes are the same as the Java 7 implementations, these in fact > came from OpenJDK implement ions and match the expected behaviour as defined > by the Javadoc. Any effort to change these so that that have less resemblance > to the Oracle implementation will just cause detrimental side effects to > performance. > > We are not attempting to replace or capitalise Oracle functionality, but > merely polyfill it to precious Java versions. I think that the methods should > be removed as of Lang4 or if Java 7 becomes supported in Lang3 to support > this point. > > Sent from my iPhone > >> On 17 Oct 2014, at 12:45, Duncan Jones <djo...@apache.org> wrote: >> >> Hi, >> >> James has authored a fine patch for LANG-536 (see below), but it does >> include some code that exactly matches Java 7 source. Specifically, >> the various compare(primitive, primitive) methods that have been added >> to BooleanUtils, NumberUtils and CharUtils are identical to the >> methods provided in Java 7 and above. >> >> Should we make some kind of syntactic changes to these methods to >> avoid being accused of plagiarism? For instance, we could replace the >> short-form if statements with the longer form. Or could we argue this >> is just the canonical form of the method? >> >> Kind regards, >> >> Duncan >> >> >> >>> On 17 October 2014 01:02, jamessawle <g...@git.apache.org> wrote: >>> GitHub user jamessawle opened a pull request: >>> >>> https://github.com/apache/commons-lang/pull/32 >>> >>> Lang-536 >>> >>> Added new isSorted methods to the ArrayUtils class, along with generic >>> implementations. >>> >>> Some of the primitive methods have needed reverse-engineered Java 7 >>> 'compare' methods from their wrappers, so these have been added to their >>> respective Utils classes. >>> >>> You can merge this pull request into a Git repository by running: >>> >>> $ git pull https://github.com/jamessawle/commons-lang LANG-536 >>> >>> Alternatively you can review and apply these changes as the patch at: >>> >>> https://github.com/apache/commons-lang/pull/32.patch >>> >>> To close this pull request, make a commit to your master/trunk branch >>> with (at least) the following in the commit message: >>> >>> This closes #32 >>> >>> ---- >>> commit d5244ac66df9557ecb634a1478b4a7c29f2a1783 >>> Author: James Sawle <jamessa...@hotmail.com> >>> Date: 2014-10-16T23:33:34Z >>> >>> LANG-536 Added new isSorted methods, both generic and primitive. Some of >>> the primitive methods require reverse-engineered compare methods due to >>> them not being added to their wrapper classes until Java 7. Tests for these >>> are to be added. >>> >>> commit af379292f30c4269dfb9b51882c5fc954ce84c49 >>> Author: James Sawle <jamessa...@hotmail.com> >>> Date: 2014-10-16T23:56:59Z >>> >>> LANG-536 Added unit tests for new compare methods within Number, Boolean >>> and CharUtils. >>> >>> ---- >>> >>> >>> --- >>> If your project is set up for it, you can reply to this email and have your >>> reply appear on GitHub as well. If your project does not have this feature >>> enabled and wishes so, or if the feature is enabled but not working, please >>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket >>> with INFRA. >>> --- >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
