Hi
Think both points are valid actually.
Concretely, such a change has perf impacts, indeed compared to a db init it
will be very fast but compared to a driver operation it can be something.
Therefore a microbench comparison does not hurt and will at least guarantee
it is ok and make people calm
On Thu, Aug 29, 2019 at 6:17 PM Phil Steitz wrote:
>
>
> On 8/29/19 6:37 AM, Gary Gregory wrote:
> > Hi All:
> >
> > In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of
> > boilerplate code using lambdas. This also happens to fix a bunch of
> places
> > where we did not call
On 8/29/19 6:37 AM, Gary Gregory wrote:
Hi All:
In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of
boilerplate code using lambdas. This also happens to fix a bunch of places
where we did not call checkOpen() when we should have.
Interesting. I have a couple of comment
Hi All:
In https://github.com/apache/commons-dbcp/pull/34, I've reduced a ton of
boilerplate code using lambdas. This also happens to fix a bunch of places
where we did not call checkOpen() when we should have.
Gary
Response inline
On Wed, Aug 28, 2019 at 11:55 PM Peter Verhas wrote:
>
> [snip...]
> Paul King
>
> >You can stop using the JavadocAssertionTestSuite at any time.
> >The code will still be in the Javadoc as documentation but just won't
> >be tested any more as part of your test suite.
>
> This
