Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Damjan Jovanovic
For the record, I would only use this for imaging >= 2.0. Weaver looked undocumented and undecipherable to me, but let me look at it again slowly. Damjan On Sun, Nov 3, 2013 at 9:14 PM, Matt Benson wrote: > I wasn't under the impression this was blocking imaging 1.0. In any case, > framing Da

Re: svn commit: r1538479 - /commons/proper/pool/trunk/pom.xml

2013-11-03 Thread Thomas Neidhart
On 11/04/2013 12:43 AM, pste...@apache.org wrote: > Author: psteitz > Date: Sun Nov 3 23:43:06 2013 > New Revision: 1538479 > > URL: http://svn.apache.org/r1538479 > Log: > Updated componentId to pool2. > > Modified: > commons/proper/pool/trunk/pom.xml > > Modified: commons/proper/pool/trun

Re: [VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-03 Thread Gary Gregory
Original message From: Bernd Eckenfels Date:11/03/2013 19:16 (GMT-05:00) To: Commons Developers List Subject: Re: [VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0 Hello, I dont think it is a critical thing for OSGi for two reasons: a) typically dependencies are no longer

Re: [VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-03 Thread Bernd Eckenfels
Hello, I dont think it is a critical thing for OSGi for two reasons: a) typically dependencies are no longer on the bundle name but on packages b) there is no need to change the coordinates at all, as the major version differs Greetings Bernd Am 04.11.2013, 00:43 Uhr, schrieb Phil Steitz :

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Gilles
On Sun, 03 Nov 2013 15:33:12 -0800, Phil Steitz wrote: On 11/3/13 2:57 PM, Gilles wrote: On Sun, 03 Nov 2013 21:03:02 +0100, Luc Maisonobe wrote: Le 03/11/2013 20:17, Ted Dunning a écrit : On Sun, Nov 3, 2013 at 10:56 AM, Luc Maisonobe wrote: I had proposed that error messages be incrementa

Re: [VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-03 Thread Phil Steitz
-0 I am really sorry that I did not catch this in the first review, but I am afraid we will be headed for a reprise of LANG-749 if we release this. The jar manifest has Bundle-SymbolicName: org.apache.commons.pool IIUC what was stated in LANG-749, this should be pool2. This is picked up from co

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Phil Steitz
On 11/3/13 2:57 PM, Gilles wrote: > On Sun, 03 Nov 2013 21:03:02 +0100, Luc Maisonobe wrote: >> Le 03/11/2013 20:17, Ted Dunning a écrit : >>> On Sun, Nov 3, 2013 at 10:56 AM, Luc Maisonobe >>> wrote: >>> > I had proposed that error messages be incrementally built from > simple > "base

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Gilles
On Sun, 3 Nov 2013 14:45:00 +, Sean Owen wrote: On Sun, Nov 3, 2013 at 1:43 PM, Gilles wrote: A case that occurs often is "zero" (as "double"). I prefer "0d". (I'm certainly not going to propose to change it, but my personal preference is 0.0 because it's obviously decimal even to newbies

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Gilles
On Sun, 03 Nov 2013 21:03:02 +0100, Luc Maisonobe wrote: Le 03/11/2013 20:17, Ted Dunning a écrit : On Sun, Nov 3, 2013 at 10:56 AM, Luc Maisonobe wrote: I had proposed that error messages be incrementally built from simple "base" patterns, to be assembled either at the point where the exce

[VOTE] Release Apache Commons Pool 2.0 RC3 as 2.0

2013-11-03 Thread Mark Thomas
A number of minor issues were noted in RC2 that have been fixed in this RC3. They include: - Use https links to Jira - Correct versions on download page - Fix final Findbugs warning - Better code coverage of unit tests - Make JRE requirement explicit - Add a missing AL2 header - Add some missing Ja

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Luc Maisonobe
Le 03/11/2013 20:17, Ted Dunning a écrit : > On Sun, Nov 3, 2013 at 10:56 AM, Luc Maisonobe wrote: > >>> I had proposed that error messages be incrementally built from simple >>> "base" patterns, to be assembled either at the point where the exception >>> is going to be thrown or inside specific

[CANCELLED][VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 31/10/2013 15:02, Mark Thomas wrote: > Development on Pool 2 is complete and a review of the remaining DBCP > bugs has not highlighted any that are likely to trigger significant API > changes in Pool so it is time for a release. While RC2 did gather enough votes for a release, folks also highli

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 02/11/2013 23:36, Thomas Neidhart wrote: Thanks for the testing. > One minor thing: > > When publishing the site you will most likely encounter problems, as the > pom is missing some configurations regarding the scm publishing. > > Unless you deliberately kept the componentid at 'pool', you

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 03/11/2013 16:59, Gary Gregory wrote: > Any reason we are using an old version of asm-util? We are using 4.0, the > current version is 4.2. I think because cglib cited 4.0 as a dependency. I'll update to 4.2 assuming all the tests still pass. Mark > > Gary > > > On Thu, Oct 31, 2013 at 11

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 02/11/2013 22:41, Phil Steitz wrote: > 0) We forgot to specify required JDK level anywhere. Fixed in > trunk. If you regenerate release notes, this will be fixed. Will do. Thanks. > 1) The Ant build is broken due to cglib dependency. We should > either dump the Ant build or fix it. I don'

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Ted Dunning
On Sun, Nov 3, 2013 at 10:56 AM, Luc Maisonobe wrote: > > I had proposed that error messages be incrementally built from simple > > "base" patterns, to be assembled either at the point where the exception > > is going to be thrown or inside specific exceptions[2] (or a combination > > of both). >

Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Matt Benson
I wasn't under the impression this was blocking imaging 1.0. In any case, framing Damjan's work as a Weaver module would still use the same work he's done with ASM and would really only utilize a standard mechanism for triggering the process. It would also avoid proliferation of multiple maven plug

Re: svn commit: r1538418 - /commons/proper/pool/trunk/build.xml

2013-11-03 Thread Phil Steitz
On 11/3/13 11:03 AM, ma...@apache.org wrote: > Author: markt > Date: Sun Nov 3 19:03:22 2013 > New Revision: 1538418 > > URL: http://svn.apache.org/r1538418 > Log: > Document class path requirements > > Modified: > commons/proper/pool/trunk/build.xml > > Modified: commons/proper/pool/trunk/bui

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Phil Steitz
On 11/2/13 3:41 PM, Phil Steitz wrote: > On 11/1/13 5:53 AM, Mark Thomas wrote: >> On 01/11/2013 12:27, Benedikt Ritter wrote: >>> Hello Mark, >>> >>> again building with: >> Thanks again for the testing. >> >>> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 >>> 17:22:22+0

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Luc Maisonobe
Le 03/11/2013 14:43, Gilles a écrit : > On Sun, 3 Nov 2013 10:30:40 +, Sean Owen wrote: >> On Sun, Nov 3, 2013 at 4:17 AM, Ted Dunning >> wrote: >>> Does this actually matter after the JIT takes hold? And if the JIT >>> doesn't >>> care to optimize this away, does it even matter? >> >> Unclea

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Luc Maisonobe
Hi Gilles, Le 03/11/2013 14:33, Gilles a écrit : > On Sat, 2 Nov 2013 17:35:17 +, Sean Owen wrote: >> On Sat, Nov 2, 2013 at 4:49 PM, Phil Steitz >> wrote: >>> If the improvements make a material difference [1], by all means >>> open tickets and submit patches. If they are just cosmetic, my

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 02/11/2013 22:40, Jörg Schaible wrote: > Hi Mark, > > Mark Thomas wrote: > >> Development on Pool 2 is complete and a review of the remaining DBCP >> bugs has not highlighted any that are likely to trigger significant API >> changes in Pool so it is time for a release. >> >> The Pool 2.0 RC2

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 01/11/2013 14:06, Gary Gregory wrote: > +1 > > BUT: > > - We could use a migration guide, even if it just says "change the package > name from ...pool to pool2." I added some basic text to index.xml. We can expand it based on feedback. > - Not a blocker but should be addressed, from the

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Mark Thomas
On 03/11/2013 16:56, Gary Gregory wrote: > BTW, why are we not using Java 6's LinkedBlockingDeque instead of our > custom LinkedBlockingDeque? http://svn.apache.org/viewvc?view=revision&revision=1175092 Mark - To unsubscribe, e

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Gary Gregory
Any reason we are using an old version of asm-util? We are using 4.0, the current version is 4.2. Gary On Thu, Oct 31, 2013 at 11:02 AM, Mark Thomas wrote: > Development on Pool 2 is complete and a review of the remaining DBCP > bugs has not highlighted any that are likely to trigger significa

Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0

2013-11-03 Thread Gary Gregory
BTW, why are we not using Java 6's LinkedBlockingDeque instead of our custom LinkedBlockingDeque? Gary On Thu, Oct 31, 2013 at 11:02 AM, Mark Thomas wrote: > Development on Pool 2 is complete and a review of the remaining DBCP > bugs has not highlighted any that are likely to trigger significa

Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Gary Gregory
On Sun, Nov 3, 2013 at 10:56 AM, Matt Benson wrote: > Sounds like it would be trivial to frame what you've done here into the > context of a Weaver module, for which there exist both a maven plugin and > an Antlib, as well as a need for a near-term release. :-) > and eating our own dog food :)

Re: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Matt Benson
Sounds like it would be trivial to frame what you've done here into the context of a Weaver module, for which there exist both a maven plugin and an Antlib, as well as a need for a near-term release. :-) Matt On Nov 3, 2013 2:30 AM, "Damjan Jovanovic" wrote: > On Fri, Oct 25, 2013 at 1:52 PM, Ma

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Sean Owen
On Sun, Nov 3, 2013 at 1:43 PM, Gilles wrote: > A case that occurs often is "zero" (as "double"). > I prefer "0d". (I'm certainly not going to propose to change it, but my personal preference is 0.0 because it's obviously decimal even to newbies and can't be confused with a hex value. But this is

RE: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Gary Gregory
Original message From: Damjan Jovanovic Date:11/03/2013 03:30 (GMT-05:00) To: Commons Developers List Subject: Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream) On Fri, Oct 25, 2013 at 1:52 PM, Matt Benson wrote: > On Oct 25, 2013 6:30 AM, "D

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Gilles
On Sun, 3 Nov 2013 10:30:40 +, Sean Owen wrote: On Sun, Nov 3, 2013 at 4:17 AM, Ted Dunning wrote: Does this actually matter after the JIT takes hold? And if the JIT doesn't care to optimize this away, does it even matter? Unclear. There aren't hard guarantees about what the JIT does, b

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Gilles
On Sat, 2 Nov 2013 17:35:17 +, Sean Owen wrote: On Sat, Nov 2, 2013 at 4:49 PM, Phil Steitz wrote: If the improvements make a material difference [1], by all means open tickets and submit patches. If they are just cosmetic, my personal opinion is this should be done in small commits increm

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Sean Owen
On Sun, Nov 3, 2013 at 4:17 AM, Ted Dunning wrote: > Does this actually matter after the JIT takes hold? And if the JIT doesn't > care to optimize this away, does it even matter? Unclear. There aren't hard guarantees about what the JIT does, but transformations like this should be easy and local

Re: [MATH] Interest in large patches for small cleanup / performance changes?

2013-11-03 Thread Thomas Neidhart
On 11/02/2013 06:35 PM, Sean Owen wrote: > On Sat, Nov 2, 2013 at 4:49 PM, Phil Steitz wrote: >> If the improvements make a material difference [1], by all means >> open tickets and submit patches. If they are just cosmetic, my >> personal opinion is this should be done in small commits >> increm

Backporting try-with-resources to Java < 7 (was: Re: [imaging] Closing stream)

2013-11-03 Thread Damjan Jovanovic
On Fri, Oct 25, 2013 at 1:52 PM, Matt Benson wrote: > On Oct 25, 2013 6:30 AM, "Damjan Jovanovic" wrote: > > > > On Fri, Oct 25, 2013 at 12:36 PM, Jörg Schaible > > wrote: > > > Hi Damjan, > > > > > > Damjan Jovanovic wrote: > > > > > > [snip] > > > > > > Thanks for explanation. > > > > > >> We