On 01/11/2013 14:06, Gary Gregory wrote: > +1 > > BUT: > > - We could use a migration guide, even if it just says "change the package > name from ...pool to ....pool2."
I added some basic text to index.xml. We can expand it based on feedback. > - Not a blocker but should be addressed, from the RAT report: > > Unapproved licenses: > > src/site/resources/download_pool.cgi Fixed. > - Findbugs reports one MALICIOUS_CODE item, which we should either fix by > copying the array or Javadoc such that someone looking the report can click > on the source link and see the code comment. Already fixed. I got caught out because I fixed some visibility issues on the containing class at the last minute. > There is one class with 0% code coverage, not ideal for a new major > release: > https://people.apache.org/~markt/dev/commons-pool-2.0-RC2/cobertura/org.apache.commons.pool2.impl.DefaultPooledObjectInfo.html The class is pretty basic but I added some tests that cover most of it. > I do not understand the "N/A" for some of the other classes in the > Cobertura report. They all look to be interfaces. > - The release history report is missing version 1.6 (I'll take the blame on > that one since I cut the 1.6 release). 1.5.7 is missing as well. I've added them. > > Tested with: > > Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 > 08:51:28-0500) > Maven home: C:\Java\apache-maven-3.0.5\bin\.. > Java version: 1.7.0_45, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_45\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > With Maven 3.1.1, it bombs with: I'm at the limit of my Maven knowledge as it is. I intend leaving this to someone who wants to use Maven 3.1 Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
