On 8/8/13 10:20 PM, pste...@apache.org wrote:
> Author: psteitz
> Date: Fri Aug 9 05:20:37 2013
> New Revision: 1512140
>
> URL: http://svn.apache.org/r1512140
> Log:
> Eliminated PoolableObjectFactory, KeyedPoolableObjectFactory and replaced
> them with PooledObjectFactory, KeyedPooledObjectFact
Hello,
there are some more places where some semantic for input/output streams is
described (and I think it does not match the implementation)
org.apache.commons.vfs2.provider.http.HttpFileObject.doGetInputStream():127
* It is guaranteed that there are no open output streams for this
f
Local Maven 2 Build Definition (Java 1.6)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 129
X-Continuum-Project-Name: Commons VFS
Online report :
http://vmbuild.apache.org/continuum/bu
Local Maven 2 Build Definition (Java 1.6)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 129
X-Continuum-Project-Name: Commons VFS
Online report :
http://vmbuild.apache.org/continuum/bu
Group (shared) Maven 2 Build Definition (Java 1.5)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Continuum-Build-Host: vmbuild
X-Continuum-Project-Id: 97
X-Continuum-Project-Name: Commons Math
Online report :
http://vmbuild.apache.org/con
Bernd,
That looks interesting, but I don't see any way to publish the review. The
nice thing about Crucible is that it's web-based and integrated with JIRA.
Cheers,
Mark
On Thu, Aug 8, 2013 at 11:31 AM, Bernd Eckenfels wrote:
> Am 08.08.2013, 20:03 Uhr, schrieb Mark Fortner :
>
>
> Recently
On Thu, Aug 8, 2013 at 2:31 PM, Bernd Eckenfels wrote:
> Am 08.08.2013, 20:03 Uhr, schrieb Mark Fortner :
>
>
> Recently Bernd posted a code review of a few of the RAM provider classes.
>> That kind of feedback is very useful, and it made me wonder if there was a
>> standard way within commons to
Am 08.08.2013, 20:03 Uhr, schrieb Mark Fortner :
Recently Bernd posted a code review of a few of the RAM provider classes.
That kind of feedback is very useful, and it made me wonder if there was
a
standard way within commons to do code reviews? I know that apache
makes a
lot of use of Atla
Recently Bernd posted a code review of a few of the RAM provider classes.
That kind of feedback is very useful, and it made me wonder if there was a
standard way within commons to do code reviews? I know that apache makes a
lot of use of Atlassian software, and I've used their Crucible code review
Gilles wrote:
>> To address a few concerns I saw,
>>
>> Gilles wrote:
>>> In this way, it does not; what I inferred from the partial code
>>> above was
>>> that there would only be _one_ "create" method. But:
>>> 1. All "create" methods must be overridden at the next level of the
>>> class
>>> hie
Hello,
I was trying to understand the concurrency semantics of VFS2, and I found
some comments which contradict each other and all of them also contradict
the implementation:
The current implementation allows multiple input streams and multiple
random access and a single outputstream PER
On Thu, Aug 8, 2013 at 10:27 AM, Benedikt Ritter wrote:
> 2013/8/8 Emmanuel Bourg
>
> > Le 08/08/2013 15:40, Gary Gregory a écrit :
> >
> > > Sans type names:
> > >
> > > parse(File, CSVFormat)
> > > parse(String, Charset, ClassLoader, CSVFormat)
> > > parse(String, Charset, CSVFormat)
> > > [pa
On Thu, Aug 8, 2013 at 10:09 AM, Emmanuel Bourg wrote:
> Le 08/08/2013 15:40, Gary Gregory a écrit :
>
> > Sans type names:
> >
> > parse(File, CSVFormat)
> > parse(String, Charset, ClassLoader, CSVFormat)
> > parse(String, Charset, CSVFormat)
> > [parse(String)]
> > parse(String, CSVFormat)
> >
On Thu, Aug 8, 2013 at 10:09 AM, Emmanuel Bourg wrote:
> Le 08/08/2013 15:40, Gary Gregory a écrit :
>
> > Sans type names:
> >
> > parse(File, CSVFormat)
> > parse(String, Charset, ClassLoader, CSVFormat)
> > parse(String, Charset, CSVFormat)
> > [parse(String)]
> > parse(String, CSVFormat)
> >
Hi,
Am 08.06.2013 14:11, schrieb Gary Gregory:
The release date is TDB and yes it will be available through Maven
repositories.
What needs to be done to get that release out?
I had a quick look at JIRA and can't find any big blockers. Are there any
issues with the build or are you simply seeki
Am 08.08.2013, 16:09 Uhr, schrieb Emmanuel Bourg :
Le 08/08/2013 15:40, Gary Gregory a écrit :
Sans type names:
parse(File, CSVFormat)
parse(String, Charset, ClassLoader, CSVFormat)
parse(String, Charset, CSVFormat)
[parse(String)]
parse(String, CSVFormat)
parse(URL, Charset, CSVFormat)
That
Hello.
Sorry for the confusion my code sample caused; it made sense in my
mind.
:) I was speaking from the perspective that an abstract class is a
skeletal implementation of an interface, created so that implementing
the interface is easier. For the non-linear least squares (NLLS)
package
I
Le 08/08/2013 16:43, Benedikt Ritter a écrit :
> Damn it, Emmanuel is always against me ;-)
I love everyone :) I'm just against unnecessary complexity.
> Okay then: leave it as it is, but move factory methods from CSVParser to
> CSVFormat?
I'd support that. It's no longer factory methods at th
+1 for createParser(...)
-Adrian
On 8/8/2013 6:14 AM, Gary Gregory wrote:
On Thu, Aug 8, 2013 at 5:30 AM, Emmanuel Bourg wrote:
Thank you for pointing this, I didn't notice this recent addition.
I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t).
I'm OK with 'parse' o
2013/8/8 Emmanuel Bourg
> Le 08/08/2013 16:27, Benedikt Ritter a écrit :
>
> > A format can parse something... That sounds strange to me.
>
> That's pretty common though. NumberFormat, DateFormat are good examples.
>
>
> > Let's rename it to
> >
> >format.createParser(file)
>
> Please, no :)
Le 08/08/2013 16:27, Benedikt Ritter a écrit :
> A format can parse something... That sounds strange to me.
That's pretty common though. NumberFormat, DateFormat are good examples.
> Let's rename it to
>
>format.createParser(file)
Please, no :)
Emmanuel
---
2013/8/8 Emmanuel Bourg
> Le 08/08/2013 15:40, Gary Gregory a écrit :
>
> > Sans type names:
> >
> > parse(File, CSVFormat)
> > parse(String, Charset, ClassLoader, CSVFormat)
> > parse(String, Charset, CSVFormat)
> > [parse(String)]
> > parse(String, CSVFormat)
> > parse(URL, Charset, CSVFormat)
Le 08/08/2013 15:40, Gary Gregory a écrit :
> Sans type names:
>
> parse(File, CSVFormat)
> parse(String, Charset, ClassLoader, CSVFormat)
> parse(String, Charset, CSVFormat)
> [parse(String)]
> parse(String, CSVFormat)
> parse(URL, Charset, CSVFormat)
That looks better. I would remove the metho
Hi again,
Sorry for the confusion my code sample caused; it made sense in my mind.
:) I was speaking from the perspective that an abstract class is a
skeletal implementation of an interface, created so that implementing
the interface is easier. For the non-linear least squares (NLLS) package
I was
Le 08/08/2013 15:10, Gary Gregory a écrit :
> The one instance factory method in CSVFormat is a convenience that I do not
> find useful, it just makes for a nice demo _in theory_. In my experience, I
> always create utility methods to create Readers from different sources. I
> would be OK removing
On Thu, Aug 8, 2013 at 9:14 AM, Gary Gregory wrote:
> On Thu, Aug 8, 2013 at 5:30 AM, Emmanuel Bourg wrote:
>
>> Thank you for pointing this, I didn't notice this recent addition.
>>
>> I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t).
>>
>
> I'm OK with 'parse' or 'create
On Thu, Aug 8, 2013 at 9:10 AM, Gary Gregory wrote:
> On Thu, Aug 8, 2013 at 4:24 AM, Benedikt Ritter wrote:
>
>> Hi,
>>
>> we currently have several static factory methods in CSVParser:
>>
>> - public static CSVParser parseFile(File file, final CSVFormat format)
>> throws IOException
>> - public
On Thu, Aug 8, 2013 at 5:30 AM, Emmanuel Bourg wrote:
> Thank you for pointing this, I didn't notice this recent addition.
>
> I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t).
>
I'm OK with 'parse' or 'createParser'. WRT to types, the only time the type
name is really nee
On Thu, Aug 8, 2013 at 4:24 AM, Benedikt Ritter wrote:
> Hi,
>
> we currently have several static factory methods in CSVParser:
>
> - public static CSVParser parseFile(File file, final CSVFormat format)
> throws IOException
> - public static CSVParser parseResource(String resource, Charset charse
Le 08/08/2013 14:25, Benedikt Ritter a écrit :
> Anyway we would still have the problems I outline:
> - the same CSVParser can be created in different ways (via contructor and
> via CSVFormat.parse(Reader)).
And from CSVFormat.parse()
> - parse methods don't actually parse. They just create pars
2013/8/8 Emmanuel Bourg
> Thank you for pointing this, I didn't notice this recent addition.
>
> I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t).
>
Different method names make sense for parseResource(String, Charset,
ClassLoader, CSVFormat) and parseString(String). One ca
On Aug 8, 2013, at 4:47, "Schalk W. Cronjé" wrote:
>
> (Apologies if this has been discussed before, but I could not find anything
> related).
>
> Since Java7, Java.nio.FileSystem and related classes are available. To a
> great extent this seems to have the same goal as what Apache VFS. It only
Hi.
On Thu, 08 Aug 2013 10:03:36 +0200, Luc Maisonobe wrote:
Le 08/08/2013 01:13, Gilles a écrit :
On Wed, 7 Aug 2013 18:04:39 -0400, Evan Ward wrote:
Hi,
As a grateful user of the library, I would prefer the Fluent API
and
immutability. I have implemented this pattern in some of my own
pro
On 2013-08-07, Emmanuel Bourg wrote:
> Le 07/08/2013 17:15, Stefan Bodewig a écrit :
>> I'm not sure whether we have any policy on this, but so far I've tried
>> to stick with 80 columns max. Maybe that's a sign of me being old
>> fashioned, don't know :-)
> 80 columns is quite restrictive with
Continuum seems to be borked again; report it on builds@a.o
On 8 August 2013 05:03, Gary Gregory wrote:
> Hi all,
>
> Is this a corrupted maven local cache issue? A maven 2 vs 3 issue?
>
> Gary
>
> On Aug 7, 2013, at 23:21, "Continuum@vmbuild" wrote:
>
>> Local Maven 2 Build Definition
Thank you for pointing this, I didn't notice this recent addition.
I'm not fond of the parseType(Type t) methods, I'd prefer parse(Type t).
Btw I would have kept these methods out of csv 1.0, this is again
delaying the release with another discussion...
Emmanuel Bourg
Le 08/08/2013 10:24, Bene
(Apologies if this has been discussed before, but I could not find anything
related).
Since Java7, Java.nio.FileSystem and related classes are available. To a great
extent this seems to have the same goal as what Apache VFS. It only has file://
implemented and relies on third parties to do the
Hi,
we currently have several static factory methods in CSVParser:
- public static CSVParser parseFile(File file, final CSVFormat format)
throws IOException
- public static CSVParser parseResource(String resource, Charset charset,
ClassLoader classLoader,
final CSVFormat format) throw
Le 08/08/2013 01:13, Gilles a écrit :
> On Wed, 7 Aug 2013 18:04:39 -0400, Evan Ward wrote:
>> Hi,
>>
>> As a grateful user of the library, I would prefer the Fluent API and
>> immutability. I have implemented this pattern in some of my own projects
>> and it makes the API very easy to use.
>>
>> M
39 matches
Mail list logo