On Thu, Aug 8, 2013 at 10:09 AM, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 08/08/2013 15:40, Gary Gregory a écrit : > > > Sans type names: > > > > parse(File, CSVFormat) > > parse(String, Charset, ClassLoader, CSVFormat) > > parse(String, Charset, CSVFormat) > > [parse(String)] > > parse(String, CSVFormat) > > parse(URL, Charset, CSVFormat) > > That looks better. I would remove the methods for a classpath resource, > that's a less common case. That's the data source _my_ app uses everyday ;) Gary > That would make: > > parse(File, CSVFormat) > parse(String, CSVFormat) > parse(URL, Charset, CSVFormat) > > And you probably want a charset for the File too. > > > > [I'd probably remove parse(String) so that all APIs take a CSVFormat.] > > +1. > > And at this point you realize they could belong to CSVFormat, because > they all need one to operate. > > format.parse(file): > > instead of: > > CSVParser.parse(file, format); > > > Emmanuel Bourg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
