RE: [vote] Release commons-net 2.0

2008-09-30 Thread Jörg Schaible
Hi Rory, - the clirr report compares 2.0 against 1.4.1 instead of 1.5.0. - the changes report is missing some information in the release history. This is not your fault, but it would be nice anyway to provide complete infos. - the javadoc contains the classes in the example packages. Nothing of

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Wed, Oct 1, 2008 at 1:05 AM, Rory Winston <[EMAIL PROTECTED]> wrote: > Done! Great, +1 on releasing. /niklas - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Wed, Oct 1, 2008 at 12:51 AM, Rory Winston <[EMAIL PROTECTED]> wrote: > ...I suspect Maven may have done this itself. You're right. You can disable this behavior with the following configuration: maven-jar-plugin 2.2 false

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Rory Winston
Done! Thanks Rory Niklas Gustavsson wrote: On Mon, Sep 29, 2008 at 11:50 PM, Rory Winston <[EMAIL PROTECTED]> wrote: Yes, sorry, I just realised that I have an older key in my key list which must be the default for signing. I've uploaded it to pgp.mit.edu and I will add it to the appropriate

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Rory Winston
Hmm, I havent explicitly put the pom.xml under META_INF/maven/commons-net/commons-net ...I suspect Maven may have done this itself. sebb wrote: On 28/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: Hi all After the RC inspection a week or so ago, I am putting up a candidate for relea

Re: [vote] Release commons-net 2.0

2008-09-30 Thread sebb
On 28/09/2008, Rory Winston <[EMAIL PROTECTED]> wrote: > Hi all > > After the RC inspection a week or so ago, I am putting up a candidate for > release. Based on the feedback on the RC, I have made the following changes: > > * Excluded the examples/ classes from the binary jar > * Put LICENSE.tx

Re: [vote] Release commons-net 2.0

2008-09-30 Thread Niklas Gustavsson
On Mon, Sep 29, 2008 at 11:50 PM, Rory Winston <[EMAIL PROTECTED]> wrote: > Yes, sorry, I just realised that I have an older key in my key list which > must be the default for signing. I've uploaded it to pgp.mit.edu and I will > add it to the appropriate KEYS file as well. Now find it at pgp.mit.