Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/308#issuecomment-110275707
@vadimkim
The only cookie that is set by the server and needs to be rewritten is the
sessionkey cookie, all the others are created by the client and will
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/308#issuecomment-110293689
@vadimkim are you building the latest version of this PR? I've removed the
initial host_ prefix on the cookies, since that was not the issue that led to
bre
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/392
Resolve findbugs encoding warning
Was safe either way as this piece of code should only run in linux, this
just gets rid of the findbugs warning
You can merge this pull request into a Git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/393
Fix findbugs encoding warning, all .xml files contain only utf-8/us-aâ¦
Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii
compatible characters. If special
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/394
Fix findbugs encoding issue
This is done by calling HttpMethodBase's getResponseBodyAsString() which
properly looks up the specified encoding in the request's Content-Type heade
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/395
Fix findbugs encoding warning in CitrixResourceBase
Output of text files should be UTF-8, this is the default for linux, will
now always use the same format for every platform
You can merge
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/396
Fix another findbugs encoding warning in CitrixResourceBase
In this case, using default encoding is desired, since the purpose is to
read shell command output, which uses the platform&#
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/397
Fix findbugs encoding warning in HttpNfcLeaseMO
VMWare ovf files are utf-8 encoded. Relying on default encoding in some
platforms such as windows would cause erroneous characters from being
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/398
Fix findbugs encoding warning in JuniperSrxResource
All .xml files contain only utf-8/us-ascii compatible characters. If
special characters are added to these files in the future, UTF-8
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/399
Fix 4 findbugs warnings in JuniperSrxResource
Data should be read and written in UTF-8 to the SRX
Buffers were being used for reading but not for writing, PrintWriter was
auto-flushing
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/400
Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper
Encoding is now specified in both server and clients for the console proxy
getstatus command
For some reason, findbugs did
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/401
Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVoluâ¦
â¦meCommandWrapper
Libvirt templates should be written in UTF-8, default was already doing
that so this
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/402
Fix findbugs encoding issue in MemStat.java
Was safe either way as this piece of code should only run in linux and only
contains safe characters, this just gets rid of the findbugs warning
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/405
Fix 2 findbugs encoding warnings in VmwareContext.java
StreamReaders should use encoding specified in the connection object
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/403
Fix findbugs encoding warning
Vmds files created by ESX are UTF-8 encoded
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/404
Fix 3 findbugs encoding warnings
Vmdk descriptor files used by ESX should be UTF-8 encoded
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/414
Fix 2 findbugs ClassCastExceptions
getDetails() isn't called anywhere in the code, either way, implementation
is wrong since details is a Map\ and not a Map\\>
If this piece
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/413
Fix findbugs ClassCastException in UpgradeSystemVMCmd.java
getDetails() isn't called anywhere in the code, either way, implementation
is wrong since details is a Map\ and not a Map\\>
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/410
Fix 2 findbugs warnings in VmwareStorageManagerImpl.java
Ova template files and metadata should be written to file in UTF-8
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/407
Fix findbugs warning in VmwareHelper.java
Disk descriptors should be written in UTF-8 for Vmware
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/411
Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java
Ova templates and metadata should be written to file in UTF-8
Fix warning in UUID generation
You can merge this pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/409
Fix 1 findbugs warning in VmwareResource.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack findbugs26
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/406
Fix findbugs encoding warning
ESX responses should be encoded in UTF-8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/412
Fix findbugs ClassCastException in ScaleSystemVMCmd.java
getDetails() isn't called anywhere in the code, either way, implementation
is wrong since details is a Map and not a Map>
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/408
Fix findbugs encoding warning in VmwareServerDiscoverer.java
Input string should only contain safe characters, since it's derived from a
Long object. This just gets rid of the fin
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/415
Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in ServerTransportProvâ¦
Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in
ServerTransportProvider.java
Changed to recommended
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/416
Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java
Changed to recommended SecureRandom instead of Random
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/417
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in DeployVMCmd.java
Was creating Long to assign to long
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/418
Fix 4 findbugs warnings in Upgrade218to22.java
Was creating boxed Integers when only int is required
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/419
Fix findbugs warning in Upgrade421to430.java
Was creating Integer to assign to int
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/420
Fix findbugs warning in ClusterManagerImpl.java
ManagementServerHostDao.findByMsid takes long as input, and a boxed Long
was being created for it
You can merge this pull request into a Git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/421
Fix findbugs warning in BareMetalResourceBase.java
Boxed Integer was being instantiated to assign to an int variable
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/422
Fix findbugs warning in HypervDirectConnectResource.java
Two boxed Longs were being created instead of simple long
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/423
Fix findbugs warning in OvmResourceBase.java
CreatePrivateTemplateAnswer constructor takes long as physicalSize
parameter, Long was being created instead
You can merge this pull request
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/424
Fix findbugs warning in UcsManagerImpl.java
Integer was being created to assign value to int
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/425
Fixed 4 findbugs warnings in CitrixResourceBase.java
Unnecessary boxing/unboxing of primitive values
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/426
Fix findbugs warning in NetscalerResource.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/427
Fix findbugs warning in PaloAltoResource.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/428
Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/429
Fix 2 findbugs warnings in ElastistorUtil.java
Unnecessary boxing/unboxing of long value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/430
Fix findbugs warning in ApiDispatcher.java
Unnecessary boxing/unboxing of long value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/431
Fix findbugs warning in CloudZonesStartupProcessor.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/432
Fix 2 findbugs warnings in NetworkServiceImpl.java
Unnecessary boxing/unboxing of int values
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/433
Fix findbugs warning in NetworkUsageManagerImpl.java
Unnecessary boxing/unboxing of long value to create Date
You can merge this pull request into a Git repository by running:
$ git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/434
Fix findbugs warning in ProjectManagerImpl.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/435
Fix findbugs warning in NetUtils.java
Unnecessary boxing/unboxing of primitive value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/436
Fix findbugs warning in Script.java
Unnecessary boxing/unboxing of int value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/437
Fix findbugs warning in NetworkServiceImpl.java
Integer was being boxed just to call toString()
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/438
Fix 2 findbugs warnings in ApiResponseHelper.java
ints were being boxed just to call .toString()
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/439
Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java
When overriding equals(), hashCode() must also be overriden do comply with
the directive that equal objects must have equal
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/440
Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceâ¦
â¦Impl.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/441
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in Upgrade2214to30.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/442
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in Upgrade30xBase.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/443
Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in Upgrade410to420.java
There was no risk of sql injection here, nor any need to use
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/444
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦
â¦Impl.java
Assert isn't used in runtime, null is properly checked in method
You can merge this
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/445
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachiâ¦
â¦neManagerImpl.java
Removed two unnecessary null checks as this piece of code will only run if
answer is
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/446
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDisâ¦
â¦patcher.java
Assert isn't used in prod runtime, null is properly checked in method
You can merge
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/447
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCeâ¦
â¦nterVO.java
Assert isn't used in prod runtime, null is checked in method
You can merge this pull re
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/448
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVOâ¦
â¦.java
Assert isn't used in prod runtime, null is checked in method
You can merge this pull request i
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/449
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrcheâ¦
â¦strator.java
If answer is null, method will throw ConnectionException in line 3016 as
satisfied by
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/450
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVOâ¦
â¦.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by ru
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/451
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/452
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferâ¦
â¦ingVO.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/453
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerâ¦
â¦Impl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/454
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderIâ¦
â¦mpl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/455
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVOâ¦
â¦.java
Assert isn't used in prod runtime
You can merge this pull request into a Git repository by ru
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/456
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManâ¦
â¦agerImpl.java
Assert isn't used in prod runtime
You can merge this pull request into a Git reposito
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/457
Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in Bâ¦
â¦aseCmd.java
Dateformat objects are not thread safe. Instance field is highly
recommended for these
You
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/399#issuecomment-111994620
perhaps due to other changes in base file? I've rebased with current
master, can you retry @bhaisaab ? :)
---
If your project is set up for it, you can rep
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/457#issuecomment-112080925
@DaanHoogland it's a fluke, sry :)
Must have typed "wq1" instead of "wq!" on vi ... fixed and rebased
---
If your project is set up
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/459#issuecomment-112091994
Let's see what new issues all those new patterns will uncover ;)
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/460
Fix findbugs encoding issue in VmwareStorageProcessor.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/461
Fix findbugs warning in VmwareStorageManagerImpl.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this pull re
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/462
Fix findbugs encoding issue in VmwareResource.java
Key file should be UTF-8 encoded in VR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/463
Fix css syntax error in cloudstack3.css
Just a simple syntax fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/460#discussion_r32469324
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,7 @@ public Answer forgetObject
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/462#discussion_r32472663
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -705,7 +705,7 @@ public ExecutionResult
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/461#discussion_r32472910
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -256,7 +256,7 @@ public Answer
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112232241
Here's an example of an instance where i also removed a
Charset.defaultCharset() that was placed in the reading of a socket, where
cloudstack controls both
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112338005
my bad there.. will surround in try/catch block and update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/464
Catch encoding exception
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack findbugs75
Alternatively you can review
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112344047
@DaanHoogland done!
https://github.com/apache/cloudstack/pull/464
I should have checked travis for this one, still my bad :(
---
If your project is set
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/464#discussion_r32506402
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,11 @@ public Answer forgetObject
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/464#discussion_r32506889
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,11 @@ public Answer forgetObject
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617440
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -32,6 +33,21 @@
public class StringUtils {
private static final char
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617957
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32618952
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/473
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in UserVmDaoImpl.java
detail field was vulnerable
You can merge this pull request into a Git
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/474
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in PrimaryDataStoreDaoImpl.java
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/475
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in AsyncJobDaoImpl.java
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/476
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in ConfigurationManagerImpl.java
You can merge this pull request into a Git repository by running
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/477
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRINGâ¦
⦠warning in ConfigurationServerImpl.java
You can merge this pull request into a Git repository by running
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/473#discussion_r32663864
--- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java ---
@@ -645,8 +643,9 @@ public boolean remove(Long id
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/478
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRIâ¦
â¦NG warnings in DatabaseConfig.java
You can merge this pull request into a Git repository by running:
$ git
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/477#issuecomment-113097972
Was already asleep by the time travis finished running hehe... removed
trailing space, waiting for travis again :)
---
If your project is set up for it, you can
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/476#discussion_r32715161
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/482
This is a quick fix to attempt to resolve most of the travis failures
Most of the failures have been due to transient network failures, that are
causing dependency artifact downloads to fail
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113284857
Travis failure on 2c0d07e was due to second phase not running after i moved
the script to tools/travis
xerxesImpl is downloaded on that phase
Issue is
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113321916
Travis is still not looking very well :( will resume soon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/482#issuecomment-113487647
7 successes in a row is looking better :)
Will do a couple more minor changes to force some more runs.. will rebase
at the end when it feels like travis is
101 - 200 of 236 matches
Mail list logo
