Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617957
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String createOVAFromMetafile(String
metafileName) throws Exception {
} catch (Exception e) {
s_logger.error("Exception while creating OVA using Metafile",
e);
throw e;
- } finally {
- if (strm != null) {
- try {
- strm.close();
--- End diff --
Since you removed the finally block, the FileInputStream is not getting
closed. Put it at the end of the try block at least :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
