Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/464#discussion_r32506402
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,11 @@ public Answer forgetObject(ForgetObjectCmd cmd) {
}
private static String deriveTemplateUuidOnHost(VmwareHypervisorHost
hyperHost, String storeIdentifier, String templateName) {
- String templateUuid = UUID.nameUUIDFromBytes((templateName + "@" +
storeIdentifier + "-" +
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+ try{
+ String templateUuid = UUID.nameUUIDFromBytes((templateName +
"@" + storeIdentifier + "-" +
hyperHost.getMor().getValue()).getBytes("UTF-8")).toString();
+ }catch(UnsupportedEncodingException e){
+ s_logger.warn("Unable to generate UUID due to unexpected
encoding error."+e);
--- End diff --
@DaanHoogland
I changed to localized message as requested.
I don't expect this exception to ever be thrown, because it will only do so
if the undelying platform really doesn't support UTF-8 at all. Can't think of a
platform that wouldn't support that nowadays, wether it's the default or not.
Adding a retry within the catch would require another catch within it, so i
think its too much for an exception that would likely never be thrown ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
