[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-23 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti Thanks for the info! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-23 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1953 Thanks @sureshanaparti will test it soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-25 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1953 Tested it, works as expected! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-25 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele Nice improvement, thanks! Tested it and works as you described. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1198: CLOUDSTACK-9114: restartnetwork with cleanup should ...

2017-02-25 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1198 @ustcweizhou If you find some time to submit PRs for restartVPC+cleanup which does the router rebuild in sequence that would be awesome. Happy to help testing! Thanks! --- If your project

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-03-02 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1955 Tested it manually, works great. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

2017-03-04 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1980 @rhtyd Looks great! Shall we do the same for the VPC routers, so that the overviews look the same? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1999 @resmo we use this i production so @ustcweizhou is right. From a test environment I just made some screenshots to demonstrate this. It's actually prety cool :-) This VM is pa

[GitHub] cloudstack issue #2003: CLOUDSTACK-9811: fixed an issue if the dev is not in...

2017-03-17 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/2003 @swill FYI if you look for `first_i_p` as seen in the json on the Python side, then on the Java side it's called `firstIP`, as the gson lib replaces every capital with an underscor

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-25 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1889 Nice work @rashmidixit, tested it and works great! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #2015: CLOUDSTACK-9843 : Performance improvement of SSHHelp...

2017-03-25 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/2015 @sudhansu7 Thanks for the fix. We need to update the unit test as well. Please check: ``` diff --git a/cosmic-core/utils/src/test/java/com/cloud/utils/ssh

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

2017-03-26 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1980 Nice @rhtyd LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack-docs-rn pull request: added note on CLOUDSTACK-7595

2015-03-12 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/18 added note on CLOUDSTACK-7595 You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack-docs-rn 4.4 Alternatively

[GitHub] cloudstack-docs-rn pull request: add note on CLOUDSTACK-7595

2015-03-12 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack-docs-rn/pull/19 add note on CLOUDSTACK-7595 You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack-docs-rn 4.5 Alternatively

[GitHub] cloudstack-docs-rn pull request: added note on CLOUDSTACK-7595

2015-03-12 Thread remibergsma
Github user remibergsma closed the pull request at: https://github.com/apache/cloudstack-docs-rn/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-01 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/140 reboot much faster in case of storage failure When storage cannot be reached, it does not make sense to reboot as it will try to flush buffers, umount NFS mounts, etc. This will not work

[GitHub] cloudstack pull request: reboot much faster in case of storage fai...

2015-04-02 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/140#issuecomment-89006232 Ok, check! I will add it like that. Although you can never be sure log packets go out over the network because if the storage is unavailable due to

[GitHub] cloudstack pull request: write logfile just before rebooting the h...

2015-04-03 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/145 write logfile just before rebooting the host As discussed with @wido @pyr and @nuxro added an extra log line. Tested it and it logs fine (tested to local disk) when syncing first

[GitHub] cloudstack pull request: KVM: make sure sync cannot block reboot

2015-04-09 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/152 KVM: make sure sync cannot block reboot The recent discussed improvement has the risk that if 'sync' hangs, the reboot may be delayed in the same way as the 'reboot'

[GitHub] cloudstack pull request: CLOUDSTACK-6543 Sort domain lists in UI

2015-04-12 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/157 CLOUDSTACK-6543 Sort domain lists in UI As recently discussed on the dev list: This sorts the domain lists based on their path. Especially handy when having a lot of domains,like in a

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/164 Upgrades from 4.4: disable foreign key checks when altering them Upgrades from 4.4 where not working properly due to errors like this: ERROR 1833 (HY000): Cannot change column &#x

[GitHub] cloudstack pull request: KVM: improve CentOS 7 support (ifconfig)

2015-04-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/165 KVM: improve CentOS 7 support (ifconfig) CentOS 7 does not ship with ifconfig anymore. We should use ip commands instead. This also works on older versions, like CentOS 6 and Ubuntu 12.x/14

[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...

2014-11-18 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/1 keep colons in the request to ACS ACS does not decode %3A to colon and thus some requests break You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...

2014-11-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63458765 I didn't create a ticket for it. Will do if you want me to :-) Sent from my iPhone > On 18 Nov 2014, at 12:13, runse

[GitHub] cloudstack-cloudmonkey pull request: keep colons in the request to...

2014-11-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/1#issuecomment-63460966 Created CLOUDSTACK-7935 for documentation purposes. See: https://issues.apache.org/jira/browse/CLOUDSTACK-7935 You can close this issue when

[GitHub] cloudstack pull request: make the VPN feature work more reliable a...

2014-12-08 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/54 make the VPN feature work more reliable and secure At Schuberg Philis we wanted to use the VPN feature, but found it hard to make it work in a reliable way. When we dove into it, we found

[GitHub] cloudstack pull request: use directIO flags when dd'ing template

2014-12-15 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/58 use directIO flags when dd'ing template This makes sure dom0 in xenserver doesn't get hammered when copying templates. It doesn't make sense to use the cache of dom0

[GitHub] cloudstack pull request: CLOUDSTACK-9122: latest credit entries sh...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1192#issuecomment-164125511 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-9122: latest credit entries sh...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1192#issuecomment-164125653 Jenkins error is unrelated to PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9086: ACS allows to create iso...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1188#issuecomment-164125758 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-9139 make zwps default when de...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1219#issuecomment-164125989 LGTM, I could still do all my deployments using Marvin. So, didn't test this feature but did prove the existing functionality still works. --- If your pr

[GitHub] cloudstack pull request: CLOUDSTACK-4374 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1222#issuecomment-164126939 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-9069: Newly added project is n...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1082#issuecomment-164127282 Hi @nitin-maharana thanks for the info! I built a new cloud and still have the issue that after creating a project it keeps loading forever (see image above

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1211#issuecomment-164129115 LGTM based on the below test. Original on current master: - create domain, account and login - create vpc - create acl - no option to

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164132726 @syed Thanks! @bhaisaab @DaanHoogland Do you guys know why this was put in? It was in the original source import years ago. --- If your project is

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1227 Show actual diff in commits after merge with git-pr / git-fwd-merge This shows the diff in commits after using `git-pr` and `git-fwd-merge` tools, like this: ``` 44e8c92 Merge

[GitHub] cloudstack pull request: CLOUDSTACK-9135 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1221#issuecomment-164137434 LGTM based on running the tests: ``` [root@cs1 integration]# cat /tmp//MarvinLogs/test_internal_lb_SFTBEY/results.txt Test create, assign

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164138076 Example of merging PR 1221: https://cloud.githubusercontent.com/assets/1630096/11761460/05e97f22-a0c4-11e5-8c4a-da8cf67c973e.png";> ---

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-12 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1199#discussion_r47431233 --- Diff: test/integration/testpaths/testpath_snapshot_limits.py --- @@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self

[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-12 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1199#discussion_r47431243 --- Diff: test/integration/testpaths/testpath_snapshot_limits.py --- @@ -358,3 +362,129 @@ def test_01_storage_snapshots_limits(self

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164146123 Ping @wilderrodrigues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1196#issuecomment-164151105 Nice find @DaanHoogland Can you please fix this @SudharmaJain ? Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163586 Thanks for the quick fix @wilderrodrigues. Bit explanation: redundant routers worked fine in our 4.7 cloud, then all of a sudden were broken. Root

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164163749 You can read the following from man keepalived.conf: ``` # arbitary unique number 0..255 # used to differentiate multiple instances of vrrpd

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164170412 @bhaisaab nice suggestion! Not sure if it is needed though. The vrrp is done over the first guest network, so it cannot clash with other router pairs. Other

[GitHub] cloudstack pull request: CLOUDSTACK-9150: Remove docs/.tx/config

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1229#issuecomment-164170453 Ping @milamberspace to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Removed cloud-cli folder and contents, as...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1228#issuecomment-164170827 LGTM based on the above tests. Makes no sense to run the same tests again :-) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164171363 Jenkins error unrelated to PR change: ``` Build timed out (after 120 minutes). Marking the build as aborted. ``` --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164172595 First test results: keepalived.conf looks as expected: ``` vrrp_instance inside_network { state EQUAL interface eth2

[GitHub] cloudstack pull request: CLOUDSTACK-9146: Refactor Hypervisor KVM ...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1224#issuecomment-164174058 LGTM based on these tests (run on KVM): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true

[GitHub] cloudstack pull request: CLOUDSTACK-9147: In hypervisor-plugin-kvm...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1225#issuecomment-164174234 @borisroman I can't get it to run. It builds but after start it errors out like this: ``` 2015-12-12 10:01:33,843

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1209#issuecomment-164174368 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1212#issuecomment-164174462 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164176585 @DaanHoogland Thanks. Deploying to a real cloud as we speak. Will verify there too. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164177507 Update: Verified the same as above in our pre-production environment (aka Employee Cloud). Will now deploy to production as it works as expected. When the

[GitHub] cloudstack pull request: CLOUDSTACK-9151 - As a Developer I want t...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1231#issuecomment-164186662 Update: this resolved our production problem. It now works fine in master+this PR. LGTM :+1: --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Updating pom.xml version numbers for rele...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1186#issuecomment-164190196 Have discussed the upgrade paths with @DaanHoogland We are implementing them as we speak. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: 4.6.2 -> 4.7.0 upgrade does not use any s...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1233#issuecomment-164194791 As discussed, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: L10N update before 4.7.0 RC1

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1217#issuecomment-164201764 @milamberspace Are we good to merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1235 CLOUDSTACK-9155 make sure logrotate is effective for cloud.log Many processes on the VRs log to cloud.log. When log rotate kicks in, the file is rotated but the scripts still write to the

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164247329 Pinging @wilderrodrigues @fborn @DaanHoogland @borisroman to review. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164253007 @DaanHoogland There are many different solutions in place, some are bash/python scripts that do `>/var/log/cloud.log` etc, some use `nohup` to keep running

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164254871 Before PR this was seen after log rotate: ``` root@r-996-VM:/etc# lsof | grep cloud.log.1 _plutorun 767 root 3w REG 202,10 26054919 71 /var/log

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438 The new script ends up on the router: ``` root@r-15-VM:~# cat /etc/logrotate.d/cloud # Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-16428 Ping @bhaisaab any chance to get this reviewed today? ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9155 make sure logrotate is ef...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1235#issuecomment-164258629 Integration tests make no real sense, but tried a few to be sure: ``` Check the password file in the Router VM ... === TestName

[GitHub] cloudstack pull request: CLOUDSTACK-9153: When negative credits ar...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1234#issuecomment-164288018 For the sake of it, I run a some generic integration tests and they are happy. ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164288191 @borisroman @DaanHoogland Let's ask someone to test whether HyperV is still happy and then we'll know. --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1239 build_asf.sh: fix debian changelog altering The script already adds a new entry so we shouldn't replace the previous one. That is done only in the next version script.

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164291346 @borisroman we should separate it from the CloudStack repo ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack-docs-rn pull request: 4.7.0

2015-12-14 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack-docs-rn/pull/27#issuecomment-164388952 - Quota plugin, see PR 768 for screenshots. - Nicira and Nuage plugins updated - UI improvements - >100 smaller bugfixes and improveme

[GitHub] cloudstack-docs-rn pull request: 4.7.0

2015-12-14 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack-docs-rn/pull/27#discussion_r47476361 --- Diff: source/upgrade/_sysvm_templates_pre45.rst --- @@ -18,8 +18,9 @@ Update System-VM templates

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-165060510 Ping @sspans @wilderrodrigues to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-16 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1249 CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh Added quotes to prevent syntax errors in weird situations. Error seen in mgt server: ``` 2015-12-15 14:30:32,371

[GitHub] cloudstack pull request: [4.7.0/master] DB Paths fixes: 4.5.3->4.7...

2015-12-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1247#issuecomment-165061200 @bhaisaab Thanks for fixing / improving this. Will have a look and test it. Are you OK with handling this in 4.7.1 (due in say 2 weeks)? By that time 4.5.3 is

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-16 Thread remibergsma
Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1249#discussion_r47776850 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/checkrouter.sh --- @@ -17,21 +17,20 @@ # under the License. STATUS=UNKNOWN

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-18 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-165892090 Integration tests are OK: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

2015-12-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1230#issuecomment-166087210 @andrijapanic Merge without testing and LGTMs? Really? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

2015-12-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1258#issuecomment-166112617 @nitin-maharana Thanks. Are there any other api calls that have the same issue? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Set version 4.6.3-SNAPSHOT in 4.6 branch

2015-12-21 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1265 Set version 4.6.3-SNAPSHOT in 4.6 branch - setnextversion.sh - upgrade path Build succeeds: ``` [INFO

[GitHub] cloudstack pull request: Set version 4.6.3-SNAPSHOT in 4.6 branch

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1265#issuecomment-166305178 @rafaelweingartner True story, the faster we release versions the harder it becomes. It needs to be changed, preferably in a tool outside of CloudStack. We

[GitHub] cloudstack pull request: Set version 4.6.3-SNAPSHOT in 4.6 branch

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1265#issuecomment-166311506 And it works: ``` INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] (main:null) Running system integrity checker com.cloud.upgrade.DatabaseUpgradeChecker

[GitHub] cloudstack pull request: Set version 4.7.1-SNAPSHOT in 4.7 branch

2015-12-21 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1267 Set version 4.7.1-SNAPSHOT in 4.7 branch - setnextversion.sh - upgrade path Build succeeds: ``` [INFO

[GitHub] cloudstack pull request: Critical VPCVR issues fixed: CLOUDSTACK-9...

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1259#issuecomment-166401238 Hey @wilderrodrigues that's awesome! Would you mind pointing this PR to the 4.7 branch? I created it today and it finally got mirrored :-) --- If your pr

[GitHub] cloudstack pull request: Set version 4.7.1-SNAPSHOT in 4.7 branch

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1267#issuecomment-166405759 Tested an upgrade from `4.7.0` to `4.7.1` and that works: ``` INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) DB version = 4.7.0 Code

[GitHub] cloudstack pull request: Set version 4.7.1-SNAPSHOT in 4.7 branch

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1267#issuecomment-166407342 @DaanHoogland Jenkins failed, seems not related to PR. Is this y our experiment? ``` FATAL: Unable to find coverage results java.io.IOException

[GitHub] cloudstack pull request: Set version 4.7.1-SNAPSHOT in 4.7 branch

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1267#issuecomment-166407832 Once this is merged (and fwd-merged to master, I will create the upgrade paths for `4.8`. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Set version 4.8.0-SNAPSHOT in master bran...

2015-12-21 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1268 Set version 4.8.0-SNAPSHOT in master branch - setnextversion.sh - upgrade path to `4.8.0` via `4.7.0` -> `4.7.1` as this is the one set in `4.7` branch. Then we also have the n

[GitHub] cloudstack pull request: Set version 4.8.0-SNAPSHOT in master bran...

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1268#issuecomment-166436615 @pdube Indeed, as we speed up releases this becomes a real bottleneck. We should handle db upgrades out of the repo. There was some discussion already. Let&#

[GitHub] cloudstack pull request: Set version 4.8.0-SNAPSHOT in master bran...

2015-12-21 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1268#issuecomment-166437027 Tested upgrade, works fine: ``` INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Grabbing lock to check for database upgrade. INFO

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-166871427 @michaelandersen Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1249#issuecomment-166871327 @mandersen Can you review this please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268 @pvr9711 Please make sure we have 2xLGTM of which at least one run the test. Will not merge without. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-166881123 @koushik-das Github cannot display large diffs. This is how you can show it on your local checkout: ``` prId=1277 git checkout master git

[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594 @bhaisaab Thanks, makes sense. Will test an upgrade and report back. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/384#issuecomment-166888535 It was not merged, see also #720. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/869#issuecomment-166888961 @pvr9711 Where is your LGTM based on? I'd like to see some background, as otherwise we don't know what you tested / reviewed. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167148441 Nice work guys! @nvazquez This will be merged to master, which is now at `4.8.0-SNAPSHOT`. Can you please rebase with master, and move your SQL change

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-24 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-167155923 @DaanHoogland Jenkins failed due to this (missing artifact). Any hint on the cause? ``` Archiving artifacts ERROR: No artifacts found that match the

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

2015-12-28 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1290 CLOUDSTACK-9202 Bump ssh timeout for VR commands It seems the VR needs more time for some of its commands. Until we figured out the root cause, this allows the VRs to start again

  1   2   3   4   5   6   7   8   9   10   >