Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438
  
    The new script ends up on the router:
    
    ```
    root@r-15-VM:~# cat /etc/logrotate.d/cloud 
    # Licensed to the Apache Software Foundation (ASF) under one
    # or more contributor license agreements.  See the NOTICE file
    # distributed with this work for additional information
    # regarding copyright ownership.  The ASF licenses this file
    # to you under the Apache License, Version 2.0 (the
    # "License"); you may not use this file except in compliance
    # with the License.  You may obtain a copy of the License at
    # 
    #   http://www.apache.org/licenses/LICENSE-2.0
    # 
    # Unless required by applicable law or agreed to in writing,
    # software distributed under the License is distributed on an
    # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    # KIND, either express or implied.  See the License for the
    # specific language governing permissions and limitations
    # under the License.
    /var/log/cloud.log {
            rotate 4
            daily
            size 10M
            missingok
            notifempty
            compress
            delaycompress
            # CLOUDSTACK-9155: We cannot tell the processes that are writing to 
this
            # file to use the new inode, so instead we copy the original file, 
truncate
            # it and keep the same inode.
            copytruncate
    }
    ```
    
    Truncated list of processes that have `cloud.log` open:
    ```
    apache2   3636 3686 www-data    3w      REG             254,10   264891     
    59 /var/log/cloud.log
    apache2   3636 3687 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3688 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3689 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3690 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    conntrack 3837          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3851          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3852          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3853          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutorun 4141          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    logger    4142          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutorun 4145          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutoloa 4146          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    xl2tpd    4203          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    1w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    2w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    python    4229          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    update_co 4927          root    3r      REG             254,10   265499     
    59 /var/log/cloud.log
    ```
    
    Force logrotate:
    ```
    logrotate /etc/logrotate.conf -f
    ```
    
    Same processes, they still have `cloud.log` open (instead of `cloud.log.1`)
    ```
    apache2   3636 3686 www-data    3w      REG             254,10   264891     
    59 /var/log/cloud.log
    apache2   3636 3687 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3688 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3689 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    apache2   3636 3690 www-data    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    conntrack 3837          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3851          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3852          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    keepalive 3853          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutorun 4141          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    logger    4142          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutorun 4145          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    _plutoloa 4146          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    xl2tpd    4203          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    1w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    2w      REG             254,10   265499     
    59 /var/log/cloud.log
    passwd_se 4225          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    python    4229          root    3w      REG             254,10   265499     
    59 /var/log/cloud.log
    update_co 4927          root    3r      REG             254,10   265499     
    59 /var/log/cloud.log
    ```
    
    Deploying this to our clouds running 4.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to