GitHub user remibergsma opened a pull request:

    https://github.com/apache/cloudstack/pull/152

    KVM: make sure sync cannot block reboot

    The recent discussed improvement has the risk that if 'sync' hangs, the 
reboot may be delayed in the same way as the 'reboot' command would do. To work 
around, we're adding a 5 second timeout. If it cannot sync in 5 seconds, it 
will not succeed anyway and we should proceed the reset.
    
    @snuf: As a future improvement: Could we use your OVM3 heartbeat script for 
other hypervisors as well? One way to do it seems like a nice idea :-)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remibergsma/cloudstack master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #152
    
----
commit 7bce656b409f6bc0e18fe963cfeb9c2134b095be
Author: Remi Bergsma <git...@remi.nl>
Date:   2015-04-09T10:18:21Z

    make sure sync cannot block reboot
    
    The recent discussed improvement has the risk that if 'sync' hangs, the 
reboot may be delayed in the same way as the 'reboot' command would do. To work 
around, we're adding a 5 second timeout. If it cannot sync in 5 seconds, it 
will not succeed anyway and we should proceed the reset.
    
    @snuf: Could we use your OVM3 heartbeat script for other hypervisors as 
well? One way to do it seems like a nice idea :-)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to