Can't we output a proper message (missing OR incorrect config) while skipping
the test?
On 01-Oct-2015, at 2:56 PM, Miguel Ferreira
wrote:
> Hi Raja,
>
> I don’t agree with what you propose.
> I do understand your intention is to be able to run all tests and skip the
> ones you don’t have a
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-146079758
@remibergsma +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-151047344
Changes LGTM. I haven't tested it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151091001
Since a8212d9 changed names from "xen" to "xenserver", shouldn't the change
be to rename the files s3xen to s3xenserver and swif
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/970#issuecomment-151092704
Ping @runseb.
Is there a handle/userid for Tim Mackey?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1021
CLOUDSTACK-8485: listAPIs are taking too long to return results
- Removed regex. based search/replace of sensitive data on API response
introduced as part of commit
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-152971700
I have tried to look for the existing API response objects based on some
keyword search for sensitive fields. Please let me know if some response
objects are
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-152996985
registerUserKeys log based on this change
2015-11-02 17:15:19,061 INFO [a.c.c.a.ApiServer]
(2001334745@qtp-678426242-0:ctx-608cad64 ctx-6e00b6fc
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153001614
Jenkins build failed with the following error. I saw some other PRs with
the same failure. So looks like some random issue.
[ERROR] SLF4J: Class path
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153327157
@bhaisaab What are your reasons for saying that @LogLevel(Log4jLevel.Off)
is inappropriate?
By sensitive param/annotation are you referring to the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153337620
@DaanHoogland @bhaisaab I also couldn't find any annotation on API fields
for this. So ended up using the LogLevel which is also used in the agent
com
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1029#discussion_r43844351
--- Diff: server/src/com/cloud/configuration/Config.java ---
@@ -672,6 +672,7 @@
"86400",
"The inter
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1029#discussion_r43844404
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -420,3 +420,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1019#issuecomment-153579131
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1007#discussion_r43845446
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1003#issuecomment-153603199
@bhaisaab I think from the UI same value is passed for both name and
display name. But if you use the API you can pass different values. The 'name'
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153686114
@DaanHoogland @bhaisaab requestHasSensitiveInfo/responseHasSensitiveInfo
can be removed once this PR is accepted. I don't see any other use of these
param
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153690547
@DaanHoogland I think LogLevel is a better/generic name to suppress a field
from getting logged. Currently only sensitive field is getting annotated with
it
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-153695015
@bhaisaab Agree that the existing JSON and XML serialization can be
improved but it is better to do it as a separate PR. For JSON, the standard
Gson library is
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43996031
--- Diff:
api/src/org/apache/cloudstack/api/response/SSHKeyPairResponse.java ---
@@ -40,6 +42,7 @@
@SerializedName("finger
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43996196
--- Diff: api/src/org/apache/cloudstack/api/response/SslCertResponse.java
---
@@ -38,6 +40,7 @@
@SerializedName
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43996309
--- Diff: api/src/org/apache/cloudstack/api/response/UserVmResponse.java ---
@@ -256,6 +259,7 @@
@SerializedName
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43996820
--- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
@@ -27,30 +29,40 @@
import com.google.gson.GsonBuilder
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43997043
--- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
@@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-154025365
@DaanHoogland About the issue you pointed out in com.cloud.vm.VmWorkStart
serialization. Nice find but these are already existing issues. They surely
needs
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-154030678
@DaanHoogland That's right. I had already mentioned about the agent
commands in one of my previous comments
---
If your project is set up for it, yo
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-154035894
@DaanHoogland If you look at ApiResponseGsonHelper.java in this PR there
are GSon builders
private static final GsonBuilder s_gBuilder;
private
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-154971789
@DaanHoogland Updated based on our discussion last week
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Congrats Boris!
-Original Message-
From: Rajani Karuturi [mailto:raj...@apache.org]
Sent: Monday, 9 November 2015 12:02 PM
To: dev@cloudstack.apache.org
Subject: [ANNOUNCE] New committer: Boris Schrijver
The Project Management Committee (PMC) for Apache CloudStack has asked Boris
Schrij
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-158336847
@DaanHoogland did you get a chance to test it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r45450911
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceData.java
---
@@ -0,0 +1,289 @@
+package
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1086#issuecomment-158346095
@ustcweizhou Some questions.
1. Is updateVmNicIp API admin only?
2. How the caller knows if the IP address is available and what is the CIDR
associated
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1021#issuecomment-158366425
@DaanHoogland I have force pushed again. Hopefully a good jenkins slave
will pick this up :)
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1069#issuecomment-158375503
LGTM based on the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1167
CLOUDSTACK-9105: Logging enhancement: Handle/reference to track API câ¦
â¦alls end to end in the MS logs
Added logid to logging framework, now all API call logs can be tracked
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1167#issuecomment-161897298
Now all logs related to an operation can be traced by running something
like "grep logid:62314271 ".
Sample logs
2015-12-02 12:40:27
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1172
CLOUDSTACK-9107: Description of global config agent.load.threshold anâ¦
â¦d the actual behavior are not in sync
Made configuration parameter description and behavior in sync
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1172#discussion_r46670189
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java
---
@@ -1411,14 +1411,12 @@ protected void runInContext
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162418800
LGTM based on code changes.
@bhaisaab Since VpcVirtualNetworkApplianceManager is derived from
VirtualNetworkApplianceManager, start() call on both
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1140#issuecomment-162468306
Actually I was looking at the history and this is what I found. This was
originally fixed with commit
commit e444a03819ccf72f61cb04e8428d20cc65b145e1
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/1200
CLOUDSTACK-9130: Make RebootCommand similar to start/stop/migrate ageâ¦
â¦nt commands w.r.t. "execute in sequence" flag
RebootCommand now behaves in the same way as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-163166411
As part of this noticed that RebootRouterCommand is obsolete, will create a
separate PR for removing that once this is accepted.
---
If your project is set up
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1200#discussion_r47190062
--- Diff: core/src/com/cloud/agent/api/RebootCommand.java ---
@@ -19,29 +19,25 @@
package com.cloud.agent.api;
-import
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1213#issuecomment-163674707
@remibergsma Can domain admin1 delete gateway created by domain admin2? If
the existing code is properly handling these scenarios then fine.
---
If your
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/550
GitHub master
Patch for CLOUDSTACK-8603. Refer to the bug for details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/koushik-das
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/551
CLOUDSTACK-8603: Random list VM failures at scale (more than 1000 VMsâ¦
â¦) when VM has resource tags
There is no 'removed' field on the resource_tags table. So 'id
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/550#issuecomment-117765057
Discarding this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Congrats Wilder!
-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: Wednesday, 1 July 2015 22:43
To: dev
Subject: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack
The Project Management Committee (PMC) for Apache CloudStack are pleased to
announce
On 01-Jul-2015, at 4:44 PM, Rohit Yadav wrote:
>
>> On 01-Jul-2015, at 12:31 pm, Koushik Das wrote:
>>
>> I like the concept of quota. But I am thinking whether this should be a core
>> part of CS or developed as a plugin.
>
> It will be a separate plugin,
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/553
CLOUDSTACK-8606: DB performance impacted due to VM sync.
VM sync. generates a lot of queries on vm_instance table with
'instance_name' as filter. Since the field is not
inde
Congrats Karen!
-Original Message-
From: John Burwell [mailto:john.burw...@shapeblue.com]
Sent: Thursday, 2 July 2015 23:45
To: dev@cloudstack.apache.org
Cc: Karen Vuong
Subject: [ANNOUNCE] Karen Voung as a new PMC member of CloudStack
All,
The Project Management Committee (PMC) for Apa
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/557#issuecomment-118248923
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/571
CLOUDSTACK-8623: CPVM fails to start after MS is restarted during itsâ¦
⦠initial start-up process
If SSVM cannot be started then the existing entry is removed and a new SSVM
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/571#issuecomment-120903118
@karuturi @DaanHoogland Added unit tests for CPVM allocation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/571#issuecomment-121133952
Although RAT build status is showing ABORTED, the report is clean. Also the
build failed due to some random test failure. Since travis is green, I am going
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/573#issuecomment-121137019
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/578#issuecomment-121138178
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/571#issuecomment-121138730
Manually closing PR. I did a rebase to do away with unnecessary merge
commit.
---
If your project is set up for it, you can reply to this email and have your
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/584#issuecomment-121183714
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
For bug fixes I feel 1 LGTM should be fine provided there is a Jira ticket with
all details and the request is pending for more than a specified time (may be 7
days). For new features the existing process should be fine.
-Original Message-
From: Wido den Hollander [mailto:w...@widodh.nl]
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/600#discussion_r34867930
--- Diff:
framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
---
@@ -108,7 +107,7 @@ public void scan
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34870126
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/600#issuecomment-15132
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34873680
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34877501
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/599#issuecomment-122242828
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
will give it some attention and reopen it.
>>
>> Cheers,
>> Wilder
>>
>>
>> > On 14 Jul 2015, at 14:23, Koushik Das wrote:
>> >
>> > For bug fixes I feel 1 LGTM should be fine provided there is a Jira
>> ticket with all details an
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/607
CLOUDSTACK-8651: [Browser Based Upload Template] Partially uploaded tâ¦
â¦emplates doesn't get cleaned up after the SSVM handling it is destroyed
Fixed template sync co
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/607#issuecomment-122836717
Test browser based incomplete template upload, followed by SSVM destroy.
Template should go to UploadAbandoned state and get cleaned up. ... ===
TestName
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/611
CLOUDSTACK-8655: [Browser Based Upload Volume] Partially uploaded volâ¦
â¦umes are not getting destroyed as part of storage GC
As part of volume sync, that runs during of SSVM
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/611#issuecomment-123227873
Test browser based incomplete volume upload, followed by SSVM destroy.
Volume should go to UploadAbandoned/Error state and get cleaned up. ... ===
TestName
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/610#issuecomment-123232196
Changes look good. Not sure what "dead local store" mean.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/610#issuecomment-123272585
@DaanHoogland Thanks for the information.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
-1 to dropping pre-4.x upgrade code. If possible we should suppress the old
upgrade files from coverity scan.
Reasons:
There may be users on pre-4.x versions.
Removing a functionality should be associated with proper documentation and an
advanced notification in some prior releases. This is simi
+1
On 22-Jul-2015, at 2:44 PM, Kishan Kavala wrote:
> I would like to add CoreOS as a supported OS type to cloudstack.
> CoreOS vms can be created even now by selecting OS type as "Other". There are
> cloud providers supporting CoreOS offerings in production already.
> By making the changes men
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291227
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -36,6 +36,8 @@
private static
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291585
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292477
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292541
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292608
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293493
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293580
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293652
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java
---
@@ -0,0 +1,233 @@
+// Licensed to the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-123998336
Once the comments are addressed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/607#discussion_r35300288
--- Diff: test/integration/component/test_browse_templates.py ---
@@ -1674,6 +1674,42 @@ def
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/621
CLOUDSTACK-8666: Put host in Alert state only after alert.wait timeout
Instead of putting the host to Alert state immediately, the investigators
should be allowed to run for some time based
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-124357139
Merging it as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/622#issuecomment-124484710
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/607#issuecomment-125091277
Need one more LGTM. Anyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-125152445
@DaanHoogland Writing an unit test for changes in AgentManagerImpl.java is
hard due to the way the method gets invoked. Let me know if you have any
suggestion
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/621#issuecomment-125156829
@wilderrodrigues Agree that refactoring the code might help with the tests.
But that will be a bigger effort.
---
If your project is set up for it, you can
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/607#issuecomment-125157246
@DaanHoogland Are you running some private simulator test? If so is it done?
---
If your project is set up for it, you can reply to this email and have your
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/624
Unit tests for HA manager investigate method. Refer to CLOUDSTACK-866â¦
â¦6 for the code chenges
You can merge this pull request into a Git repository by running:
$ git pull https
Github user koushik-das closed the pull request at:
https://github.com/apache/cloudstack/pull/624
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/624#issuecomment-125470801
Already merged, looks like bot is not closing PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/626#discussion_r35620265
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/626#discussion_r35628826
--- Diff: debian/rules ---
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
# -*- makefile -*-
-VERSION := $(shell mvn
org.apache.maven.plugins:maven
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/607#issuecomment-125573161
@DaanHoogland I will create a separate test file with new the test case for
now. Once the issues in test_browse_templates.py are fixed, will merge it back
later
401 - 500 of 926 matches
Mail list logo
