Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1021#discussion_r43997043
  
    --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
    @@ -71,4 +83,19 @@ public boolean shouldSkipField(FieldAttributes f) {
                 return false;
             }
         }
    +
    +    private static class LogExclusionStrategy extends 
ApiResponseExclusionStrategy implements ExclusionStrategy {
    --- End diff --
    
    The existing LoggingExlusionStrategy is for agent commands/workjob etc. But 
it won't work for API responses. If you look at the code, exclusion strategy 
for API response log depends on ApiResponseExclusionStrategy as well for 
exclusion based on roles - user/admin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to