Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1021#discussion_r43996820
--- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
@@ -27,30 +29,40 @@
import com.google.gson.GsonBuilder;
/**
- * The ApiResonseGsonHelper is different from ApiGsonHelper - it
registeres one more adapter for String type required for api response encoding
+ * The ApiResonseGsonHelper is different from ApiGsonHelper - it registers
one more adapter for String type required for api response encoding
--- End diff --
I have to read more on the gson changes you are referring to. But I think
we shouldn't mix multiple things with this. The primary purpose of this PR is
to fix the perf. issue in list API responses.
There may be some rework if gson is upgraded but it is better to do that
when gson upgrade work is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
