Review Request 13627: Fix for CLOUDSTACK-3441

2013-08-17 Thread Koushik Das
checking if the network is already implemented or shutdowned outside the lock. Diffs - server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f Diff: https://reviews.apache.org/r/13627/diff/ Testing --- Thanks, Koushik Das

Re: Review Request 13627: Fix for CLOUDSTACK-3441

2013-08-17 Thread Koushik Das
part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock. Diffs (updated) - server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f Diff: https://reviews.apache.org/r/13627/diff/ Testing --- Thanks, Koushik Das

Re: [ANNOUNCE] New Committer: Toshiaki Hatano

2013-08-20 Thread Koushik Das
Congrats Toshiaki! On 20-Aug-2013, at 4:26 AM, Marcus Sorensen mailto:shadow...@gmail.com>> wrote: Toshiaki

RE: Unable to create volume - volume size xxxx, but the maximum size allowed is 0 Gb.

2013-08-21 Thread Koushik Das
In 4.2 branch it gets initialized from config property "storage.max.volume.size". Storage DEFAULT management-server storage.max.volume.size 2000The maximum size for a volume (in GB). Which branch are you in? Master. Maybe some missing commit in master. > -Original Message- > F

Re: [BUG] vSphere - VMs are force powered off by ACS

2013-08-26 Thread Koushik Das
During MS restart as part of host connect, vm sync happens. This may be stopping VMs if there is a mismatch in actual state and what is present in the database. Do you see anything useful in the MS logs? -Koushik On 27-Aug-2013, at 4:20 AM, "Musayev, Ilya" wrote: > I've been trying to figur

Re: Review Request 13842: CLOUDSTACK-4482: getVMPassword() API call does not return password for Vms that are deployed with password enabled templates.

2013-08-27 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13842/#review25612 --- Ship it! Ship It! - Koushik Das On Aug. 27, 2013, 10:53 a.m

Re: New Committer: Daan Hoogland

2013-08-28 Thread Koushik Das
Congrats Daan! On 28-Aug-2013, at 7:28 PM, Chip Childers wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Daan Hoogland to become a committer and we are pleased to > announce that he has accepted! > > Daan's been quite active on the dev list, working on not just

Re: [ANNOUNCE] New Committer: Ian Duffy

2013-08-28 Thread Koushik Das
Congrats Ian! On 28-Aug-2013, at 12:42 AM, Sebastien Goasguen wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Ian Duffy to become a committer and we are pleased > to announce that he has accepted. > > Being a committer enables easier contribution to the > proje

Re: [ANNOUNCE] New Committer: Kirk Kosinski

2013-08-28 Thread Koushik Das
Congrats Kirk! On 28-Aug-2013, at 7:46 PM, Prasanna Santhanam wrote: > The Project Management Committee (PMC) for Apache CloudStack has asked Kirk > Kosinski to become a committer and we are pleased to announce that he has > accepted. > > For those who aren't on the users@ list and/or on IRC in

Optimize code for scale

2013-08-28 Thread Koushik Das
Recently I worked on some performance related issues and noticed a pattern in the code that lead to increased latency for some APIs in a scaled up environment (> 10K user VMs, > 10K hosts). The pattern is like this: List hosts = listHosts(); // based on some filter for (Host h : hosts) { //

Re: [ANNOUNCE] New Committer: Dave Cahill

2013-09-07 Thread Koushik Das
Congrats Dave! On 07-Sep-2013, at 7:50 AM, Marcus Sorensen wrote: > The Project Management Committee (PMC) for Apache CloudStack > has asked Dave Cahill to become a committer and we are pleased > to announce that he has accepted. > > Dave has been an active member of the community for quite awh

Primary store (PS) failure/outage

2013-09-16 Thread Koushik Das
Currently the way Cloudstack deals with PS failure is to reboot all hosts associated with the cluster. Selectively cleaning up the affected VMs would have been the best option, but since issues were seen with stopping VMs on the hypervisors (at least in Xenserver 5.6 [1]) reboot was the next opt

RE: [DISCUSS] Integrate Cisco ASA 1000v into CloudStack

2013-03-21 Thread Koushik Das
ctionality (via VR or VPX) would be > supported in 4.2 or not? > > Regards, > Manan Shah > > > > > On 3/19/13 5:00 AM, "Koushik Das" wrote: > > >Inline > > > >> > >> On 18/03/13 7:37 PM, "Sailaja Mada" wrote: > &g

DeployVM not working in Vmware

2013-03-21 Thread Koushik Das
With latest master while trying to launch a VM in Vmware getting the following error. In case of Vmware the PremiumSecondaryStorageResource.java is used to handle the copying of template from secondary to primary. So looks like somehow this is not getting loaded. I checked CLOUDSTACK-1252, looks

RE: New committer: Ahmad Emneina

2013-03-25 Thread Koushik Das
Congratulations Ahmad. > -Original Message- > From: Joe Brockmeier [mailto:j...@zonker.net] > Sent: Monday, March 25, 2013 5:05 AM > To: dev@cloudstack.apache.org > Subject: New committer: Ahmad Emneina > > Hi all, > > The Project Management Committee (PMC) for Apache CloudStack has > as

RE: [DISCUSS] Hyper-V Plugin & Microsoft Compiler & IP Clearance

2013-03-26 Thread Koushik Das
Better to write the C# component doing Hyper-V specific stuff as a standalone component and expose a REST API. The ServerResource class is still in java and makes REST calls to the C# component. -Koushik > -Original Message- > From: Donal Lafferty [mailto:donal.laffe...@citrix.com] > Se

RE: [DISCUSS] Hyper-V Plugin & Microsoft Compiler & IP Clearance

2013-03-26 Thread Koushik Das
esource in the remote agent. > > With that in mind, do you mean for the C# component to be accessible over a > RESTful API from plugin classes loaded into the management server? > > DL > > > -Original Message- > > From: Koushik Das [mailto:koush

RE: New Committer: Ilya Musayev

2013-03-28 Thread Koushik Das
Congrats Ilya! > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Friday, March 29, 2013 12:06 AM > To: dev@cloudstack.apache.org > Subject: New Committer: Ilya Musayev > > The Project Management Committee (PMC) for Apache CloudStack has > asked Ilya Mus

RE: New Committer: Animesh Chaturvedi

2013-03-28 Thread Koushik Das
Congrats Animesh! > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, March 29, 2013 1:28 AM > To: dev@cloudstack.apache.org > Subject: New Committer: Animesh Chaturvedi > > The Podling Project Management Committee (PPMC) for Apache CloudStack > has aske

Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO

2013-04-01 Thread Koushik Das
he iso id in the newTemplateId parameter? - Koushik Das On March 6, 2013, 12:23 p.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

[MERGE] ASA 1000v as external firewall in isolated guest networks

2013-04-08 Thread Koushik Das
I would like to merge the feature "ASA 1000v as external firewall in isolated guest networks" to master. Please find the details here: Proposal: http://mail-archives.apache.org/mod_mbox/incubator-cloudstack-users/201301.mbox/%3ccd0b6bea.167bb%25manan.s...@citrix.com%3E FS: https://cwiki.apache.

RE: VXLANs and Cisco Nexus 1000v

2013-04-08 Thread Koushik Das
Currently VXLAN as an isolation mechanism using nexus 1000v is marked as an open item in [1]. If you are interested in doing it please feel free to pick it up. You have to implement a network guru for handling VXLAN. Refer to the existing VLAN implementation for details. -Koushik [1] https://c

RE: [Discuss] API name alias

2013-04-08 Thread Koushik Das
What happens when same alias gets used for different commands? I think even with the current mechanism for command name the problem exists i.e. two different commands can have the same name. And in that case how is it handled? > -Original Message- > From: Kishan Kavala [mailto:kishan.ka

RE: [DISCUSS] Don't assign tickets to people when triaging

2013-04-10 Thread Koushik Das
+1 to Abhi's suggestion. > -Original Message- > From: Abhinandan Prateek [mailto:abhinandan.prat...@citrix.com] > Sent: Thursday, April 11, 2013 8:40 AM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS] Don't assign tickets to people when triaging > > > > On 10/04/13 8:57 PM, "Jo

RE: [MERGE] ASA 1000v as external firewall in isolated guest networks

2013-04-11 Thread Koushik Das
9 PM > To: dev@cloudstack.apache.org > Subject: Re: [MERGE] ASA 1000v as external firewall in isolated guest > networks > > On Mon, Apr 08, 2013 at 01:08:42PM +, Koushik Das wrote: > > I would like to merge the feature "ASA 1000v as external firewall in > > isolated > guest

RE: Master broken

2013-04-12 Thread Koushik Das
There is already one https://cwiki.apache.org/confluence/display/CLOUDSTACK/Unit+Testing+101 and also https://cwiki.apache.org/confluence/display/CLOUDSTACK/Unit+Testing+with+JUnit+and+Spring Also you can look at the some of the existing unit tests. > -Original Message- > From: Rajesh B

RE: [MERGE] ASA 1000v as external firewall in isolated guest networks

2013-04-12 Thread Koushik Das
s > > On Fri, Apr 12, 2013 at 09:20:39AM -0400, Chip Childers wrote: > > On Fri, Apr 12, 2013 at 06:39:29AM +, Koushik Das wrote: > > > Currently there are no functional tests, did e2e tests manually. > > > There are some external setup that is required which then needs

RE: [MERGE] ASA 1000v as external firewall in isolated guest networks

2013-04-12 Thread Koushik Das
:55:56PM +0530, Prasanna Santhanam wrote: > > On Fri, Apr 12, 2013 at 09:20:39AM -0400, Chip Childers wrote: > > > On Fri, Apr 12, 2013 at 06:39:29AM +, Koushik Das wrote: > > > > Currently there are no functional tests, did e2e tests manually. > > > > The

RE: [MERGE] ASA 1000v as external firewall in isolated guest networks

2013-04-15 Thread Koushik Das
Added the required tests and merged to master -Koushik > -Original Message- > From: Koushik Das [mailto:koushik@citrix.com] > Sent: Friday, April 12, 2013 10:30 PM > To: dev@cloudstack.apache.org > Subject: RE: [MERGE] ASA 1000v as external firewall in isolated g

Firewall and LB network elements in inline mode

2013-04-15 Thread Koushik Das
The network orchestration component currently supports elements in a side-by-side mode. Compatible network elements can be used in this mode to offer various network services. There are also scenarios where an inline mode would be desirable. For e.g. firewall followed by LB. Wanted to check out

RE: Firewall and LB network elements in inline mode

2013-04-16 Thread Koushik Das
t for SRX + F5 big ip is already in. > > --Sheng > > > On Mon, Apr 15, 2013 at 10:07 AM, Chiradeep Vittal < > chiradeep.vit...@citrix.com> wrote: > > > Isn't this discussed here: > > https://cwiki.apache.org/confluence/x/ggjVAQ > > > >

RE: API naming conventions

2013-04-16 Thread Koushik Das
A fixed naming pattern with verb followed by noun looks good. If required the verbs can be categorized further like lifecycle verbs - create, delete etc. > -Original Message- > From: prasanna [mailto:srivatsav.prasa...@gmail.com] On Behalf Of > Prasanna Santhanam > Sent: Tuesday, April 16

RE: [PROPOSAL] [CLOUDSTACK-2056] DeploymentPlanner choice via ServiceOffering

2013-04-17 Thread Koushik Das
I have some comments inline > -Original Message- > From: Prachi Damle [mailto:prachi.da...@citrix.com] > Sent: Thursday, April 18, 2013 12:17 AM > To: dev@cloudstack.apache.org > Subject: RE: [PROPOSAL] [CLOUDSTACK-2056] DeploymentPlanner choice via > ServiceOffering > > Hi Nitin, > > Th

RE: [ACS42][QA]Review Request : CISCO ASA 1000v Firewall Integration Test Plan

2013-04-20 Thread Koushik Das
, April 19, 2013 5:09 PM To: dev@cloudstack.apache.org Cc: Koushik Das; Sailaja Mada Subject: [ACS42][QA]Review Request : CISCO ASA 1000v Firewall Integration Test Plan Hi, CISCO ASA 1000v Firewall Integration Test Plan : https://cwiki.apache.org/confluence/display/CLOUDSTACK/CISCO+ASA+Firewall

RE: New PMC Member: Prasanna Santhanam

2013-04-22 Thread Koushik Das
Congrats Prasanna! > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Monday, April 22, 2013 9:21 PM > To: dev@cloudstack.apache.org > Subject: New PMC Member: Prasanna Santhanam > > Hi folks > > The Project Management Committee (PMC) for Apache CloudSt

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread Koushik Das
erver/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11027/#comment42073> Again configDhcp, change it to correct name. - Koushik Das On May 10, 2013, 6:54 a.m., bharat kumar wrote: > > --

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-13 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20481 --- Ship it! Ship It! - Koushik Das On May 13, 2013, 9:34 a.m

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-13 Thread Koushik Das
> On May 13, 2013, 11:37 a.m., Koushik Das wrote: > > Ship It! Committed to master commit 052c24c4d1c881f791b804dbb9c2fc083af7da36 - Koushik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

RE: Firewall rule question

2013-05-14 Thread Koushik Das
> -Original Message- > From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] > Sent: Wednesday, May 15, 2013 10:29 AM > To: dev@cloudstack.apache.org; aemne...@gmail.com > Subject: RE: Firewall rule question > > For the createFirewallRule and createEgressFirewallRule APIs the p

RE: Firewall rule question

2013-05-14 Thread Koushik Das
> -Original Message- > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > Behalf Of Will Stevens > Sent: Wednesday, May 15, 2013 12:19 AM > To: dev@cloudstack.apache.org; aemne...@gmail.com > Subject: Re: Firewall rule question > > Ya, I am not sure. I am working off

RE: [ANNOUNCE] New committer: Devdeep Singh

2013-05-14 Thread Koushik Das
Congrats Devdeep! > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Tuesday, May 14, 2013 8:48 PM > To: dev@cloudstack.apache.org > Subject: [ANNOUNCE] New committer: Devdeep Singh > > The Project Management Committee (PMC) for Apache CloudStack has > a

RE: Firewall rule question

2013-05-14 Thread Koushik Das
he.org] > Sent: Wednesday, May 15, 2013 11:54 AM > To: dev@cloudstack.apache.org > Subject: Re: Firewall rule question > > On Wed, May 15, 2013 at 05:54:36AM +, Koushik Das wrote: > > > > > > > -Original Message- > > > From: williamste

RE: Firewall rule question

2013-05-15 Thread Koushik Das
> -Original Message- > From: Prasanna Santhanam [mailto:t...@apache.org] > Sent: Wednesday, May 15, 2013 12:25 PM > To: dev@cloudstack.apache.org > Subject: Re: Firewall rule question > > On Wed, May 15, 2013 at 06:43:44AM +, Koushik Das wrote: > > Pr

RE: Review Request: Added PlainTextAuthenticator

2013-05-16 Thread Koushik Das
Nice explanation Prasanna. +1 to Kishan's fix. > -Original Message- > From: Prasanna Santhanam [mailto:t...@apache.org] > Sent: Thursday, May 16, 2013 9:50 PM > To: dev@cloudstack.apache.org > Cc: Kishan Kavala > Subject: Re: Review Request: Added PlainTextAuthenticator > > On Thu, May 16

Re: [Proposal]CloudStack IAM plugin feature (CLOUDSTACK-5920)

2014-01-22 Thread Koushik Das
Some questions: - Is there a concept of generic permission (any action, any resource etc.)? There shouldn't be a need to define hundreds of explicit permissions for admin account. - I think it would be good to have a notion of parent policy. This will avoid duplication of permissions. - Can you

Re: Review Request 17233: Fix for Issue CLOUDSTACK-5875

2014-01-23 Thread Koushik Das
d1a master -> f999a01837e60f0c51ef0eb4ad19c29e43ca3037 - Koushik Das On Jan. 23, 2014, 10:27 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

VM instance view UI is broken in 4.3-forward

2014-01-27 Thread Koushik Das
I noticed that VM instance view is broken in UI. It works fine in 4.3 branch. It worked till commit d31fa09c7e5bb04fcc4594c0352d9b91171e9d1a. -Koushik

Re: VM instance view UI is broken in 4.3-forward

2014-01-27 Thread Koushik Das
The only UI related commit I see is 81a83b5b31f0a237ae56449c60350160915f28f8. List VM API is working fine. On 27-Jan-2014, at 2:26 PM, Koushik Das wrote: > I noticed that VM instance view is broken in UI. It works fine in 4.3 branch. > It worked till

4.3 cherry-pick request

2014-01-27 Thread Koushik Das
Animesh, Please cherry-pick the following commit to 4.3 Commit 3fae917ebefb56ba280c2e6c5b6ff0f1720d46ed in branch refs/heads/4.3-forward from Koushik Das<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=koushikd> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3

Re: [PROPOSAL] Introduce API returning you an answer from CloudStack storage/host allocators whethere there is enough resources for vm deployment

2014-02-03 Thread Koushik Das
As I understand this is a best-effort approach. Even if the proposed API returns YES, deployment may still fail. I personally feel that it is better to improve the deployVM API itself to return accurate error message rather than having multiple API calls. If the deployvm call call fails, it will

[PROPOSAL] List VM API enhancement

2014-02-06 Thread Koushik Das
Currently list VM can only be called using a single VM ID. So if there is a need to query a set of VMs using ID then either multiple list VM calls need to be made or all VMs needs to be fetched and then do a client side filtering. Both approaches are sub-optimal - the former results in multiple

Re: [PROPOSAL] List VM API enhancement

2014-02-06 Thread Koushik Das
ndan Prateek > wrote: >> +1, The listVM call is one of the most resource intensive call. Any step >> to optimise it are welcome. >> >> On 06/02/14 2:01 pm, "Koushik Das" wrote: >> >>> Currently list VM can only be called using a single VM I

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Koushik Das
ne. If you look at Amazon EC2 api, you will > notice that they are also using the similar convention, id parameter can > be one or more. > > Thanks > -min > > On 2/6/14 3:24 AM, "Koushik Das" wrote: > >> Yes it will be like a findByIds() and the one

Re: [PROPOSAL] List VM API enhancement

2014-02-07 Thread Koushik Das
i, you will notice that they are also using the similar convention, id parameter can be one or more. Thanks -min On 2/6/14 3:24 AM, "Koushik Das" mailto:koushik@citrix.com>> wrote: Yes it will be like a findByIds() and the one id case is just a special case for this. On

RE: [PROPOSAL] List VM API enhancement

2014-02-12 Thread Koushik Das
f course, we can never delete the ³ID² parameter just to satisfy >> the old convention, as this is the most used parameter :) >> >> I can see that several existing commands - archive/deleteAlerts are >> using ApiConstants.IDs parameter. We can mark IDs as deprecated, so >>

Re: [PROPOSAL] Storage OverProvisioning as Per Primary Basis

2014-02-14 Thread Koushik Das
Please add more details for upgrade scenario. Also can you give some examples as to how the capacity computation is done for operations where the volume gets migrated from one PS to another having different over provisioning factors. Is there any value add if you give this also at cluster scope?

Re: Primary storage maintenance doesn't trigger VM shutdown in 4.3

2014-02-17 Thread Koushik Das
For XS this works as expected. For system VMs (SSVM, CPVM) there is a monitoring thread to check if they are up and running. If not then it tries to bring them up. Now if there is no PS available then the deployment fails and it is tried again. This is expected. -Koushik On 15-Feb-2014, at 3:34

Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-02-23 Thread Koushik Das
t; What is the use case for null host id? Make it long instead of Long. - Koushik Das On Feb. 21, 2014, 11:36 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 17889: CLOUDSTACK-4762: Enabling vGPU support for XenServer.

2014-02-28 Thread Koushik Das
va <https://reviews.apache.org/r/17889/#comment66515> Same comments as in orchestrateStart() - Koushik Das On Feb. 27, 2014, 12:35 p.m., Sanjay Tripathi wrote: > > --- > This is an automatically gene

Re: ALARM - ACS reboots host servers!!!

2014-03-02 Thread Koushik Das
The primary storage needs to be put in maintenance before doing any upgrade/reboot as mentioned in the previous mails. -Koushik On 03-Mar-2014, at 6:07 AM, Marcus wrote: > Also, please note that in the bug you referenced it doesn't have a > problem with the reboot being triggered, but with the

Re: Build on 4.3-forward Fails: Shows Failure for Framework-Clustering

2014-03-02 Thread Koushik Das
I am facing a build failure but for a different reason on 4.3-forward. Looks like due to commit 065ac54bd7755cb44667c71311293c8f2110b3f3 Author: tuna Date: Sat Mar 1 11:36:27 2014 +0700 CLOUDSTACK-6162: add UI for OVS plugin [INFO] --

Re: Review Request 18616: added delete iso api to the simulator

2014-03-04 Thread Koushik Das
26d - Koushik Das On March 4, 2014, 5:55 a.m., Rajani Karuturi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apa

Re: Review Request 18680: added mock handlers for VpnUsersCfgCommand and RemoteAccessVpnCfgCommand in the simulator

2014-03-04 Thread Koushik Das
7f9 - Koushik Das On March 4, 2014, 5:56 a.m., Rajani Karuturi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apa

Re: Review Request 18352: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-05 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18352/#review36215 --- Ship it! Ship It! - Koushik Das On March 5, 2014, 8:50 a.m

Re: [DISCUSS] Checking in code that will break others' environments

2014-03-05 Thread Koushik Das
Before doing a git pull, I generally check the sql schema changes and run the delta manually on my existing setup. In most of the cases that works for me without having to redeploy the db. -Koushik On 06-Mar-2014, at 11:43 AM, Mike Tutkowski wrote: > Yeah, I definitely just meant a "heads up

DeployVM failing on master with NPE

2014-03-10 Thread Koushik Das
I am seeing the following exception ERROR [c.c.a.ApiServer] (38419149@qtp-1917357200-11:ctx-116b8207 ctx-9a54f764) unhandled exception executing api command: [Ljava.lang.String;@36d30b1d java.lang.NullPointerException at org.apache.cloudstack.engine.orchestration.CloudOrchestrator.creat

Re: DeployVM failing on master with NPE

2014-03-10 Thread Koushik Das
This is a new install using master. So this is not about db changes but mostly a bug. On 10-Mar-2014, at 9:58 PM, Marcus wrote: > Mike has sent out several emails about the DB changes he made. > > On Mon, Mar 10, 2014 at 5:28 AM, Koushik Das wrote: >> I am seeing the foll

Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-10 Thread Koushik Das
tion/smoke/test_deploy_vm.py 425aeb7 Diff: https://reviews.apache.org/r/19022/diff/ Testing --- Added integration test, also verified manually. Thanks, Koushik Das

Re: [PROPOSAL] List VM API enhancement

2014-03-10 Thread Koushik Das
little 'English' rules implied in using a programming language, like the > use of adjectives. They matter in Westerns languages and unless we define a > system wide set of different rules let's stick with English. > > kind regards, > > Daan Hoogland > > >

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das
lly exclusive. Also it is a valid scenario to not pass any of id or ids. - Koushik --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19022/#review36764 ------------

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-11 Thread Koushik Das
ids? > > You are being strict on something that isn't hurtful but an empty ids > > when no id is given is not checked! > > Koushik Das wrote: > I haven't removed 'id' due to back-compat. As I have mentioned 'id' and > 'ids

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-12 Thread Koushik Das
On 11-Mar-2014, at 7:24 PM, Daan Hoogland wrote: > You are saying it must be null and not empty? [Koushik] Yes. > > > On Tue, Mar 11, 2014 at 1:41 PM, Koushik Das wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.ap

Re: Review Request 18902: CLOUDSTACK-6211: Xenserver - HA - SSVM fails to start due to running out of management Ip ranges when testing host down scenarios

2014-03-12 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18902/#review37031 --- Ship it! Ship It! - Koushik Das On March 7, 2014, 11:04 a.m

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-13 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19022/#review37045 --- Ship it! Ship It! - Koushik Das On March 11, 2014, 6:29 a.m

Re: Review Request 19022: List VM enhancement to support querying with multiple VM IDs

2014-03-13 Thread Koushik Das
> On March 13, 2014, 12:19 p.m., Koushik Das wrote: > > Ship It! Commit 5779292e93fe52a7fb5ec0abffe1e3f6b9c10121 in cloudstack's branch refs/heads/master from [~koushikd] [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5779292 ] CLOUDSTACK-6052: List VM enhancem

Re: [20/31] git commit: updated refs/heads/distributedrouter to a8d43ba

2014-03-13 Thread Koushik Das
ommand=listVirtualMachines&listAll=true&ids=e >>>> ddac053-9b12-4d2e-acb7-233de2e98112,009966fc-4d7b-4f84-8609- >>>> 254979ba0134 >>>> The new parameter will be mutually exclusive with the existing 'id' >>>> parameter. >>>&g

Re: Review Request 19038: CLOUDSTACK-6090: Virtual Router Service Failure Alerting

2014-03-14 Thread Koushik Das
60c, f293c94bc0198f162c80ff807ca81459150354a5 - Koushik Das On March 14, 2014, 9:36 a.m., Harikrishna Patnala wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apa

Re: Review Request 19272: simulator manager impl changes to handle SetMonitorServiceCommand

2014-03-20 Thread Koushik Das
4.4 -> fc8cb754f0c6645bac5f35d8ad3d16e5e17a2d50 - Koushik Das On March 17, 2014, 5:33 a.m., Rajani Karuturi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-20 Thread Koushik Das
patch? - Koushik Das On March 5, 2014, 11:17 a.m., Saksham Srivastava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

[PROPOSAL] Simulator enhancements

2014-04-01 Thread Koushik Das
The current simulator provides a way to test various Cloudstack features without using actual resources. But its current capabilities are limited since it only allows success response for all agent commands and some ability to introduce delays. I am proposing some enhancements to the simulator [

Re: [PROPOSAL] Simulator enhancements

2014-04-01 Thread Koushik Das
shik] Yes. > 5. Is there an ability to simulate fault for a specific storage/host? For > example, I have 5 storages in my cluster but I want to simulate failure for 3 > of the storage pools. Is that possible? > [Koushik] Good point. I will add storage pool also into the scope. > >&g

Re: [PROPOSAL] Simulator enhancements

2014-04-02 Thread Koushik Das
ontrol the agent state as well? Say I want to test VM > HA, Can I be able to set the host status to be disconnected and then > verify that VM's on the host gets migrated? > > On 01/04/14 5:47 PM, "Koushik Das" wrote: > >> The current simulator provides a way

Re: Validating check-ins for your local changes, using Simulator

2014-04-03 Thread Koushik Das
Thanks for updating the wiki Santhosh. Also for any new feature adding agent commands, the simulator needs to be fixed as well. The integration tests added for new features should be run against simulator as well to ensure it is not broken. -Koushik On 03-Apr-2014, at 2:16 AM, Santhosh Edukulla

Re: Remove Mgmt Server

2014-04-10 Thread Koushik Das
+1 to the feature. On 11-Apr-2014, at 6:05 AM, Michael Phillips wrote: > I can create a JIRA request for this, but how many +1's do we need before it > gets added to the "To Do" list? > >> From: alex.hu...@citrix.com >> To: dev@cloudstack.apache.org >> Subject: RE: Remove Mgmt Server >> Date:

Re: Coding Standards Questions

2014-04-13 Thread Koushik Das
On 12-Apr-2014, at 2:14 AM, Alex Hitchins wrote: > Daan, > > Are you referring to keeping line lengths up to 80 characters? Sorry - tired > eyes. > > My thoughts were more that in a function there should only be one "return" > statement rather than many, all nested in layers of if/else stateme

Re: Review Request 20250: Fixed errors with simulator VM snapshot delete and revert

2014-04-15 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20250/#review40378 --- Ship it! Ship It! - Koushik Das On April 11, 2014, 2:37 a.m

RE: Unable to start instance on 4.3 using Simulator

2014-04-15 Thread Koushik Das
In 4.3 you need to set global config router.version.check to false to workaround this issue in simulator. This is fixed in 4.4/master by commit 38b8677e01fe1ec89df43abe9fac26295597080f. -Koushik -Original Message- From: David Grizzanti [mailto:david.grizza...@sungard.com] Sent: Wednesd

Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-04-16 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18768/#review40542 --- Ship it! Ship It! - Koushik Das On April 16, 2014, 10:14 a.m

Re: [PROPOSAL] Simulator enhancements

2014-04-18 Thread Koushik Das
rlier using simulator. On 01-Apr-2014, at 5:47 PM, Koushik Das wrote: > The current simulator provides a way to test various Cloudstack features > without using actual resources. But its current capabilities are limited > since it only allows success response for all agent commands an

Re: Anybody experienced test failure on master?

2014-04-18 Thread Koushik Das
'mvm clean install' worked for me. Are you trying noredist? On 18-Apr-2014, at 6:03 AM, Min Chen wrote: > Hi there, > > Did anybody experience test failure on master branch? I got this: > > > T E S T S > --- > Running com.cloud.utils.DbUtil

Re: [ACS44] 4.4-forward branch creation accident

2014-04-22 Thread Koushik Das
Daan, I am not seeing the commits that went to the previously created 4.4-forward branch in the new 4.4-forward branch. For e.g. https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8f2bf2 Are you going to merge all of them into 4.4-forward? -Koushik On 23-Apr-2014, at 2:53 AM, Mike Tutk

Re: [PROPOSAL] Simulator enhancements

2014-04-23 Thread Koushik Das
This is a document to help write tests using the new simulator mock framework. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Writing+tests+leveraging+the+simulator+enhancements On 18-Apr-2014, at 5:09 PM, Koushik Das wrote: > I have added this to master as part of com

Re: HypervisorType - possible feature idea

2014-04-24 Thread Koushik Das
Ideally the API and orchestration layers shouldn't have any HV specific code. You may have already seen that there are places in the code which checks if an operation is supported based on HV type like below. if (Vmware) throw ex All these checks should rely on hypervisor_capabilities table ins

Re: Review Request 20703: Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a cloudstack account

2014-04-28 Thread Koushik Das
rward, please create a new one. - Koushik Das On April 28, 2014, 10:23 a.m., Rajani Karuturi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: listVirtualMachine API With Name Parameter Set

2014-05-02 Thread Koushik Das
The name parameter is used in the sql query filter as "where name like ", so more than one can be returned. On 01-May-2014, at 8:16 PM, Matt Spurlin wrote: > Hi all, > I am looking at > CLOUDSTACK-6555. > I am wondering if the name paramete

How is this working?

2014-05-05 Thread Koushik Das
I came across this code snippet in hostConnect() method in DefaultHostListener.java. Look at the line where the used bytes is set on the poolVO. This looks like a serious bug. Looking at the history this code has been there since a year. Has anyone encountered any issues with primary storage ca

Re: How is this working?

2014-05-05 Thread Koushik Das
ki [mike.tutkow...@solidfire.com] >>>> Sent: Monday, May 05, 2014 9:12 PM >>>> To: dev@cloudstack.apache.org >>>> Subject: Re: How is this working? >>>> >>>> My storage plug-in actually uses a custom host listener, so I have not &g

Re: Review Request 21198: Added Fix for CLOUDSTACK-6648

2014-05-12 Thread Koushik Das
master, please create a new patch - Koushik Das On May 13, 2014, 5:19 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: seeing "Unknown parameters : ctxdetails" for addResourceDetail/removeResourceDetail

2014-05-13 Thread Koushik Das
I am seeing the same for many commands. So this is not specific to add/removeResourceDetail 2014-05-09 18:17:39,477 WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-24:job-28 ctx-6eaab5d7) Received unknown parameters for command updateNetworkServiceProvider. Unknown parameters : c

Re: Review Request 21197: Added port issue and user apiclient fix issue

2014-05-13 Thread Koushik Das
716 master -> e69a94b61ee160532d660165e8b715f0f3f83ea9 - Koushik Das On May 8, 2014, 9:49 a.m., Santhosh Edukulla wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

<    1   2   3   4   5   6   7   8   9   10   >