----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18352/#review36215 -----------------------------------------------------------
Ship it! Ship It! - Koushik Das On March 5, 2014, 8:50 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18352/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 8:50 a.m.) > > > Review request for cloudstack, Koushik Das and Prachi Damle. > > > Bugs: CLOUDSTACK-6151 > https://issues.apache.org/jira/browse/CLOUDSTACK-6151 > > > Repository: cloudstack-git > > > Description > ------- > > Attaching a new disk created from local disk offering with tags, to a VM was > going to wrong local storage pool. > Cause : In LocalStoragePoolAlocator- > List<StoragePoolHostVO> hostPools = > _poolHostDao.listByHostId(plan.getHostId()); > It return pools by hostId, but nowhere were the tags being compared. > > Added new method findLocalStoragePoolsByHostAndTags() that returns stoage > pools by hostid and tags both. > > > Diffs > ----- > > > engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml > ea0bad9 > > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java > 59c338e > > engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java > d35aa44 > > engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java > 1f61e8b > server/test/resources/createNetworkOffering.xml c6228da > > Diff: https://reviews.apache.org/r/18352/diff/ > > > Testing > ------- > > Tested the folowing scenarios: > attaching local volume with tags > attaching local volume without tags > attaching local volume with different tags > attaching shared volume > > Build passes successfully. > Patch applies cleanly. > > > Thanks, > > Saksham Srivastava > >
