Currently there are no functional tests, did e2e tests manually. There are some external setup that is required which then needs to be added to Cloudstack like Nexus 1000v, VNMC, ASA 1000v appliance details. I don't see any existing tests related to Vmware/Nexus stuff which I can reuse, so implementing all these steps would need some time.
So wanted to check if it is ok to merge now and add the functional tests subsequently? -Koushik > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, April 11, 2013 11:19 PM > To: dev@cloudstack.apache.org > Subject: Re: [MERGE] ASA 1000v as external firewall in isolated guest > networks > > On Mon, Apr 08, 2013 at 01:08:42PM +0000, Koushik Das wrote: > > I would like to merge the feature "ASA 1000v as external firewall in > > isolated > guest networks" to master. Please find the details here: > > > > Proposal: > > http://mail-archives.apache.org/mod_mbox/incubator-cloudstack- > users/20 > > 1301.mbox/%3ccd0b6bea.167bb%25manan.s...@citrix.com%3E > > FS: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cisco+VNMC+int > egration. The supported use cases are the ones mentioned under "Use cases > -> For 4.2". > > Jira: https://issues.apache.org/jira/browse/CLOUDSTACK-742 > > Branch: > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h= > > refs/heads/cisco-vnmc-api-integration > > Unit tests: Added unit tests for relevant network element interfaces > > (see under plugins/network-elements/cisco-vnmc/test) > > RAT: ran the rat check and all newly added files are clean Open > > issues: Currently there is an issue with source NAT configuration. Following > up with Cisco engineers on a private thread to resolve it. I will open a > separate ticket to track it. > > > > Thanks, > > Koushik > > Any functional tests? > > Otherwise LGTM.
