Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605573
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37605569
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-133351307
Daan,
Thanks for reviewing the document, the observations are incorporated.
---
If your project is set up for it, you can reply
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-133352253
Where ever there is a DB change the pattern is use. The plain switch is
used where it is db readonly.
---
If your project is set up for it, you can reply
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37716584
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37716634
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-134027847
@jburwell @DaanHoogland There is a underlying connection pool to save on
expensive db connection operations. Moreover this cost should be similar to
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-134480002
I think we should not be using TransactionLegacy anymore. It was used in
first place just to be consistent with UsageServer and due to time constraints.
I
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-134855999
@jburwell was looking at com.cloud.utils.db.Transaction class the db is
hardcoded in there:
execute()
short databaseId
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950152
--- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java ---
@@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950196
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950304
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950329
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950380
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950415
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950425
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950517
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950548
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950577
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950573
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950620
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java ---
@@ -0,0 +1,296 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950673
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950718
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950745
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950862
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950867
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950915
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37950999
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952261
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,465 @@
+//Licensed to the Apache Software Foundation
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952242
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,465 @@
+//Licensed to the Apache Software Foundation
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952248
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,465 @@
+//Licensed to the Apache Software Foundation
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952280
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,471 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952296
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,471 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952287
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,471 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952257
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java ---
@@ -0,0 +1,465 @@
+//Licensed to the Apache Software Foundation
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37952302
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,471 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-134875791
The Transaction open and close causing churn in database connection is
based on the notion that these methods somehow open and close db connections.
As
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/740#issuecomment-134952809
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r38059425
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java
---
@@ -0,0 +1,85 @@
+// Licensed to the Apache
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r38060134
--- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java
---
@@ -0,0 +1,471 @@
+//Licensed to the Apache Software
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-138230799
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62796102
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62796202
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -485,6 +485,10 @@ updateVPCOffering=1
deleteVPCOffering=1
listVPCOfferings
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819386
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819265
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819354
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819397
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819375
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819412
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819537
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819651
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62819915
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,329 @@
+// Licensed to the Apache Software Foundation (ASF
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62824571
--- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java ---
@@ -0,0 +1,86 @@
+//
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826214
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62826751
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827143
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62827236
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java
---
@@ -0,0 +1,93 @@
+//
+// Licensed to the
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62831265
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
---
@@ -1445,28 +1466,31 @@ public
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62835972
--- Diff:
engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java ---
@@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62837384
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62962859
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963628
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62963739
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62965518
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62967326
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62989315
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java ---
@@ -0,0 +1,95 @@
+//
+// Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63130081
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63139322
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,329 @@
+// Licensed to the Apache Software Foundation (ASF
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218978117
@SudharmaJain it is a unit test failure triggered by an assert. cc @rhtyd
It is being generated by ProcessRunner.
---
If your project is set up for it
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218978811
LGTM based on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-218997501
@jburwell briefly moving to java 8 made me realise that it has lot more
ipv6 primitives then there are in 7.
---
If your project is set up for it, you
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219009712
read the document LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-220239213
@rhtyd @anshul1886 This week I rebased the ospf changes with current master
and did not have any issues. OSPF adds 2 new APIs and they are using the new
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-220533410
With java 8 we will also get enhanced testing frameworks, specially
junit-quickcheck, that will help us in writing more expressive and compact test
cases
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64323811
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221160321
The AddNuageVspDeviceCmd can be upgraded to follow new RBAC pattern for
access permissions, api and response naming. (Look at CreateRoleCmd.java).
After
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221200314
LGTM based on code review and template build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1587
WIP: Removed the java dependency for packaging KVM agent.
Checked that JAVA_HOME env variable will be honoured.
So install KVM agent on tareget host with pre installed java
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1587
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1626
LGTM on code review and tested the systemvm build on OSX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1115
fixed in master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1631
LGTM on review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1115
@rhtyd yes it is merged in 4.9 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1639
CLOUDSTACK-9453: WIP : Marvin optimizations and fixes.
1. Adding small sized macchinina template as built in templates
2. Adding methods so the test writers haev choice to use
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1641
CLOUDSTACK-9459: the try's catch blick was shortening the preparedstatement
life
the try's catch blick was shortening the preparedstatement's life resulting
in bad
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1643
CLOUDSTACK-9460: For long running transactions, if the connection is
timed out by the mysql server then refresh it
You can merge this pull request into a Git repository by running
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75614167
--- Diff: setup/db/db/schema-490to491.sql ---
@@ -0,0 +1,4 @@
+
+LOCK TABLES `vm_template` WRITE;
+INSERT INTO `vm_template` VALUES
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1639#discussion_r75614226
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
---
@@ -92,6 +92,7 @@ public
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1648
LGTM based on code review, the order of cleanup is fixed so that the
resources are released in right order.
---
If your project is set up for it, you can reply to this email and have
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1657
LGTM on code review, this will fix the broken symlink for usage server
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1656
LGTM on code review, the fix is taking care of the removed column, thereby
maintaining the constraints.
---
If your project is set up for it, you can reply to this email and have
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1643
@rhtyd rebased with 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1667
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele @koushik-das When the MS thinks that the VM is down, it issues
a stop command. This is done to clear up the resources on management server db
tied up for that VM. Now it
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1670
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1667
@rhtyd created another PR for 4.9
https://github.com/apache/cloudstack/pull/1670
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1654
Looks good on code review
here is my LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1667
Closing as it is already merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
201 - 300 of 450 matches
Mail list logo
