/11611/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
111586d
Diff: https://reviews.apache.org/r/11850/diff/
Testing
---
Advanced zone creation proceeds correctly with fix in place.
Thanks,
Venkata Siva Vijayendra Bhamidipati
o GUI.
Thanks,
Venkata Siva Vijayendra Bhamidipati
---
Confirmed that template download works for templates registered across zones as
well as with individual zones.
Thanks,
Venkata Siva Vijayendra Bhamidipati
://reviews.apache.org/r/12149/diff/
Testing
---
Confirmed that template download works for templates registered across zones as
well as with individual zones.
Thanks,
Venkata Siva Vijayendra Bhamidipati
fail
with a GUI error dialog instead of failing silently with an NPE in the mgmt
server log.
Thanks,
Venkata Siva Vijayendra Bhamidipati
branch
https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
Thanks,
Venkata Siva Vijayendra Bhamidipati
mpl.java 20b435c
>
> Diff: https://reviews.apache.org/r/11984/diff/
>
>
> Testing
> ---
>
> Deploy KVM cluster in cloudstack. Attempt to add a primary NFS datastore
> using an invalid path. NPE is not encountered anymore. If KVM host is down or
> the cloud-agent on the KVM host is down, the primary datastore (whether valid
> or otherwise) is not logged to the db's storage_pool table. So invalid
> datastores do not show up in the GUI when listing the primary datastores
> available. Also, exception is propagated to GUI.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
able. Also,
exception is propagated to GUI.
Thanks,
Venkata Siva Vijayendra Bhamidipati
ayendra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22563
-----------
On July 3, 2013, 12:25 a.m., Venkata Siva Vijayendra Bh
le to locate datastore
with id 3
- Venkata Siva Vijayendra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22562
-----------
On July 3
patch for master-6-17-stable branch
https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
Thanks,
Venkata Siva Vijayendra Bhamidipati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
---
Ship it!
Fix looks good.
- Venkata Siva Vijayendra Bhamidipati
wide primary can only be moved to other zone wide primary pools and similarly
with cluster wide pools. Created new guest VM to confirm that existing primary
code paths work correctly with the changes in place.
Thanks,
Venkata Siva Vijayendra Bhamidipati
ra configs.
Diffs
-
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
372cc1b
Diff: https://reviews.apache.org/r/12369/diff/
Testing
---
With the fix, the VR comes up successfully, and guest VMs get created.
Thanks,
Venkata Siva Vijayendra Bhamidipati
,
Venkata Siva Vijayendra Bhamidipati
pvlan shared network. The VR rebooted
successfully without erroring out. Created multiple pvlan networks and
associated guest VMs and restarted the VRs, all rebooted successfully. Created
guest VMs with multiple pvlan networks in each and they also worked as expected.
Thanks,
Venkata Siva
of a non root volume of a guest VM in a vmware
deployment works instead of throwing the exception pasted in the bug
description.
Thanks,
Venkata Siva Vijayendra Bhamidipati
networks in each and they also worked as expected.
Thanks,
Venkata Siva Vijayendra Bhamidipati
.java b5c060d
Diff: https://reviews.apache.org/r/12566/diff/
Testing
---
Issue non-reproducible during manual testing.
Thanks,
Venkata Siva Vijayendra Bhamidipati
server/src/com/cloud/template/TemplateManagerImpl.java c7cc818
Diff: https://reviews.apache.org/r/12612/diff/
Testing
---
With the fix in place, vmware-tools.iso attach to a vmware guest VM works as
expected.
Thanks,
Venkata Siva Vijayendra Bhamidipati
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12612/#review23217
-----------
On July 17, 2013, 12:18 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> ---
.
Thanks,
Venkata Siva Vijayendra Bhamidipati
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12612/#review23217
---------------
On July 17, 2013, 12:39 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> ---
>
ue and update DB to put iso
> id for this VM. Why did you change to return false here?
>
> Venkata Siva Vijayendra Bhamidipati wrote:
> Hi Min, VMWare does not allow attaching the vmware tools iso if the VM is
> not running. Here is the exception response we get from vCenter if t
s (updated)
-
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
4113803
Diff: https://reviews.apache.org/r/12612/diff/
Testing
---
With the fix in place, vmware-tools.iso attach to a vmware guest VM works as
expected.
Thanks,
Venkata Siva
/
Testing
---
This showed up in automation tests in the code path that handles template sync
operations. I wasn't able to reproduce this in a manual setup. But the NPE does
exist and the code needs to be fixed for that, so I'm submitting the patch.
Thanks,
Venkata Siva
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12702/#review23354
---
Ship it!
Ship It!
- Venkata Siva Vijayendra Bhamidipati
On July
ested and they are
working as expected. This is a functional change, and completely transparent to
any of cloudstack's existing functionalities and all the test cases that cover
the above code paths and APIs - all existing tests should and do pass - no new
tests are necessary.
Thanks,
Ve
ated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24078
---
On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> ---
> This is an auto
> On July 29, 2013, 3:59 a.m., Jenkins Cloudstack.org wrote:
> > Review 13008 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #65 is :
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/
>
> Venkata Siva V
lities and all the test cases that cover
the above code paths and APIs - all existing tests should and do pass - no new
tests are necessary.
Thanks,
Venkata Siva Vijayendra Bhamidipati
seem to be some other exceptions
with some VMs, but they are not related to this code path.
Thanks,
Venkata Siva Vijayendra Bhamidipati
nkata Siva Vijayendra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13093/#review24312
---
On July 31, 2013, 12:41 a.m., Venkata Siva Vijayen
etely transparent to
any of cloudstack's existing functionalities and all the test cases that cover
the above code paths and APIs - all existing tests should and do pass - no new
tests are necessary.
Thanks,
Venkata Siva Vijayendra Bhamidipati
14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
++-+-+--+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
tests are necessary.
UPDATE for 08/05/2013
=
4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will
test out refactored patch and resubmit.
Thanks,
Venkata Siva Vijayendra Bhamidipati
of latest 4.2. Will
test out refactored patch and resubmit.
Thanks,
Venkata Siva Vijayendra Bhamidipati
38 | Complete |
| 2 | 4.1.0 | 2013-08-05 14:42:20 | Complete |
| 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
++-+-+--+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
|
| 3 | 4.1.1 | 2013-08-05 14:42:20 | Complete |
| 4 | 4.1.2 | 2013-08-05 14:42:20 | Complete |
++-+-+--+
4 rows in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
1000v vSwitch in VMware environment |
+--+--+---+--+---++
1 row in set (0.00 sec)
mysql>
Thanks,
Venkata Siva Vijayendra Bhamidipati
.org/r/13547/
> ---
>
> (Updated Aug. 14, 2013, 12:46 a.m.)
>
>
> Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
>
>
> Bugs: cloudstack-4308
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> For 6.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/#review25115
---
Ship it!
Ship It!
- Venkata Siva Vijayendra Bhamidipati
On Aug
> On Aug. 28, 2013, 7:39 p.m., Fang Wang wrote:
> > Ship It!
>
> Fang Wang wrote:
> Looks fine.
Patch checked in to 4.2-forward in commit #
f2874d0f228680b0dcd3299bb070215a2648a4a8
- Venkata Siva Vijayendra
---
This is an automati
had no data centers created in it, to 4.2, and the
flag was set to true post upgrade.
2) Upgraded from 3.0.6 that had data centers created in it, to 4.2, and the
flag was set to false post upgrade.
3) Deployed a fresh 4.2.0 setup, and the flag was set to true.
Thanks,
Venkata Siva Vijayendra
://reviews.apache.org/r/10071/diff/
Testing
---
Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
Thanks,
Venkata Siva Vijayendra Bhamidipati
02459b4
server/src/com/cloud/configuration/Config.java 17fe62b
setup/db/db/schema-40to410.sql 754bfb6
Diff: https://reviews.apache.org/r/10071/diff/
Testing
---
Baremetal and Cisco UCS related APIs confirmed to not be exposed to clients.
Thanks,
Venkata Siva Vijayendra Bhamidipati
/NetworkServiceImpl.java 0cd3ebe
Diff: https://reviews.apache.org/r/10144/diff/
Testing
---
Confirmed that basic zone creation succeeds without failing at the physical
network creation stage. Advanced zone creation also was checked to work
correctly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
315&response=json'
{ "listvmsnapshotresponse" :
{"errorcode":431,"cserrorcode":4350,"errortext":"could not find account
c896cef6-2e69-47cd-8bdb-9f963b4053d8 in domain
26481c20-96f8-11e2-afa5-000c29db3315"} }
#
Thanks,
Venkata Siva Vijayendra Bhamidipati
/nonossComponentContext.xml.in or
client/tomcatconf/componentContext.xml.in as applicable, to the desired order:
Thanks,
Venkata Siva
figured, and authenticated
> by the same scheme.
>
> To change the order of the schemes, modify the following list properties in
> client/tomcatconf/nonossComponentContext.xml.in or
> client/tomcatconf/componentContext.xml.in as applicable, to the desired order:
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
:
Thanks,
Venkata Siva Vijayendra Bhamidipati
sired order:
Thanks,
Venkata Siva Vijayendra Bhamidipati
ud/vm/UserVmManagerImpl.java 24bce8b
server/test/com/cloud/vm/MockUserVmManagerImpl.java dd8dd83
setup/db/create-schema.sql b1feb02
setup/db/db/schema-410to420.sql ab9df05
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
s such as create-schema.sql"
Thanks for catching that - I'll remove it.
- Venkata Siva Vijayendra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10294/#review18704
------
isit:
https://reviews.apache.org/r/10294/#review18713
-------
On April 5, 2013, 1:56 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> ---
> This is an automatically generated
3
setup/db/db/schema-410to420.sql ab9df05
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
> > If we handle POST request method on the ApiServlet class and accept
> > userdate from POST request, this would work. Cheers.
>
> Venkata Siva Vijayendra Bhamidipati wrote:
> Yes, the POST will be handled by ApiServlet's doPost() only, and the
> userdata will need
a PRE-CREATION
server/test/resources/UserVMDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql c7c8b5b
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
d e-mail. To reply, visit:
https://reviews.apache.org/r/10294/#review19030
---
On April 10, 2013, 9:59 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -
/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION
server/test/resources/UserVMDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql fb760bf
tools/marvin/marvin/cloudstackConnection.py 1caeef3
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
e.org/r/10294/#review19032
---
On April 16, 2013, 2:53 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
mber of lines :) Is there a way I can merge those two separate calls to
urllib2.Request(url) and urllib2.Request(url, requestUrl) into a single call?
- Venkata Siva Vijayendra
---
This is an automatically generated e-mail. To reply, visit:
htt
server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION
server/test/resources/UserVMDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql 6a7a72c
tools/marvin/marvin/cloudstackConnection.py 1caeef3
Diff: https://reviews.apache.org/r/10294/diff/
Testing
-------
Thanks,
Venkata Siva Vijayendra Bhamidipati
/componentContext.xml.in 7a46981
client/tomcatconf/nonossComponentContext.xml.in 2359ba8
Diff: https://reviews.apache.org/r/10616/diff/
Testing
---
Creation of a cluster of hypervisor type baremetal succeeds with these changes
in.
Thanks,
Venkata Siva Vijayendra Bhamidipati
cdbba
test/integration/component/test_deploy_vm_with_userdata.py PRE-CREATION
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
onent/test_deploy_vm_with_userdata.py PRE-CREATION
Diff: https://reviews.apache.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
e.org/r/10294/diff/
Testing
---
Thanks,
Venkata Siva Vijayendra Bhamidipati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10294/#review19572
---
- Venkata Siva Vijayendra Bhamidipati
On April 23, 2013, 1:55 a.m
et support POSTable APIs, as soon as that is made available for
create/update VM operations, marvin tests will be written for the same.
Requesting that this be noted as an AI for the future.
Thanks,
Venkata Siva Vijayendra Bhamidipati
for the future.
Thanks,
Venkata Siva Vijayendra Bhamidipati
dated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
eview request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
value set during their creation. VM live migration using vmware vMotion has
also been tested with these changes on vmware and it works as expected.
Further testing will be carried out and this review request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
eview request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
>
> > Reason to remove type converting?
Again, eclipse generated, but why would we need that cast? I would remove it.
- Venkata Siva Vijayendra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.ap
.
Further testing will be carried out and this review request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
ng vmware vMotion has
also been tested with these changes on vmware and it works as expected.
Further testing will be carried out and this review request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
eation. VM live migration using vmware vMotion has
also been tested with these changes on vmware and it works as expected.
Further testing will be carried out and this review request will be updated
accordingly.
Thanks,
Venkata Siva Vijayendra Bhamidipati
80 matches
Mail list logo
