----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ -----------------------------------------------------------
(Updated April 23, 2013, 9:45 p.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen. Changes ------- Hi Prasanna, Min, Adding the AL header to the marvin testcase. This latest diff is on top of master. I'm not sure why my patches are having issues in the past few submissions - I generate the patch using git format-patch -M -C options and it's worked before.. please do let me know what you follow, and I'll use the same steps going forward. I hope this patch applies. Regards, Vijay Description ------- Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements for a background on the requirements driving this patch. This patch hasn't been extensively tested yet, and I will update this request with more info. I am uploading a first diff for initial review/comments. This addresses bug CLOUDSTACK-1086. Diffs (updated) ----- api/src/com/cloud/vm/UserVmService.java aa21136 api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 70c0159 api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java ff8fff1 core/src/com/cloud/vm/UserVmVO.java a16eaf9 server/src/com/cloud/api/ApiDispatcher.java 925d90a server/src/com/cloud/api/ApiServer.java d842819 server/src/com/cloud/api/ApiServerService.java 12d8b52 server/src/com/cloud/api/ApiServlet.java 03bfb5f server/src/com/cloud/vm/UserVmManagerImpl.java 1843f60 server/test/com/cloud/vm/MockUserVmManagerImpl.java 0d0a8f4 server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION server/test/resources/UserVMDaoTestContext.xml PRE-CREATION setup/db/db/schema-410to420.sql 10cdbba test/integration/component/test_deploy_vm_with_userdata.py PRE-CREATION Diff: https://reviews.apache.org/r/10294/diff/ Testing ------- Manual testing done with scripts generating large/small userdata during creation of VMs, with both GET and POST requests confirmed to work correctly, on both integration port and the 8080 port. Basic Marvin test to create a VM with user data has been written. Since marvin doesn't yet support POSTable APIs, as soon as that is made available for create/update VM operations, marvin tests will be written for the same. Requesting that this be noted as an AI for the future. Thanks, Venkata Siva Vijayendra Bhamidipati
